Commit Graph

221 Commits

Author SHA1 Message Date
Dimitrie Stefanescu 4e48427bee Revit receive first pass: reference geometry workflow (CNX-403) (#254)
* feat(dui3): re-enables receive binding

probably the fourth time

* chore(revit): drastic cleanup

maybe too drastic, we will see soon

* feat(revit): starts scaffolding revit root to host converter

* RenderMaterialToHostConverter added back

* casting to GeometryObject instead of GeometryElement

* feat(dui3): fallback display values and refactors out material converter

* feat(dui3): creates DS and adds point support

* feat(dui3): closed nurbs fallback to display values

* David/cnx 443 selection (#231)

* highlight works

* use status.success on receive success

* question comment

* wip

* feat(revit): wraps receive in correct context

* wip

* feat(dui3): adds prototype grouping by collection

and adds todos

* remove invalid characters from group name

* hide warnings preprocessor

* exception handling and error log

* added cancellation and progress reporting

* chore: comments and minor cleanup

* David/cnx 409 2 add rendermaterial and color manager to connector (#242)

* materials wip

* Make it work receiving render materials

* MaterialBaker mods, cleanup

* Address the PR comments

* Remove invalid chars from structured material names

---------

Co-authored-by: oguzhankoral <oguzhankoral@gmail.com>

* Minor cleanup

* Add object application id into objects of its layer render material proxy

* feat(dui3): adds compatibility for objects with display values

* Use LocalToGlobal logic for revit receive

* Use common local to global util for arcgis too

* Remove unnecessary registration

* Remove using

* Remove unnecessart ToList

* Register LocalToGlobalConverterUtils for connectors not as common

* purge materials and groups in Revit before update (#245)

* purge materials and groups in Revit before update

* cleaner linq

* renamed _groupManager to _groupBaker

* assign categories to DirectShapes after receive, updated revit invalid chars (#253)

* Post conflict resolving problems

* minor changes, logging, comments (#257)

* minor changes, logging, comments

* typo

---------

Co-authored-by: David Kekesi <david@speckle.systems>
Co-authored-by: kekesidavid <david.kekesi@gmail.com>
Co-authored-by: oguzhankoral <oguzhankoral@gmail.com>
2024-09-19 14:09:17 +03:00
Oğuzhan Koral 2418b3e564 Fix(rhino): missing render material of layers on second send (#252)
* Fix the missing RenderMaterial prop of Layer

* Continue if RenderMaterial is set
2024-09-18 18:47:54 +03:00
Adam Hathcock 4a2233e167 SDK is non static and logging/tracing controls are moved to the connectors (#239)
* use new containerized SDK

* Use containered Tracing and Logging

* Autocad loads

* logging builds

* fmt

* Remove console logger and hook up merged logging

* cleanup

* Clean up logging

* use nuget

* Add Logging project to solution then consolidate getting assembly version

* don't need this project anymore

* merge fixes

* add new seq config

---------

Co-authored-by: Jedd Morgan <45512892+JR-Morgan@users.noreply.github.com>
2024-09-18 14:13:18 +00:00
Adam Hathcock 1dbb2b6abe Dispose Containers (except for Autocad) (#250) 2024-09-18 16:03:56 +02:00
Oğuzhan Koral b52d66c522 Pass base object not mesh under displayValues (#249) 2024-09-18 14:57:52 +03:00
Adam Hathcock 3454587330 Add tracing around conversions and success/failure exceptions (#241)
* Add tracing around conversions and success/failure exceptions

* merge fixes
2024-09-18 10:03:09 +00:00
Adam Hathcock 8d0d7a89f7 Change conversion stack to better usage for products. (#215)
* fix: Push to sync with Jedd

* Jedd's record suggestions

* cleanup stack

* Revit settings converted

* more settings changes

* fix unit of work and scope registration

* rename

* fix more settings

* Use a generic factory to create settings contexts

* fix ArcGIS

* generic sending

* fix ArcGIS

* remove extras

* fix crs scoping

* fix autocad

* fix units for arcgis

* civil3d conversions

* rhino mostly works

* Rhino and recieve changed

* fix revit tests

* fix rhino tests

* fix merge

* make settings a record again

* fixes from reversion

* merge fixes

* ArcGIS reverts

* more senders reverted

* remove added reference

* clean up locks and files

* update nunit

* make things proper records

* fix test

* Merge fixes

* merge fixes

* Initialize the settings instead of push empty

* scan things consistently

---------

Co-authored-by: Alan Rynne <alan@speckle.systems>
Co-authored-by: Jedd Morgan <45512892+JR-Morgan@users.noreply.github.com>
2024-09-17 14:42:00 +02:00
Oğuzhan Koral cc285e99ee Add WorkspaceId to model card (#236)
it is needed to store information between sessions
2024-09-16 16:49:11 +03:00
Jedd Morgan eb8f8defc0 Jedd/cxpla 55 add required keyword for more geometry types (#220)
* Nullability of TryGet function

* blip

* Connector side changes

* Fixes

* Fixed other SDK changes

* Fixed Meters defaulting in Revit

* Agis fix required units (#224)

* fix arcgis units

* usings

* correct units

---------

Co-authored-by: Jedd Morgan <45512892+JR-Morgan@users.noreply.github.com>

* Fixed compiler errors

* Resolved PR Comments

* Fixed last revit units issue

* extras

* Bumped sdk deps

---------

Co-authored-by: KatKatKateryna <89912278+KatKatKateryna@users.noreply.github.com>
2024-09-16 11:09:49 +02:00
KatKatKateryna 466ac5e49d AGIS mesh boundaries (#222) 2024-09-16 16:47:06 +08:00
Dimitrie Stefanescu 359954cd11 Merge pull request #238 from specklesystems/oguzhan/cnx-436-autocad-wrong-arc-conversions-again
Fix(autocad): Evaluate mid point with angle
2024-09-13 12:24:58 +01:00
oguzhankoral 55e8ad8493 Evaluate mid point with angle 2024-09-12 19:22:56 +03:00
Oğuzhan Koral 3d64a3c4b7 Feat(dui3): improve root and host builders (#226)
* Remove SyncToThread from connectors

* Run only conversion under RevitTask.RunAsync

* Remove SyncToThread from RhinoHostObjectBuilder

* Introduce RootObjectUnpacker

* Split bakers and unpackers for Rhino

* Remove unnecessary out

* Use RootObjectUnpacker for proxies

* Extract proxy keys to outside

* Remove redundant comment

* Add logger for unpackers and bakers

* Add steps to RhinoRootObjectBuilder

* Pass only projectId instead of all SendInfo to ConvertRhinoObject function

* Align AutocadRootObjectBuilder with RhinoRootObjectBuilder

* Align AutocadHostObjectBuilder with RhinoHostObjectBuilder

* Use ProxyKeys on arcgis and revit

* Split unpackers and bakers for autocad

* Note to Autocad SyncToThread

* Add logger to autocad unpackers and bakers

* Notes

* Reimplemented Async builder (#229)

* Split layer manager into bakers and unpackers

Also introduces LayerPathUnpacker as abstract class to handle GetLayerPath

* Remove redundant notes

* Make GetLayerPath logic same for autocad and rhino

* Use ex instead e for exception

* chore: fixes PR comments

---------

Co-authored-by: Jedd Morgan <45512892+JR-Morgan@users.noreply.github.com>
Co-authored-by: Dimitrie Stefanescu <didimitrie@gmail.com>
2024-09-11 20:26:21 +03:00
Oğuzhan Koral 75ebf8f549 Add new properties to ReceiverModelCard for mixpanel tracking (#234) 2024-09-11 12:53:10 +01:00
Oğuzhan Koral 4c462923f2 Use default CancellationTokenSource.None (#233) 2024-09-11 11:16:35 +01:00
Oğuzhan Koral 53522a8307 Increase time span for ActionBlock (#232) 2024-09-11 08:48:59 +00:00
Adam Hathcock 7e4125cb93 Switch tracing to seq dev. Turn off tracing to console when debugging (#228) 2024-09-10 14:03:21 +00:00
Alan Rynne 0a568ac9fd fix(gitversion): Use GitFlow defaults (#230) 2024-09-10 13:50:26 +00:00
Alan Rynne 859193be37 fix: Delete build artifacts after build-installers job is done (#225)
Do so regardless of fail/success of the deployment
2024-09-10 14:52:48 +02:00
Adam Hathcock 49c2494d3c Build Revit 2022 on Local (#227) 2024-09-09 14:24:22 +02:00
Jedd Morgan cfe1980e7a bump sdks
.NET Build and Publish / build (push) Has been cancelled
.NET Build and Publish / test (push) Has been cancelled
.NET Build and Publish / deploy-installers (push) Has been cancelled
v3.0.0-beta.201
2024-09-06 14:22:23 +01:00
Oğuzhan Koral f1a5a4cbfe Use Invoke function instead InvokeAsync (#223) 2024-09-06 13:34:22 +03:00
KatKatKateryna ddccb44341 remove unused function (#221)
* remove unused

* usings

* shuffle
2024-09-05 21:31:43 +01:00
kekesidavid 98f43032a0 fix(Revit):CNX-414 fixes DirectShape category bug (#219)
* direct shape not sending fix

* extended POC comment
2024-09-05 11:44:28 +02:00
KatKatKateryna 7bbc3a0121 Agis fix geometry deviations (#211)
* pass down the same SpatialReference

* fixes

* Revert "fixes"

This reverts commit e443f293b4.

* Revert "pass down the same SpatialReference"

This reverts commit 7cc8d5f4df.

* only pass CRS after densification

* comment
2024-09-03 13:32:01 +00:00
KatKatKateryna 02e7ed95b4 AGIS more specific document naming (#218)
* more specific document naming

* clear cache
2024-09-03 13:20:47 +00:00
KatKatKateryna ff540caad7 fix update changed IDs (#209)
* fix update changed IDs

* better naming

* remove initial count

* move layer order method also to mapMemberUtils

* loop

* better names

* comment

* fix

* split layers and tables

* refactor layer loop
2024-09-03 13:15:22 +00:00
Jedd Morgan d78345367b Nullability of TryGet function (#217)
.NET Build and Publish / build (push) Has been cancelled
.NET Build and Publish / test (push) Has been cancelled
.NET Build and Publish / deploy-installers (push) Has been cancelled
v3.0.0-beta.194
2024-09-03 08:49:32 +01:00
Alan Rynne 236cdb4a23 chore: Use rc version of SDK and Objects (#216)
* chore: Use 3.0.1-rc in all connectors

* fix: Remove USFeet from unit support in Civil and ArcGIS
2024-09-02 13:51:48 +01:00
Jedd Morgan 9d6c91485e Add logging of send conversions (#214)
* Added logging to IRootToHostConverter

* Log send conversion errors

---------

Co-authored-by: Dimitrie Stefanescu <didimitrie@gmail.com>
Co-authored-by: Oğuzhan Koral <45078678+oguzhankoral@users.noreply.github.com>
2024-09-02 13:41:37 +01:00
Jedd Morgan 077ac246a8 Added logging to IRootToHostConverter (#212)
Co-authored-by: Dimitrie Stefanescu <didimitrie@gmail.com>
Co-authored-by: Oğuzhan Koral <45078678+oguzhankoral@users.noreply.github.com>
2024-08-30 19:34:33 +01:00
Claire Kuang 7852b1d2ff fix(revit): CNX-394 better reference point cache invalidation (#213)
* adds reference point transform to xyz, and refactors

* spelling fixes

* adds reference point caclulation to connector instead of converter

* disables xyz test for now due to complications mocking the reference point converter

* moves reference point transform method to separate class

* extracts to speckle settings into manager singleton

* removes  unecessary usings

* Pragma the send function sorry to not sorry

* optimizes mesh conversions

* removes unnessary meshconversion method and adds reference point transform to meshlist conversion

* better reference point invalidation logic

* Update MeshByMaterialDictionaryToSpeckle.cs

* fixes id evictions for objects that need to be unpacked

* removes circular dependency

---------

Co-authored-by: oguzhankoral <oguzhankoral@gmail.com>
Co-authored-by: Oğuzhan Koral <45078678+oguzhankoral@users.noreply.github.com>
2024-08-30 20:44:51 +03:00
Claire Kuang 6b7574e5fb feat(revit): CNX-340 add reference point setting to revit send (#203)
* adds reference point transform to xyz, and refactors

* spelling fixes

* adds reference point caclulation to connector instead of converter

* disables xyz test for now due to complications mocking the reference point converter

* moves reference point transform method to separate class

* extracts to speckle settings into manager singleton

* removes  unecessary usings

* Pragma the send function sorry to not sorry

* optimizes mesh conversions

* removes unnessary meshconversion method and adds reference point transform to meshlist conversion

---------

Co-authored-by: oguzhankoral <oguzhankoral@gmail.com>
Co-authored-by: Oğuzhan Koral <45078678+oguzhankoral@users.noreply.github.com>
2024-08-30 15:33:42 +01:00
Oğuzhan Koral e821e93ba5 Get dev mode info from config binding (#210) 2024-08-29 19:18:11 +03:00
KatKatKateryna 8744331ebb receive materials (#208)
* receive materials

* typos
2024-08-29 22:13:41 +08:00
Alan Rynne a5012eda02 chore: Silence SDK1206 warnings for now (#207)
* chore: Silence SDK1206 warnings for now

* fix: Do not include sha in product info version
2024-08-29 13:24:00 +01:00
Alan Rynne f9a8831fec CNX-369 Rename all UI elements and commands in v3 connectors (#206)
* feat: Renamed to v3

* feat: Use Speckle (Beta) and Speckle for XXX (Beta)

* feat: Change to `Speckle (Beta) for XXX`

* fix: Revert unintentional change

* fix: IDE0100 unnecessary equality check
2024-08-28 19:09:04 +03:00
KatKatKateryna 39ff7c9bba receive points as fallback displayValue (#205)
Co-authored-by: Oğuzhan Koral <45078678+oguzhankoral@users.noreply.github.com>
2024-08-28 13:23:36 +00:00
Oğuzhan Koral 2d345e606b Fix(revit): Reference to CefSharp.Wpf.NETCore for Revit 2025 (#204)
* Reference to CefSharp.Wpf.NETCore for revit 2025

* Remove commented out code
2024-08-28 15:00:11 +03:00
Oğuzhan Koral 93f2df0c9e Fix(revit): regression on switching ElementId to UniqueId (#202)
* Fix regression on switching ElementId to UniqueId

* Do not treat object ids in send filter as unique ids

* Use unique ids everywhere

* Get element ids from unique id also for highlight model

* Remove unnecessary using

* Remove unused Parse function

* Rename function

* Find intersection of invalidated objects with UniqueIds
2024-08-27 11:50:45 +03:00
Claire Kuang 2916af03e6 feat(revit): CNX-344 parameter elementid values sent as elements names when available (#201)
* uses element name instead of elementid as param value

* Update ParameterValueExtractor.cs
2024-08-27 09:24:14 +01:00
Claire Kuang 14a429f4de feat(revit): CNX-188 extract material quantities out for all objects (#184)
* adds material quantity conversions

* adds material quantities to top level converter

* fixed bugs

* Update MaterialQuantitiesToSpeckle.cs

* refactor material quantities (#196)

* combines material and render material conversion and removes bad logic

* simplifies caching logic

* minor notes

* fix(dui3): corrects merge, resolves some DI confusion around the typed converter & fixes a copy paste error

* fix(dui3): removes params from materials.

we can bring 'em back if we validate the need for them.

* feat(dui3): radical simplification of material quantity extraction

* chore: adds comments and flags things as obsolete

---------

Co-authored-by: Dimitrie Stefanescu <didimitrie@gmail.com>
2024-08-26 19:37:25 +03:00
Oğuzhan Koral ace7bdf3b4 Fail fast if all conversion status is ERROR (#200) 2024-08-26 16:31:17 +01:00
Oğuzhan Koral 41c96a032c Fix(rhino): Remove square brackets from material name (#198) 2024-08-26 09:32:58 +00:00
KatKatKateryna e369292979 Agis separate dataset creation (#170)
* arcgis debugging profiles

* refactor write to database

* support tables

* optimize renderers

* visible progress for grouping

* Revert "arcgis debugging profiles"

This reverts commit d5753cac9b.

* receiving gisFeatures separately

* more refactor, broken colors

* remove unused stuff

* avoid multiple loops

* keep the first assigned Speckle_ID, don't change on every receive

* color categories fixed

* closed polyline geometry fixed on send

* fix color categories

* fold layers

* delete reference to deleted converter

* invoke Converting msg earlier on receive

* comment
2024-08-26 09:55:54 +02:00
Oğuzhan Koral eab6770695 Do not skip first item if it is one-to-one conversion (#199) 2024-08-25 10:57:53 +01:00
Dimitrie Stefanescu 5cbb59db0a Dimitrie/cnx 358 caching element from another model sent (#197)
* fix(dui3): correctly invalidates cache and syncs id behaviour in revit

* fix: filters for nulls
2024-08-24 22:25:51 +03:00
Jedd Morgan a18c1b5ecf Bumped sdk to 115 (#192)
Co-authored-by: Oğuzhan Koral <45078678+oguzhankoral@users.noreply.github.com>
2024-08-24 00:33:54 +03:00
Claire Kuang 2c46b1d0b8 chore(autocad/rhino): CNX-357 removes unnecessary definition color logic (#194)
* removes definition color hack for autocad

* removes color hack from rhino

---------

Co-authored-by: Dimitrie Stefanescu <didimitrie@gmail.com>
2024-08-24 00:27:18 +03:00
Oğuzhan Koral 953ffcc293 Feat(Settings): revit settings passes to converter (#195)
* Map and pass setting to converter

* Change return type to ICardSettings

* Invalidate cache if the setting of model card has changed

* Default to medium for geometry fidelity

* Rename GeometryFidelity to DetailLevel

* Default to medium

* Pass detail level to options in DB.Options
2024-08-23 17:56:59 +01:00