huanld/speckle-sharp-connectors
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix (revit): Make revit exception be a conversion exception (#1105)

Browse Source 
* Make revit exception be a conversion exception

* Use ApplicationException

* chore: variable name

---------

Co-authored-by: Björn Steinhagen <steinhagen.bjoern@gmail.com>
This commit is contained in:
Adam Hathcock
2025-09-22 16:50:58 +01:00
committed by GitHub
parent 9ceb5621bc
commit 0aeecfd00a
1 changed files with 24 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Converters/Revit/Speckle.Converters.RevitShared/ToSpeckle/Raw/MaterialQuantitiesToSpeckle.cs
+24 -15
View File
@@ -3,6 +3,8 @@ using Speckle.Converters.Common.Objects;
using Speckle.Converters.Revit2023.ToSpeckle.Properties;
using Speckle.Converters.RevitShared.Services;
using Speckle.Converters.RevitShared.Settings;
using Speckle.Sdk.Common.Exceptions;
using ApplicationException = Autodesk.Revit.Exceptions.ApplicationException;
namespace Speckle.Converters.RevitShared.ToSpeckle;
@@ -80,22 +82,29 @@ public class MaterialQuantitiesToSpeckleLite : ITypedConverter<DB.Element, Dicti
quantities[matName] = materialQuantity;
}
// add area and volume props
var areaUnitType = unitSettings.GetFormatOptions(DB.SpecTypeId.Area).GetUnitTypeId();
AddMaterialProperty(
materialQuantity,
"area",
_scalingService.Scale(element.GetMaterialArea(matId, false), areaUnitType),
areaUnitType
);
try
{
// add area and volume props
var areaUnitType = unitSettings.GetFormatOptions(DB.SpecTypeId.Area).GetUnitTypeId();
AddMaterialProperty(
materialQuantity,
"area",
_scalingService.Scale(element.GetMaterialArea(matId, false), areaUnitType),
areaUnitType
);
var volumeUnitType = unitSettings.GetFormatOptions(DB.SpecTypeId.Volume).GetUnitTypeId();
AddMaterialProperty(
materialQuantity,
"volume",
_scalingService.Scale(element.GetMaterialVolume(matId), volumeUnitType),
volumeUnitType
);
var volumeUnitType = unitSettings.GetFormatOptions(DB.SpecTypeId.Volume).GetUnitTypeId();
AddMaterialProperty(
materialQuantity,
"volume",
_scalingService.Scale(element.GetMaterialVolume(matId), volumeUnitType),
volumeUnitType
);
}
catch (ApplicationException ex)
{
throw new ConversionException("Error in Material Quantities", ex);
}
}
}
}