From 0aeecfd00a38f7937e24304edf5861bd39e04c16 Mon Sep 17 00:00:00 2001
From: Adam Hathcock <adamhathcock@users.noreply.github.com>
Date: Mon, 22 Sep 2025 16:50:58 +0100
Subject: [PATCH] fix (revit): Make revit exception be a conversion exception
 (#1105)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* Make revit exception be a conversion exception

* Use ApplicationException

* chore: variable name

---------

Co-authored-by: Björn Steinhagen <steinhagen.bjoern@gmail.com>
---
 .../Raw/MaterialQuantitiesToSpeckle.cs        | 39 ++++++++++++-------
 1 file changed, 24 insertions(+), 15 deletions(-)

diff --git a/Converters/Revit/Speckle.Converters.RevitShared/ToSpeckle/Raw/MaterialQuantitiesToSpeckle.cs b/Converters/Revit/Speckle.Converters.RevitShared/ToSpeckle/Raw/MaterialQuantitiesToSpeckle.cs
index 0dc0ff869..63dee01f9 100644
--- a/Converters/Revit/Speckle.Converters.RevitShared/ToSpeckle/Raw/MaterialQuantitiesToSpeckle.cs
+++ b/Converters/Revit/Speckle.Converters.RevitShared/ToSpeckle/Raw/MaterialQuantitiesToSpeckle.cs
@@ -3,6 +3,8 @@ using Speckle.Converters.Common.Objects;
 using Speckle.Converters.Revit2023.ToSpeckle.Properties;
 using Speckle.Converters.RevitShared.Services;
 using Speckle.Converters.RevitShared.Settings;
+using Speckle.Sdk.Common.Exceptions;
+using ApplicationException = Autodesk.Revit.Exceptions.ApplicationException;
 
 namespace Speckle.Converters.RevitShared.ToSpeckle;
 
@@ -80,22 +82,29 @@ public class MaterialQuantitiesToSpeckleLite : ITypedConverter<DB.Element, Dicti
           quantities[matName] = materialQuantity;
         }
 
-        // add area and volume props
-        var areaUnitType = unitSettings.GetFormatOptions(DB.SpecTypeId.Area).GetUnitTypeId();
-        AddMaterialProperty(
-          materialQuantity,
-          "area",
-          _scalingService.Scale(element.GetMaterialArea(matId, false), areaUnitType),
-          areaUnitType
-        );
+        try
+        {
+          // add area and volume props
+          var areaUnitType = unitSettings.GetFormatOptions(DB.SpecTypeId.Area).GetUnitTypeId();
+          AddMaterialProperty(
+            materialQuantity,
+            "area",
+            _scalingService.Scale(element.GetMaterialArea(matId, false), areaUnitType),
+            areaUnitType
+          );
 
-        var volumeUnitType = unitSettings.GetFormatOptions(DB.SpecTypeId.Volume).GetUnitTypeId();
-        AddMaterialProperty(
-          materialQuantity,
-          "volume",
-          _scalingService.Scale(element.GetMaterialVolume(matId), volumeUnitType),
-          volumeUnitType
-        );
+          var volumeUnitType = unitSettings.GetFormatOptions(DB.SpecTypeId.Volume).GetUnitTypeId();
+          AddMaterialProperty(
+            materialQuantity,
+            "volume",
+            _scalingService.Scale(element.GetMaterialVolume(matId), volumeUnitType),
+            volumeUnitType
+          );
+        }
+        catch (ApplicationException ex)
+        {
+          throw new ConversionException("Error in Material Quantities", ex);
+        }
       }
     }
   }