huanld
2fb067ecbf
checklocks / checklocks (push) Has been cancelled
CodeQL / Analyze (go) (push) Has been cancelled
natlab-integrationtest / natlab-integrationtest (push) Has been cancelled
CI / gomod-cache (push) Has been cancelled
CI / race-root-integration (1/4) (push) Has been cancelled
CI / race-root-integration (2/4) (push) Has been cancelled
CI / race-root-integration (3/4) (push) Has been cancelled
CI / race-root-integration (4/4) (push) Has been cancelled
CI / test (-race, amd64, 1/3) (push) Has been cancelled
CI / test (-race, amd64, 2/3) (push) Has been cancelled
CI / test (-race, amd64, 3/3) (push) Has been cancelled
CI / test (386) (push) Has been cancelled
CI / test (amd64) (push) Has been cancelled
CI / Windows (benchmarks) (push) Has been cancelled
CI / Windows (1/2) (push) Has been cancelled
CI / Windows (2/2) (push) Has been cancelled
CI / macos (push) Has been cancelled
CI / privileged (push) Has been cancelled
CI / vm (push) Has been cancelled
CI / cross (386, linux) (push) Has been cancelled
CI / cross (amd64, darwin) (push) Has been cancelled
CI / cross (amd64, freebsd) (push) Has been cancelled
CI / cross (amd64, openbsd) (push) Has been cancelled
CI / cross (amd64, windows) (push) Has been cancelled
CI / cross (arm, 5, linux) (push) Has been cancelled
CI / cross (arm, 7, linux) (push) Has been cancelled
CI / cross (arm64, darwin) (push) Has been cancelled
CI / cross (arm64, linux) (push) Has been cancelled
CI / cross (arm64, windows) (push) Has been cancelled
CI / cross (loong64, linux) (push) Has been cancelled
CI / ios (push) Has been cancelled
CI / crossmin (amd64, illumos) (push) Has been cancelled
CI / crossmin (amd64, plan9) (push) Has been cancelled
CI / crossmin (amd64, solaris) (push) Has been cancelled
CI / crossmin (ppc64, aix) (push) Has been cancelled
CI / android (push) Has been cancelled
CI / wasm (push) Has been cancelled
CI / tailscale_go (push) Has been cancelled
CI / fuzz (push) Has been cancelled
CI / depaware (push) Has been cancelled
CI / go_generate (push) Has been cancelled
CI / make_tidy (push) Has been cancelled
CI / licenses (push) Has been cancelled
CI / staticcheck (macOS) (push) Has been cancelled
CI / staticcheck (Linux) (push) Has been cancelled
CI / staticcheck (Windows) (push) Has been cancelled
CI / staticcheck (Portable (1/4)) (push) Has been cancelled
CI / staticcheck (Portable (2/4)) (push) Has been cancelled
CI / staticcheck (Portable (3/4)) (push) Has been cancelled
CI / staticcheck (Portable (4/4)) (push) Has been cancelled
CI / notify_slack (push) Has been cancelled
CI / merge_blocker (push) Has been cancelled
CI / check_mergeability_strict (push) Has been cancelled
CI / check_mergeability (push) Has been cancelled
Dockerfile build / deploy (push) Has been cancelled
test installer.sh / test (curl, alpine:3.21) (push) Has been cancelled
test installer.sh / test (curl, alpine:edge) (push) Has been cancelled
test installer.sh / test (curl, alpine:latest) (push) Has been cancelled
test installer.sh / test (curl, amazonlinux:latest) (push) Has been cancelled
test installer.sh / test (curl, archlinux:latest) (push) Has been cancelled
test installer.sh / test (curl, debian:oldstable-slim) (push) Has been cancelled
test installer.sh / test (curl, debian:sid-slim) (push) Has been cancelled
test installer.sh / test (curl, debian:stable-slim, 1.80.0) (push) Has been cancelled
test installer.sh / test (curl, debian:testing-slim) (push) Has been cancelled
test installer.sh / test (curl, elementary/docker:stable) (push) Has been cancelled
test installer.sh / test (curl, elementary/docker:unstable) (push) Has been cancelled
test installer.sh / test (curl, fedora:latest, 1.80.0) (push) Has been cancelled
test installer.sh / test (curl, kalilinux/kali-dev) (push) Has been cancelled
test installer.sh / test (curl, kalilinux/kali-rolling) (push) Has been cancelled
test installer.sh / test (curl, opensuse/leap:latest) (push) Has been cancelled
test installer.sh / test (curl, opensuse/tumbleweed:latest) (push) Has been cancelled
test installer.sh / test (curl, oraclelinux:8) (push) Has been cancelled
test installer.sh / test (curl, oraclelinux:9) (push) Has been cancelled
test installer.sh / test (curl, parrotsec/core:latest) (push) Has been cancelled
test installer.sh / test (curl, rockylinux:8.7) (push) Has been cancelled
test installer.sh / test (curl, rockylinux:9) (push) Has been cancelled
test installer.sh / test (curl, ubuntu:20.04) (push) Has been cancelled
test installer.sh / test (curl, ubuntu:22.04) (push) Has been cancelled
test installer.sh / test (curl, ubuntu:24.04, 1.80.0) (push) Has been cancelled
test installer.sh / test (wget, debian:oldstable-slim) (push) Has been cancelled
test installer.sh / test (wget, debian:sid-slim) (push) Has been cancelled
update-flake / update-flake (push) Has been cancelled
tailscale.com/cmd/vet / vet (push) Has been cancelled
test installer.sh / notify-slack (push) Has been cancelled
Client security fixes (cmd/tailscale-tray/main.go): - SSRF protection in Add Server dialog (validateControlURL): reject private/loopback/link-local/cloud-metadata IPs via DNS resolution - RCE gate on AuthURL/BrowseToURL exec paths (validateAuthURL) - Sanitized URL logging (sanitizeURLForLog drops query auth tokens) - Error handling on exec.Command with user-facing showError() Admin panel security (web-admin): - Bcrypt password hashing (replaces SHA256) - Rate limiting: 5 failed logins → 15-min lockout - Session + login attempt cleanup goroutine (hourly) - url.QueryEscape / encodeURIComponent for all API params - Fail-hard startup when no TLS and non-loopback bind - ADMIN_PASSWORD required (no default), password min 12 chars - Username regex whitelist Installer hardening (Setup.wxs): - util:PermissionEx restricts SCM access: only Administrators + SYSTEM can start/stop/reconfigure service. Authenticated Users limited to QueryStatus/QueryConfig/Interrogate - Vital="yes" on ServiceInstall Docs & roadmap: - PRODUCTION_ROADMAP.md: 5-milestone plan (security + features + distribution + ops) with granular tasks, effort, done-when - CLIENT_SECURITY_AUDIT.md, SECURITY_FIXES.md, DEPLOYMENT.md - AI assistant rules (.cursorrules, .antigravityrules, etc.) Build & distribution: - build-msi.ps1, deploy-and-sign.ps1, sign-release.ps1 - redeploy.ps1, tray-deploy.ps1, test-msi.ps1 - installer/msi/ alternative WXS setup - Restored .github/workflows/ removed in mirror cleanup .gitignore hardened: *.pfx, *.p12, *.key, *.pem, .env*
107 lines
3.3 KiB
Markdown
107 lines
3.3 KiB
Markdown
---
|
|
name: code-archaeologist
|
|
description: Expert in legacy code, refactoring, and understanding undocumented systems. Use for reading messy code, reverse engineering, and modernization planning. Triggers on legacy, refactor, spaghetti code, analyze repo, explain codebase.
|
|
tools: Read, Grep, Glob, Edit, Write
|
|
model: inherit
|
|
skills: clean-code, refactoring-patterns, code-review-checklist
|
|
---
|
|
|
|
# Code Archaeologist
|
|
|
|
You are an empathetic but rigorous historian of code. You specialize in "Brownfield" development—working with existing, often messy, implementations.
|
|
|
|
## Core Philosophy
|
|
|
|
> "Chesterton's Fence: Don't remove a line of code until you understand why it was put there."
|
|
|
|
## Your Role
|
|
|
|
1. **Reverse Engineering**: Trace logic in undocumented systems to understand intent.
|
|
2. **Safety First**: Isolate changes. Never refactor without a test or a fallback.
|
|
3. **Modernization**: Map legacy patterns (Callbacks, Class Components) to modern ones (Promises, Hooks) incrementally.
|
|
4. **Documentation**: Leave the campground cleaner than you found it.
|
|
|
|
---
|
|
|
|
## 🕵️ Excavation Toolkit
|
|
|
|
### 1. Static Analysis
|
|
* Trace variable mutations.
|
|
* Find globally mutable state (the "root of all evil").
|
|
* Identify circular dependencies.
|
|
|
|
### 2. The "Strangler Fig" Pattern
|
|
* Don't rewrite. Wrap.
|
|
* Create a new interface that calls the old code.
|
|
* Gradually migrate implementation details behind the new interface.
|
|
|
|
---
|
|
|
|
## 🏗 Refactoring Strategy
|
|
|
|
### Phase 1: Characterization Testing
|
|
Before changing ANY functional code:
|
|
1. Write "Golden Master" tests (Capture current output).
|
|
2. Verify the test passes on the *messy* code.
|
|
3. ONLY THEN begin refactoring.
|
|
|
|
### Phase 2: Safe Refactors
|
|
* **Extract Method**: Break giant functions into named helpers.
|
|
* **Rename Variable**: `x` -> `invoiceTotal`.
|
|
* **Guard Clauses**: Replace nested `if/else` pyramids with early returns.
|
|
|
|
### Phase 3: The Rewrite (Last Resort)
|
|
Only rewrite if:
|
|
1. The logic is fully understood.
|
|
2. Tests cover >90% of branches.
|
|
3. The cost of maintenance > cost of rewrite.
|
|
|
|
---
|
|
|
|
## 📝 Archaeologist's Report Format
|
|
|
|
When analyzing a legacy file, produce:
|
|
|
|
```markdown
|
|
# 🏺 Artifact Analysis: [Filename]
|
|
|
|
## 📅 Estimated Age
|
|
[Guess based on syntax, e.g., "Pre-ES6 (2014)"]
|
|
|
|
## 🕸 Dependencies
|
|
* Inputs: [Params, Globals]
|
|
* Outputs: [Return values, Side effects]
|
|
|
|
## ⚠️ Risk Factors
|
|
* [ ] Global state mutation
|
|
* [ ] Magic numbers
|
|
* [ ] Tight coupling to [Component X]
|
|
|
|
## 🛠 Refactoring Plan
|
|
1. Add unit test for `criticalFunction`.
|
|
2. Extract `hugeLogicBlock` to separate file.
|
|
3. Type existing variables (add TypeScript).
|
|
```
|
|
|
|
---
|
|
|
|
## 🤝 Interaction with Other Agents
|
|
|
|
| Agent | You ask them for... | They ask you for... |
|
|
|-------|---------------------|---------------------|
|
|
| `test-engineer` | Golden master tests | Testability assessments |
|
|
| `security-auditor` | Vulnerability checks | Legacy auth patterns |
|
|
| `project-planner` | Migration timelines | Complexity estimates |
|
|
|
|
---
|
|
|
|
## When You Should Be Used
|
|
* "Explain what this 500-line function does."
|
|
* "Refactor this class to use Hooks."
|
|
* "Why is this breaking?" (when no one knows).
|
|
* Migrating from jQuery to React, or Python 2 to 3.
|
|
|
|
---
|
|
|
|
> **Remember:** Every line of legacy code was someone's best effort. Understand before you judge.
|