specklepy

huanld/specklepy

Fork 0

Author	SHA1	Message	Date
izzy lyseggen	782f70fb49	chore: drop python 3.6 and update ujson (#190 ) * chore: depreciate python 3.6 support & upate ujson after collection python version info metrics, we fount that only 2 users are still using python 3.6. since it has been eol for 5 months now, we believe it's safe to let it go. rest easy 3.6 ⚰✨- you served us well 🫡 closes Please upgrade the ujson dependency, which has a CVE #160 * chore: upgrade and clean some deps	2022-06-20 12:19:09 +01:00
Gergő Jedlicska	52ab27e60f	SQLite write batching (#188 ) ### SUMMARY sqlite transport This transport now batches and bulk inserts objects when writing resulting in huge performance improvements (100x). base object serializer Batching in the sqlite transport necessitated some refactoring here in order to safely call end_write when not using operations.send/receive. This has been resolved by turning traverse_base into a wrapper for _traverse_base which can take care of calling begin/end_write and resetting the writer at the top level. This is not breaking since the top level methods to call have not changed names and the original method has just been prepended with a _ Additionally, missing referenced child objects in the read transport used to raise a SpeckleException. However, using the gql client to call objects.get() will return an object with missing references by design thus throwing an error in serialization. This has been resolved by instead raising a SpeckleWarning when child objects can't be found and just returning the reference + id. ((this method of interacting with objects is discouraged so it is not surprising to me that this bug was lurking for so long - but an oopsie nonetheless!)) ci / dev Updates for the ci config and the dev container to work with the recent changes in server. NOTE: dev container seems to be pulling an older version of server -- not resolved yet --- * quick and hacky sqlite batching * feat(transports): batching sqlite inserts * chore: upgrade gql3 also removed py-spy as it's not used and i was getting install errors :/ * ci: bump node version * ci: formatting * update CI versions * update to new circleci redis baseimage * update test fixture auth to non deprecated token based method * add start and finish write method calls to base object serialize * chore: dev container update * fix(serialization): move end and begin write * style: formatting * fix(serializer): warn but don't throw if ref not found this is _not_ an issue with the transports, but an issue with using the graphql api to fetch objects. since you are only receiving one obj and none of the children, the transport has no way to find them and should simply return the reference as is. idk why anyone would really use `object.get` so tbh i'm not surprised no one has found this bug yet lol * fix(client): don't parse obj create response * fix(serializer): wrap `traverse_base` moving `begin` and `end_write` to the seriazlier due to the new sqlite transport with batched writes necessitates a wrapper around `traverse_base` so end/begin write can be called once at the top level. just adding begin/end write to the original traversal method would make tons of calls to `end_write` since the traversal is recursive Co-authored-by: izzy lyseggen <izzy.lyseggen@gmail.com>	2022-06-20 12:00:09 +01:00

Author

SHA1

Message

Date

izzy lyseggen

782f70fb49

chore: drop python 3.6 and update ujson (#190 )

* chore: depreciate python 3.6 support & upate ujson

after collection python version info metrics, we fount that only 2 users
are still using python 3.6. since it has been eol for 5 months now,
we believe it's safe to let it go.

rest easy 3.6 ⚰✨- you served us well 🫡

closes Please upgrade the ujson dependency, which has a CVE #160

* chore: upgrade and clean some deps

2022-06-20 12:19:09 +01:00

Gergő Jedlicska

52ab27e60f

SQLite write batching (#188 )

### SUMMARY
**sqlite transport**

This transport now batches and bulk inserts objects when writing resulting in huge performance improvements (100x).

**base object serializer**

Batching in the sqlite transport necessitated some refactoring here in order to safely call end_write when not using operations.send/receive. This has been resolved by turning traverse_base into a wrapper for _traverse_base which can take care of calling begin/end_write and resetting the writer at the top level. This is not breaking since the top level methods to call have not changed names and the original method has just been prepended with a _

Additionally, missing referenced child objects in the read transport used to raise a SpeckleException. However, using the gql client to call objects.get() will return an object with missing references by design thus throwing an error in serialization. This has been resolved by instead raising a SpeckleWarning when child objects can't be found and just returning the reference + id. ((this method of interacting with objects is discouraged so it is not surprising to me that this bug was lurking for so long - but an oopsie nonetheless!))

**ci / dev**

Updates for the ci config and the dev container to work with the recent changes in server.

NOTE: dev container seems to be pulling an older version of server -- not resolved yet

---

* quick and hacky sqlite batching

* feat(transports): batching sqlite inserts

* chore: upgrade gql3

also removed py-spy as it's not used and i was getting install errors :/

* ci: bump node version

* ci: formatting

* update CI versions

* update to new circleci redis baseimage

* update test fixture auth to non deprecated token based method

* add start and finish write method calls to base object serialize

* chore: dev container update

* fix(serialization): move end and begin write

* style: formatting

* fix(serializer): warn but don't throw if ref not found

this is _not_ an issue with the transports, but an issue with using the
graphql api to fetch objects. since you are only receiving one obj and none of
the children, the transport has no way to find them and should simply
return the reference as is. idk why anyone would really use `object.get`
so tbh i'm not surprised no one has found this bug yet lol

* fix(client): don't parse obj create response

* fix(serializer): wrap `traverse_base`

moving `begin` and `end_write` to the seriazlier due to the new
sqlite transport with batched writes necessitates a wrapper around
`traverse_base` so end/begin write can be called once at the top level.
just adding begin/end write to the original traversal method would make
tons of calls to `end_write` since the traversal is recursive

Co-authored-by: izzy lyseggen <izzy.lyseggen@gmail.com>

2022-06-20 12:00:09 +01:00

3 changed files with 413 additions and 453 deletions

									
										.circleci/config.yml
									
		+1
		-1
	
												View File
												
				@@ -65,7 +65,7 @@ workflows:

				      - test:

				          matrix:

				            parameters:

				              tag: ["3.6", "3.7", "3.8", "3.9"]

				              tag: ["3.7", "3.8", "3.9", "3.10"]

				          filters:

				            tags:

				              only: /.*/

poetry.lock

Generated

+410 -450

View File

File diff suppressed because it is too large Load Diff

									
										pyproject.toml
									
		+2
		-2
	
												View File
												
				@@ -11,11 +11,11 @@ homepage = "https://speckle.systems/"

				[tool.poetry.dependencies]

				python = "^3.6.5"

				python = ">=3.7.0, <4.0"

				pydantic = "^1.8.2"

				appdirs = "^1.4.4"

				gql = {extras = ["requests", "websockets"], version = "^3.3.0"}

				ujson = "^4.3.0"

				ujson = "^5.3.0"

				Deprecated = "^1.2.13"

				[tool.poetry.dev-dependencies]

Compare commits

2 Commits

gergo/sqliteSpeedup .. 2.7.0

Compare commits

2 Commits gergo/sqliteSpeedup .. 2.7.0

2 Commits

gergo/sqliteSpeedup .. 2.7.0