Update README.md (#15)

README.md

@@ -1 +1,5 @@
 # ifc-openshell-file-importer
+
+⚠ We have moved this code into the specklepy repo - https://github.com/specklesystems/specklepy/tree/main/src/speckleifc ⚠
+
+Please open new issues and PRs there

src/speckleifc/__main__.py

@@ -5,7 +5,7 @@ from argparse import ArgumentParser
 from os import getenv
 
 from specklepy.core.api.client import SpeckleClient
-from specklepy.core.api.credentials import Account, get_accounts_for_server
+from specklepy.core.api.credentials import Account
 from specklepy.core.api.inputs.version_inputs import CreateVersionInput
 from specklepy.core.api.models.current import Version
 from specklepy.core.api.operations import send

src/speckleifc/ifc_geometry_processing.py

@@ -15,6 +15,8 @@ def _create_iterator_settings() -> settings:
     ifc_settings.set("use-world-coords", True)
     # Tiny performance improvement,
     ifc_settings.set("no-wire-intersection-check", True)
+    # Rendermaterials inherit the material names instead of type + unique id
+    ifc_settings.set("use-material-names", True)
 
     # IfcOpenshell defaults to 0.001mm here, which leads to very dense meshes.
     # lowering the mesh quality a bit here leads to meshes

src/speckleifc/property_extraction.py

@@ -42,7 +42,9 @@ def _get_ifc_object_properties(element: entity_instance) -> dict[str, object]:
         if not rel.is_a("IfcRelDefinesByProperties"):
             continue
 
-        definition: entity_instance = rel.RelatingPropertyDefinition
+        definition: entity_instance | None = rel.RelatingPropertyDefinition
+        if not definition:
+            continue
 
         if not definition.is_a("IfcPropertySet"):
             continue