Fix(instances): instance name prop is missing (#405)
Build and deploy / build (push) Has been cancelled
Build and deploy / deploy-installers (push) Has been cancelled

* add name to instances

* set name only if it is not empty
This commit is contained in:
Oğuzhan Koral
2025-03-07 12:04:16 +03:00
committed by GitHub
parent 5365dc858e
commit 85ee66ca4d
2 changed files with 5 additions and 1 deletions
@@ -52,6 +52,7 @@ module SpeckleConnector3
instance_proxies[instance_id] = SpeckleObjects::InstanceProxy.new(
definition_id,
entity.name,
SpeckleObjects::Other::Transform.from_transformation(entity.transformation, @units).value,
depth,
@units,
@@ -8,12 +8,13 @@ module SpeckleConnector3
module SpeckleObjects
class InstanceProxy < Base
SPECKLE_TYPE = SPECKLE_CORE_MODELS_INSTANCES_INSTANCE_PROXY
def initialize(definition_id, transform, max_depth, units, sketchup_attributes: {}, application_id: nil)
def initialize(definition_id, name, transform, max_depth, units, sketchup_attributes: {}, application_id: nil)
super(
speckle_type: SPECKLE_TYPE,
application_id: application_id,
id: nil
)
self[:name] = name if name != ""
self[:units] = units
self[:definitionId] = definition_id
self[:maxDepth] = max_depth
@@ -24,9 +25,11 @@ module SpeckleConnector3
def self.to_native(state, instance_proxy, layer, entities, definition_proxies, &_convert_to_native)
definition_id = instance_proxy['definitionId']
proxy_transform = instance_proxy['transform']
name = instance_proxy['name']
transform = Other::Transform.to_native(proxy_transform, instance_proxy['units'])
definition = definition_proxies[definition_id].definition
instance = entities.add_instance(definition, transform)
instance.name = name if name
unless instance_proxy['properties'].nil?
SketchupModel::Dictionary::BaseDictionaryHandler