Merge pull request #382 from specklesystems/dev

Dev -> Main for release

.config/dotnet-tools.json

@@ -3,11 +3,11 @@
   "isRoot": true,
   "tools": {
     "csharpier": {
-      "version": "1.0.2",
+      "version": "1.1.2",
       "commands": [
         "csharpier"
       ],
       "rollForward": false
     }
   }
-}
+}

.github/workflows/pr.yml

@@ -8,7 +8,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - name: Checkout
-      uses: actions/checkout@v4
+      uses: actions/checkout@v5
 
     - name: Setup .NET
       uses: actions/setup-dotnet@v4

.github/workflows/release.yml

@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
         
       - name: Setup .NET
         uses: actions/setup-dotnet@v4

src/Speckle.Sdk/Api/Blob/BlobApi.cs

@@ -265,7 +265,6 @@ public sealed class BlobApi : IBlobApi
   [AutoInterfaceIgnore]
   public void Dispose()
   {
-    _activityFactory.Dispose();
     _authedClient.Dispose();
     _unauthedClient.Dispose();
   }

src/Speckle.Sdk/Models/Base.cs

@@ -169,8 +169,7 @@ public class Base : DynamicBase, ISpeckleObject
 
         return count;
       }
-      case IEnumerable e
-      and not string:
+      case IEnumerable e and not string:
       {
         foreach (var arrValue in e)
         {

src/Speckle.Sdk/Models/GraphTraversal/GraphTraversal.cs

@@ -109,9 +109,9 @@ public abstract class GraphTraversal<T>
         break;
       case IList list:
       {
-        foreach (object? obj in list)
+        for (int i = list.Count - 1; i >= 0; i--)
         {
-          TraverseMemberToStack(stack, obj, memberName, parent);
+          TraverseMemberToStack(stack, list[i], memberName, parent);
         }
 
         break;

src/Speckle.Sdk/Serialisation/V2/Send/ObjectSaver.cs

@@ -100,9 +100,9 @@ public sealed class ObjectSaver(
     {
       if (!_options.SkipCacheWrite && batch.Count != 0)
       {
-        sqLiteJsonCacheManager.SaveObjects(batch.Select(x => (x.Id.Value, x.Json.Value)));
         Interlocked.Add(ref _cached, batch.Count);
         progress?.Report(new(ProgressEvent.CachedToLocal, _cached, _objectsSerialized));
+        sqLiteJsonCacheManager.SaveObjects(batch.Select(x => (x.Id.Value, x.Json.Value)));
       }
     }
     catch (OperationCanceledException)

src/Speckle.Sdk/Transports/ServerUtils/ProgressStream.cs

@@ -20,7 +20,7 @@ internal sealed class ProgressStream(
   {
     int n = _stream.Read(buffer, offset, count);
     _position += n;
-    progress?.Report(new(ProgressEvent.DownloadBytes, _position, streamLength));
+    progress?.Report(new(ProgressEvent.DownloadBytes, n, streamLength));
     return n;
   }
 
@@ -28,7 +28,7 @@ internal sealed class ProgressStream(
   {
     _stream.Write(buffer, offset, count);
     _position += count;
-    progress?.Report(new(ProgressEvent.UploadBytes, _position, streamLength));
+    progress?.Report(new(ProgressEvent.UploadBytes, count, streamLength));
   }
 
   public override bool CanRead => true;

tests/Speckle.Sdk.Tests.Unit/Serialisation/PrimitiveTestFixture.cs

@@ -39,7 +39,7 @@ public abstract class PrimitiveTestFixture
     }.Select(x => new object[] { x });
 
   public static Half[] Float16TestCases { get; } =
-    [default, Half.Epsilon, Half.MaxValue, Half.MinValue, Half.PositiveInfinity, Half.NegativeInfinity, Half.NaN];
+  [default, Half.Epsilon, Half.MaxValue, Half.MinValue, Half.PositiveInfinity, Half.NegativeInfinity, Half.NaN];
 
   public static float[] FloatIntegralTestCases { get; } = [0, 1, int.MaxValue, int.MinValue];