Record activity exceptions (#467)

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 5 to 6.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/codecov/codecov-action/compare/v5...v6)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

.github/workflows/integration-test.yml

@@ -54,7 +54,7 @@ jobs:
         run: dotnet test ${{ env.Solution }} --filter "(Category=Integration)&(Server!=Public)" --configuration Release --no-build --no-restore --verbosity=normal /p:AltCover=true /p:AltCoverAttributeFilter=ExcludeFromCodeCoverage
 
       - name: Upload coverage reports to Codecov with GitHub Action
-        uses: codecov/codecov-action@v5
+        uses: codecov/codecov-action@v6
         continue-on-error: true
         with:
           fail_ci_if_error: true

.github/workflows/pr.yml

@@ -42,7 +42,7 @@ jobs:
         run: dotnet pack ${{ env.Solution }} --configuration Release --no-build 
 
       - name: Upload coverage reports to Codecov with GitHub Action
-        uses: codecov/codecov-action@v5
+        uses: codecov/codecov-action@v6
         continue-on-error: true
         with:
           fail_ci_if_error: true

src/Speckle.Sdk/Api/GraphQL/Client.cs

@@ -154,10 +154,10 @@ public sealed class Client : ISpeckleGraphQLClient, IClient
       activity?.SetStatus(SdkActivityStatusCode.Ok);
       return ret;
     }
-    catch (Exception)
+    catch (Exception ex)
     {
       activity?.SetStatus(SdkActivityStatusCode.Error);
-      // Don't record exception as it's rethrown.
+      activity?.RecordException(ex);
       throw;
     }
   }

src/Speckle.Sdk/Pipelines/Send/DiskStore.cs

@@ -65,7 +65,12 @@ public sealed class DiskStore
 
       await foreach (var item in _channel.ReadAllAsync(_cancellationToken).ConfigureAwait(false))
       {
-        await writer.WriteLineAsync($"{item.Id}\t{item.SpeckleType}\t{item.Json}").ConfigureAwait(false);
+        await writer.WriteAsync(item.Id).ConfigureAwait(false);
+        await writer.WriteAsync('\t').ConfigureAwait(false);
+        await writer.WriteAsync(item.SpeckleType).ConfigureAwait(false);
+        await writer.WriteAsync('\t').ConfigureAwait(false);
+        await writer.WriteAsync(item.Json.Value).ConfigureAwait(false);
+        await writer.WriteLineAsync().ConfigureAwait(false);
       }
 #if NET8_0_OR_GREATER
       await writer.FlushAsync(_cancellationToken).ConfigureAwait(false);

src/Speckle.Sdk/Pipelines/Send/Uploader.cs

@@ -65,63 +65,90 @@ public sealed class Uploader : IDisposable
   {
     using var a = _activity.Start("Get Presigned Url");
 
-    var signUri = new Uri($"projects/{_projectId}/modelingestion/{_ingestionId}/uploads/sign", UriKind.Relative);
+    try
+    {
+      var signUri = new Uri($"projects/{_projectId}/modelingestion/{_ingestionId}/uploads/sign", UriKind.Relative);
 
-    using var signResponse = await _speckleClient.PostAsync(signUri, null, _cancellationToken).ConfigureAwait(false);
-    signResponse.EnsureSuccessStatusCode();
+      using var signResponse = await _speckleClient.PostAsync(signUri, null, _cancellationToken).ConfigureAwait(false);
+      signResponse.EnsureSuccessStatusCode();
 
 #if NET5_0_OR_GREATER
-    string signResponseString = await signResponse.Content.ReadAsStringAsync(_cancellationToken).ConfigureAwait(false);
+      string signResponseString = await signResponse
+        .Content.ReadAsStringAsync(_cancellationToken)
+        .ConfigureAwait(false);
 #else
-    string signResponseString = await signResponse.Content.ReadAsStringAsync().ConfigureAwait(false);
+      string signResponseString = await signResponse.Content.ReadAsStringAsync().ConfigureAwait(false);
 #endif
-    PresignedUploadResponse presignedUpload =
-      JsonConvert.DeserializeObject<PresignedUploadResponse>(signResponseString)
-      ?? throw new InvalidOperationException("Failed to get presigned upload URL");
-    return presignedUpload;
+      PresignedUploadResponse presignedUpload =
+        JsonConvert.DeserializeObject<PresignedUploadResponse>(signResponseString)
+        ?? throw new InvalidOperationException("Failed to get presigned upload URL");
+      return presignedUpload;
+    }
+    catch (Exception ex)
+    {
+      a?.SetStatus(SdkActivityStatusCode.Error);
+      a?.RecordException(ex);
+      throw;
+    }
   }
 
   private async Task<string> UploadToS3(Stream fileStream, PresignedUploadResponse presignedUploadResponse)
   {
     using var a = _activity.Start("Uploading file to pre-signed url");
-
-    Stream progressStream = new ProgressStream(fileStream, _progress);
-
-    using var streamContent = new StreamContent(progressStream);
-    streamContent.Headers.ContentType = new MediaTypeHeaderValue("application/octet-stream");
-    streamContent.Headers.ContentLength = fileStream.Length;
-
-    using var uploadRequest = new HttpRequestMessage(HttpMethod.Put, presignedUploadResponse.Url);
-    foreach (var kvp in presignedUploadResponse.AdditionalRequestHeaders)
+    try
     {
-      uploadRequest.Headers.Add(kvp.Key, kvp.Value);
+      Stream progressStream = new ProgressStream(fileStream, _progress);
+
+      using var streamContent = new StreamContent(progressStream);
+      streamContent.Headers.ContentType = new MediaTypeHeaderValue("application/octet-stream");
+      streamContent.Headers.ContentLength = fileStream.Length;
+
+      using var uploadRequest = new HttpRequestMessage(HttpMethod.Put, presignedUploadResponse.Url);
+      foreach (var kvp in presignedUploadResponse.AdditionalRequestHeaders)
+      {
+        uploadRequest.Headers.Add(kvp.Key, kvp.Value);
+      }
+
+      uploadRequest.Content = streamContent;
+
+      using var uploadResponse = await _s3Client
+        .SendAsync(uploadRequest, HttpCompletionOption.ResponseHeadersRead, _cancellationToken)
+        .ConfigureAwait(false);
+
+      uploadResponse.EnsureSuccessStatusCode();
+
+      return BlobApiHelpers.ParseEtagHeader(uploadResponse.Headers);
+    }
+    catch (Exception ex)
+    {
+      a?.SetStatus(SdkActivityStatusCode.Error);
+      a?.RecordException(ex);
+      throw;
     }
-
-    uploadRequest.Content = streamContent;
-
-    using var uploadResponse = await _s3Client
-      .SendAsync(uploadRequest, HttpCompletionOption.ResponseHeadersRead, _cancellationToken)
-      .ConfigureAwait(false);
-
-    uploadResponse.EnsureSuccessStatusCode();
-
-    return BlobApiHelpers.ParseEtagHeader(uploadResponse.Headers);
   }
 
   private async Task TriggerProcessing(TriggerUploadRequest request)
   {
     using var a = _activity.Start("Triggering Processing");
+    try
+    {
+      Uri processUri = new($"projects/{_projectId}/modelingestion/{_ingestionId}/uploads/process", UriKind.Relative);
+      string requestBody = JsonConvert.SerializeObject(request);
+      using var content = new StringContent(requestBody, Encoding.UTF8, "application/json");
 
-    Uri processUri = new($"projects/{_projectId}/modelingestion/{_ingestionId}/uploads/process", UriKind.Relative);
-    string requestBody = JsonConvert.SerializeObject(request);
-    using var content = new StringContent(requestBody, Encoding.UTF8, "application/json");
+      using HttpResponseMessage processResponse = await _speckleClient
+        .PostAsync(processUri, content, _cancellationToken)
+        .ConfigureAwait(false);
 
-    using HttpResponseMessage processResponse = await _speckleClient
-      .PostAsync(processUri, content, _cancellationToken)
-      .ConfigureAwait(false);
-
-    string body = await processResponse.Content.ReadAsStringAsync().ConfigureAwait(false);
-    processResponse.EnsureSuccessStatusCode();
+      string body = await processResponse.Content.ReadAsStringAsync().ConfigureAwait(false);
+      processResponse.EnsureSuccessStatusCode();
+    }
+    catch (Exception ex)
+    {
+      a?.SetStatus(SdkActivityStatusCode.Error);
+      a?.RecordException(ex);
+      throw;
+    }
   }
 
   public void Dispose()