huanld/speckle-sharp-sdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Adds detail to message so that user isn't going WTF SDK (#351)

Browse Source 
* Adds detail to message so that user isn't going WTF SDK

* update exception tests
This commit is contained in:
Adam Hathcock
2025-07-03 10:39:53 +01:00
committed by GitHub
parent 5a0f883b98
commit a8dc93e22b
6 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Speckle.Sdk/Serialisation/V2/Receive/ObjectLoader.cs
+1 -1
View File
@@ -171,7 +171,7 @@ public sealed class ObjectLoader(
cancellationToken.ThrowIfCancellationRequested();
if (Exception is not null)
{
throw new SpeckleException("Error while loading", Exception);
throw new SpeckleException($"Error while loading: {Exception.Message}", Exception);
}
}
}
src/Speckle.Sdk/Serialisation/V2/Send/SerializeProcess.cs
+1 -1
View File
@@ -97,7 +97,7 @@ public sealed class SerializeProcess(
//order here matters...null with cancellation means a user did it, otherwise it's a real Exception
if (objectSaver.Exception is not null)
{
throw new SpeckleException("Error while sending", objectSaver.Exception);
throw new SpeckleException($"Error while sending: {objectSaver.Exception.Message}", objectSaver.Exception);
}
_processSource.Token.ThrowIfCancellationRequested();
}
tests/Speckle.Sdk.Serialization.Tests/ExceptionTests.Test_Exceptions_Cache.verified.json
+1 -1
View File
@@ -6,6 +6,6 @@
"Message": "The method or operation is not implemented.",
"Type": "NotImplementedException"
},
"Message": "Error while sending",
"Message": "Error while sending: The method or operation is not implemented.",
"Type": "SpeckleException"
}
tests/Speckle.Sdk.Serialization.Tests/ExceptionTests.Test_Exceptions_Cache_ExceptionsAfter_10.verified.json
+1 -1
View File
@@ -6,6 +6,6 @@
"Message": "Count exceeded",
"Type": "Exception"
},
"Message": "Error while sending",
"Message": "Error while sending: Count exceeded",
"Type": "SpeckleException"
}
tests/Speckle.Sdk.Serialization.Tests/ExceptionTests.Test_Exceptions_Receive_Cache_fileName=False.verified.json
+1 -1
View File
@@ -6,6 +6,6 @@
"Message": "The method or operation is not implemented.",
"Type": "NotImplementedException"
},
"Message": "Error while loading",
"Message": "Error while loading: The method or operation is not implemented.",
"Type": "SpeckleException"
}
tests/Speckle.Sdk.Serialization.Tests/ExceptionTests.Test_Exceptions_Upload.verified.json
+1 -1
View File
@@ -6,6 +6,6 @@
"Message": "The method or operation is not implemented.",
"Type": "NotImplementedException"
},
"Message": "Error while sending",
"Message": "Error while sending: The method or operation is not implemented.",
"Type": "SpeckleException"
}