* clean send (except closed circular arcs)
* split functions
* include inner loops for complex regions
* reorient only polycurves with arcs
* regions to host
* merge conflict
* substract regions on receive
* optimize
* add checks
* fix icurve, receive hatches
* hatch receive
* reduce dataObject conversions
* finally hatches are recorded in a database
* regrouped
* simplify
* rename
* send hatch (only the first)
* remove hatches for now
* comment
* fixed icurve converter and reference in DataObject converter
* reformat
* hatch to speckle
* hatch to host
* hatch receive works
* set solid pattern on receive
* send properly and throw if complex hacth
* calculate mesh area from region
* prevent Autocad crash by catching exceptions in the middle of transaction
* sending both polylines and curves for hatches
* boolean operation for sending hatches
* turned 2d Hatch curves into 3d - now Brep creation doesn't fail!
* circles handled
* construct both polyline and vertices in parallel
* handling splines on receive
* comments
* don't reverse proper segments
* basic comment fixes
* open block table for write more concise
* use top-level transaction
---------
Co-authored-by: Claire Kuang <kuang.claire@gmail.com>
* fix(revit): sening via views with correct visibility to linked models
* handle not null
* pass path name to function instead full doc
* refactor: move common code outside
* docs: commenting on known limitations
* refactor: preprocessor directive specific stuff back in place
* refactor: oversight on common code
* fix: method name
* docs: cleanup
---------
Co-authored-by: oguzhankoral <oguzhankoral@gmail.com>
* Bjorn/cnx 1359 have a setting in UI whether include or not (#646)
* feat(revit): linked model settings
* docs: cache invalidation note
* Feat(revit): linked models POC (#656)
* cleanup on RefreshElementsIdsOnSender
* POC for multiple and copied linked models
* fix render materials for copied linked models
* comment
* comment
* split linked models with collections
* style: ci potential null on key
* style: not null
---------
Co-authored-by: Björn <steinhagen.bjoern@gmail.com>
* feat(revit): sending linked model poc round two (#657)
* Added IFC app name (#648)
* test: add tests for threadcontext (#651)
* add tests for threadcontext
* add test for extensions
* remove needed usage
* fix for looking for model store (#654)
Co-authored-by: Oğuzhan Koral <45078678+oguzhankoral@users.noreply.github.com>
* test: Send Operation tests (#652)
* add tests for threadcontext
* add test for extensions
* remove needed usage
* move cancellation
* Only add send operation tests
---------
Co-authored-by: Oğuzhan Koral <45078678+oguzhankoral@users.noreply.github.com>
* chore (autocad/civil): add regen after receive (#650)
* regenerates doc
* moves regen to receive base binding
* Update AutocadReceiveBaseBinding.cs
* feat: linked model send responsive to ui
- current throw just a placeholder
- small variable name refactor
* fix: object reference not set to an instance of an object
* fix: display value extractor
* refactor: converterSettings as readonly field
* feat: warning in response to ui setting not enabled
* docs: todos etc.
* Revert "Merge branch 'dev' into bjorn/cnx-1360-get-linked-models-on-send-function-according-to-setting"
This reverts commit 7202058a98, reversing
changes made to 4bc9ec2352.
---------
Co-authored-by: Jedd Morgan <45512892+JR-Morgan@users.noreply.github.com>
Co-authored-by: Adam Hathcock <adamhathcock@users.noreply.github.com>
Co-authored-by: Oğuzhan Koral <45078678+oguzhankoral@users.noreply.github.com>
Co-authored-by: Claire Kuang <kuang.claire@gmail.com>
* fix: transform needed to be inversed (#659)
* feat(revit): linked models send by category (#666)
* docs: notes on collection filtering
* feature: RevitCategoriesFilter with linked models too
poc
* docs: notes
* feat(revit): commit structure (#675)
* feat: collection structure switch
- poc
- if linked models, send nested
- if not linked, send flat
* docs: comments on updates
* docs: comment on exception swallowing
* fix: nullability
* refactor: linked model helper class and refactor (#682)
* fix: premature processing of linked models
- add early check for linked models setting
- skips expensive element collection for linked models when disabled
- add empty document contexts for linked models when disabled to maintain warning generation (HACK)
- improve code readability with clearer variable names and comments
* refactor: category ids outside of linked model processing
- inefficient to repeat for every document
* fix: improve separation of concerns for linked model handling
- extract linked model processing to a dedicated method
- add IsLinkedDocument flag to DocumentToConvert class
- move linked model warning generation to RevitRootObjectBuilder
- make RevitSendBinding responsible only for element collection
* refactor: dedicated LinkedModelHandler class for linked model processing
- extract linked model element collection logic to a separate class
- improve separation of concerns between flow control and element collection
- add clear documentation explaining the responsibility boundaries
* fix: duplicate if check still floating around
* docs: over-explaining myself
* Fix(revit): do not use converter settings in element unpacker (#687)
* fix resetting the selected object ids after collecting the elements
* Pass document to element unpacker for the sake of linked models
* fix: send by categories mode
---------
Co-authored-by: Björn <steinhagen.bjoern@gmail.com>
* fix(revit): handle multiple linked model instances with transform hashing (#688)
* feat: linked model transform caching in RevitRootObjectBuilder
Add transform-specific hashing to properly handle multiple instances of the same linked model. Uses transform properties to create a unique suffix for the applicationId, preventing cached objects from being incorrectly reused across different transform contexts.
* more comments
---------
Co-authored-by: oguzhankoral <oguzhankoral@gmail.com>
* fix: handle null elements when unpacking linked model groups
- add null element check before GroupBy in ElementUnpacker to prevent NullReferenceException
- improve robustness when processing groups in linked models
- add documentation explaining linked model element handling throughout UnpackElements method
- edge case where group member elements might not resolve properly in linked contexts
* make linked model setting true by default
* Fix(revit): illegal attempt to modify document (#700)
* Run refresh object ids in revit task
* Proper not null
* await instead .result
* feat(revit): collection structure for multiple linked model instances (#701)
* feat: suffix for instances of linked model
* Extract out GetIdFromDocumentToConvert
---------
Co-authored-by: oguzhankoral <oguzhankoral@gmail.com>
* Correct receive default setting for linked models even if irrevelant
* Fix post conflict
* Cleanup the code
* Add comment
---------
Co-authored-by: Björn Steinhagen <steinhagen.bjoern@gmail.com>
Co-authored-by: oguzhankoral <oguzhankoral@gmail.com>
Co-authored-by: Oğuzhan Koral <45078678+oguzhankoral@users.noreply.github.com>
Co-authored-by: Jedd Morgan <45512892+JR-Morgan@users.noreply.github.com>
Co-authored-by: Adam Hathcock <adamhathcock@users.noreply.github.com>
Co-authored-by: Claire Kuang <kuang.claire@gmail.com>
* Update CorridorDisplayValueExtractor.cs
For unknown reasons, sometimes trying to get the PropertySetDefinitionName throws an exception.
Updated to catch this, ignore that propery set, and move to the next one. It is never the "Corridor Identity" property set that has this issue, so there should be no missing data.
* .
---------
Co-authored-by: Claire Kuang <kuang.claire@gmail.com>
* Add affected usage with tag math
* use this branch as a test branch
* adjust test
* fix github action
* build refactor to get affected work
* Lazy affected
* put if statement on job
* add conditions around build and publish for linux
* affected tests and small refactor
* fmt
* verbose
* full checkout
* more testing and made things more clear
* adjust installer test branch
* add comments
* use zip on release
* detect main release
* use right trigger for release
* fix build
* maybe fix if statement...version env var don't work
* use current branch, not target branch
* test installer should be stored
* write to github action env vars
* use the env var correctly
* format
* set the output version as before
---------
Co-authored-by: Jedd Morgan <45512892+JR-Morgan@users.noreply.github.com>
* Refactors idle manager to shortcut call check
* fix tests
* Match the id of idle action with the function name
it is more safe with this way bc we might accidentially skip some deferred actions if we use class name
---------
Co-authored-by: oguzhankoral <oguzhankoral@gmail.com>
KatKatKateryna