docs: notes from chatty-chat

Converters/Revit/Speckle.Converters.RevitShared/Helpers/DisplayValueExtractor.cs

@@ -160,8 +160,8 @@ public sealed class DisplayValueExtractor
   {
     List<(Base, Matrix4x4?)> displayValue = new();
 
-    using DB.Transform? localToWorld = GetTransform(element);
-    using DB.Transform? worldToLocal = localToWorld?.Inverse;
+    using DB.Transform? localToWorld = GetTransform(element); // on an element level
+    using DB.Transform? worldToLocal = localToWorld?.Inverse; // this needs to be scaled?
 
     // handle all solids and meshes by their material
     var meshesByMaterial = GetMeshesByMaterial(collections.Meshes, collections.Solids, worldToLocal);

Converters/Revit/Speckle.Converters.RevitShared/ToSpeckle/TopLevel/RevitElementTopLevelConverterToSpeckle.cs

@@ -113,6 +113,7 @@ public class ElementTopLevelConverterToSpeckle : IToSpeckleTopLevelConverter
         var unbakedMesh = displayValueWithTransform.Item1 as SOG.Mesh;
         if (unbakedMesh is not null)
         {
+          // TODO Hackady hack hack
           var instanceDefinitionId = Math.Abs(unbakedMesh.vertices[0]).ToString();
           if (
             _revitToSpeckleCacheSingleton.InstanceDefinitionProxiesMap.TryGetValue(
@@ -144,7 +145,7 @@ public class ElementTopLevelConverterToSpeckle : IToSpeckleTopLevelConverter
           {
             applicationId = Guid.NewGuid().ToString(),
             definitionId = instanceDefinitionId,
-            transform = displayValueWithTransform.Item2.Value,
+            transform = displayValueWithTransform.Item2.Value, // TODO combine with linked model doc transform if doc.IsLinked
             maxDepth = 1,
             units = unbakedMesh.units
           };