Fixed an issue where the converter would fail if display valyues were not directly displayable objects (#3075)

packages/viewer-sandbox/src/main.ts

@@ -105,7 +105,7 @@ const getStream = () => {
     // prettier-ignore
     // 'https://speckle.xyz/streams/da9e320dad/commits/5388ef24b8?c=%5B-7.66134,10.82932,6.41935,-0.07739,-13.88552,1.8697,0,1%5D'
     // Revit sample house (good for bim-like stuff with many display meshes)
-    // 'https://speckle.xyz/streams/da9e320dad/commits/5388ef24b8'
+    'https://speckle.xyz/streams/da9e320dad/commits/5388ef24b8'
     // 'https://latest.speckle.dev/streams/c1faab5c62/commits/ab1a1ab2b6'
     // 'https://speckle.xyz/streams/da9e320dad/commits/5388ef24b8'
     // 'https://latest.speckle.dev/streams/58b5648c4d/commits/60371ecb2d'
@@ -419,7 +419,10 @@ const getStream = () => {
     // Text with no material
     // 'https://latest.speckle.systems/projects/731c6e2fd1/models/bcd3a4a706'
 
-    'https://app.speckle.systems/projects/00a5c443d6/models/de56edf901'
+    // BREPs as display values
+    // 'https://latest.speckle.systems/projects/126cd4b7bb/models/b613d77690@046b56bf12'
+
+    // 'https://app.speckle.systems/projects/00a5c443d6/models/de56edf901'
   )
 }
 

packages/viewer/src/modules/loaders/Speckle/SpeckleConverter.ts

@@ -176,8 +176,8 @@ export default class SpeckleConverter {
             atomic: false,
             children: []
           })
-          await this.convertToNode(displayValue, nestedNode)
           this.tree.addNode(nestedNode, childNode)
+          await this.convertToNode(displayValue, nestedNode)
           await callback()
         } catch (e) {
           Logger.warn(
@@ -196,8 +196,8 @@ export default class SpeckleConverter {
             atomic: false,
             children: []
           })
-          await this.convertToNode(val, nestedNode)
           this.tree.addNode(nestedNode, childNode)
+          await this.convertToNode(val, nestedNode)
           await callback()
         }
       }