fix(preview service): there is no need to double promise a preview (#782)

2022-05-30 11:59:28 +02:00
parent 00c8ff8703
commit 1f5f5ef943
1 changed files with 9 additions and 21 deletions
@@ -68,29 +68,17 @@ async function getScreenshot(objectUrl) {
  const browser = await puppeteer.launch(launchParams)
  const page = await browser.newPage()

-  const wrapperPromise = new Promise(async (resolve, reject) => {
-    try {
-      await page.goto('http://127.0.0.1:3001/render/')
+  const wrapperPromise = (async () => {
+    await page.goto('http://127.0.0.1:3001/render/')

-      console.log('Page loaded')
+    console.log('Page loaded')

-      // Handle page crash (oom?)
-      page.on('error', (err) => {
-        reject(err)
-      })
-
-      page
-        .evaluate(pageFunction, objectUrl)
-        .then((ret) => {
-          resolve(ret)
-        })
-        .catch((err) => {
-          reject(err)
-        })
-    } catch (err) {
-      return reject(err)
-    }
-  })
+    // Handle page crash (oom?)
+    page.on('error', (err) => {
+      throw err
+    })
+    return await page.evaluate(pageFunction, objectUrl)
+  })()

  let ret = null
  try {