fix: CNX-7606 Fixes missing Data column error (#61)

* fix: Result will now include parent commit object and no longer assume it will have children

* fix: Keep metadata in joined table

.circleci/config.yml

@@ -47,7 +47,7 @@ jobs:
       - run:
           name: "Publish Release on GitHub"
           command: |
-            ghr -t ${GH_TOKEN} -u ${CIRCLE_PROJECT_USERNAME} -r ${CIRCLE_PROJECT_REPONAME} -c ${CIRCLE_SHA1} ${CIRCLE_TAG} ./bin/
+            ghr -t ${GH_TOKEN} -u ${CIRCLE_PROJECT_USERNAME} -r ${CIRCLE_PROJECT_REPONAME} -c ${CIRCLE_SHA1} ${CIRCLE_TAG} ./bin/Speckle.mez
 workflows:
   build:
     jobs:

speckle/GetByUrl.pqm

@@ -1,5 +1,6 @@
 let
     Fetch = Extension.LoadFunction("Api.Fetch.pqm"),
+    GetObject = Extension.LoadFunction("Api.GetObject.pqm"),
     GetAllObjectChildren = Extension.LoadFunction("Api.GetAllObjectChildren.pqm"),
     GetObjectFromCommit = Extension.LoadFunction("GetObjectFromCommit.pqm"),
     GetObjectFromBranch = Extension.LoadFunction("GetObjectFromBranch.pqm"),
@@ -34,8 +35,7 @@ in
                     GetObjectFromBranch(server, id, stream[branch])
                 else
                     GetObjectFromBranch(server, id, "main"),
-            removeEmpty = Table.RemoveLastN(commitObjectsTable, 1),
-            addStreamUrl = Table.AddColumn(removeEmpty, "Stream URL", each server & "/streams/" & id),
+            addStreamUrl = Table.AddColumn(commitObjectsTable, "Stream URL", each server & "/streams/" & id),
             addParentObjectId = Table.AddColumn(
                 addStreamUrl, "Commit Object ID", each Value.Metadata(commitObjectsTable)[objectId]
             ),

speckle/api/Api.GetAllObjectChildren.pqm

@@ -1,6 +1,7 @@
 let
     Table.GenerateByPage = Extension.LoadFunction("Table.GenerateByPage.pqm"),
     Speckle.Api.GetObjectChildren = Extension.LoadFunction("Api.GetObjectChildren.pqm"),
+    Speckle.Api.GetObject = Extension.LoadFunction("Api.GetObject.pqm"),
     Extension.LoadFunction = (fileName as text) =>
         let
             binary = Extension.Contents(fileName), asText = Text.FromBinary(binary)
@@ -19,17 +20,27 @@ in
     // After every page, we check the "nextCursor" record on the metadata of the previous request.
     // Table.GenerateByPage will keep asking for more pages until we return null.
     (server as text, streamId as text, objectId as text, optional cursor as text) as table =>
-        Table.GenerateByPage(
-            (previous) =>
-                let
-                    // if previous is null, then this is our first page of data
-                    nextCursor = if (previous = null) then cursor else Value.Metadata(previous)[Cursor]?,
-                    // if the cursor is null but the prevous page is not, we've reached the end
-                    page =
-                        if (previous <> null and nextCursor = null) then
-                            null
-                        else
-                            Speckle.Api.GetObjectChildren(server, streamId, objectId, 1000, nextCursor)
-                in
-                    page
-        ) meta [server = server, streamId = streamId, objectId = objectId]
+        let
+            parentObject = Speckle.Api.GetObject(server, streamId, objectId),
+            childrenTable = Table.GenerateByPage(
+                (previous) =>
+                    let
+                        // if previous is null, then this is our first page of data
+                        nextCursor = if (previous = null) then cursor else Value.Metadata(previous)[Cursor]?,
+                        // if the cursor is null but the prevous page is not, we've reached the end
+                        page =
+                            if (previous <> null and nextCursor = null) then
+                                null
+                            else
+                                Speckle.Api.GetObjectChildren(server, streamId, objectId, 1000, nextCursor)
+                    in
+                        page
+            ),
+            parentTable = Table.FromRecords({[data = parentObject]}),
+            resultTable =
+                if (Table.ColumnCount(childrenTable) = 0) then
+                    parentTable
+                else
+                    Table.Combine({parentTable, childrenTable})
+        in
+            resultTable meta [server = server, streamId = streamId, objectId = objectId]

speckle/helpers/CleanUpObjects.pqm

@@ -14,4 +14,4 @@
         ),
         removed = List.Select(removeTotals, each _[data][speckle_type] <> "Speckle.Core.Models.DataChunk")
     in
-        removed
+        try removed otherwise objects

speckle/helpers/ParseStreamUrl.pqm

@@ -12,40 +12,61 @@ let
                             Message.Format = "Loading '#{0}' failed - '#{1}': '#{2}'",
                             Message.Parameters = {fileName, e[Reason], e[Message]},
                             Detail = [File = fileName, Error = e]
-                        ]
+                        ],
+    IsFe2Url = (segments as list) as logical => List.Count(segments) = 4 and segments{2} = "models",
+    GetUrlType = (branchName as nullable text, commitId as nullable text, objectId as nullable text) as text =>
+        if (commitId <> null) then
+            "Commit"
+        else if (objectId <> null) then
+            "Object"
+        else if (branchName <> null) then
+            "Branch"
+        else
+            "Stream",
+    ParseFe1Url = (server as text, segments as list) as record =>
+        let
+            streamId = segments{1},
+            branchName = if (List.Count(segments) = 4 and segments{2} = "branches") then segments{3} else null,
+            commitId = if (List.Count(segments) = 4 and segments{2} = "commits") then segments{3} else null,
+            objectId = if (List.Count(segments) = 4 and segments{2} = "objects") then segments{3} else null,
+            urlType = GetUrlType(branchName, commitId, objectId)
+        in
+            [
+                urlType = urlType,
+                server = server as text,
+                id = streamId as nullable text,
+                branch = branchName as nullable text,
+                commit = commitId as nullable text,
+                object = objectId as nullable text
+            ],
+    ParseFe2Url = (server as text, segments as list) as record =>
+        let
+            streamId = segments{1},
+            modelList = segments{3},
+            firstModel = Text.Split(modelList, ","){0},
+            modelAndVersion = Text.Split(firstModel, "@"),
+            modelId = modelAndVersion{0},
+            versionId = if (List.Count(modelAndVersion) > 1) then modelAndVersion{1} else null,
+            model = if (modelId <> null) then GetModel(server, streamId, modelId) else null,
+            urlType = GetUrlType(model[name], versionId, null)
+        in
+            [
+                urlType = urlType,
+                server = server,
+                id = streamId,
+                branch = model[name],
+                commit = versionId,
+                object = null
+            ]
 in
     (url as text) as record =>
         let
             // Get server and streamId, and branchName / commitId / objectid from the input url
             server = Text.Combine({Uri.Parts(url)[Scheme], "://", Uri.Parts(url)[Host]}),
             segments = Text.Split(Text.AfterDelimiter(Uri.Parts(url)[Path], "/", 0), "/"),
-            streamId = segments{1},
-            modelList = if (List.Count(segments) = 4 and segments{2} = "models") then segments{3} else null,
-            firstModel = Text.Split(modelList, ","){0},
-            modelAndVersion = Text.Split(firstModel, "@"),
-            modelId = modelAndVersion{0},
-            versionId = if (List.Count(modelAndVersion) > 1) then modelAndVersion{1} else null,
-            model = if (modelId <> null) then GetModel(server, streamId, modelId) else null,
-            branchName = if (List.Count(segments) = 4 and segments{2} = "branches") then segments{3} else null,
-            commitId = if (List.Count(segments) = 4 and segments{2} = "commits") then segments{3} else null,
-            objectId = if (List.Count(segments) = 4 and segments{2} = "objects") then segments{3} else null,
-            modelOrBranchName = if (model <> null) then model[name] else branchName,
-            commitOrVersion = if (versionId <> null) then versionId else commitId,
-            urlType =
-                if (commitOrVersion <> null) then
-                    "Commit"
-                else if (objectId <> null) then
-                    "Object"
-                else if (modelOrBranchName <> null) then
-                    "Branch"
-                else
-                    "Stream"
+            isFe2 = IsFe2Url(segments)
         in
-            [
-                urlType = urlType,
-                server = server,
-                id = streamId,
-                branch = modelOrBranchName,
-                commit = commitOrVersion,
-                object = objectId
-            ]
+            if (isFe2) then
+                ParseFe2Url(server, segments)
+            else
+                ParseFe1Url(server, segments)