fix: resolve comments

This commit is contained in:
AbhinRustagi
2026-05-08 05:24:40 +05:30
parent b801c1ccea
commit 25cfd2777f
4 changed files with 32 additions and 7 deletions
+7 -1
View File
@@ -77,7 +77,13 @@ interface Window {
videoData: ArrayBuffer,
fileName: string,
exportFolder?: string,
) => Promise<{ success: boolean; path?: string; message?: string; canceled?: boolean }>;
) => Promise<{
success: boolean;
path?: string;
message?: string;
canceled?: boolean;
error?: string;
}>;
openVideoFilePicker: () => Promise<{ success: boolean; path?: string; canceled?: boolean }>;
setCurrentVideoPath: (path: string) => Promise<{ success: boolean }>;
setCurrentRecordingSession: (
+8 -2
View File
@@ -842,8 +842,14 @@ export function registerIpcHandlers(
if (stats.isDirectory()) {
defaultDir = exportFolder;
}
} catch {
// Folder was moved or deleted since the last export; keep Downloads.
} catch (err) {
// Stat can fail because the folder was moved/deleted (expected) or
// because of a permission error (worth surfacing). Either way we
// fall back to Downloads, but log so debugging isn't blind.
console.warn(
`Could not access remembered export folder "${exportFolder}", falling back to Downloads:`,
err,
);
}
}
+9 -4
View File
@@ -31,7 +31,12 @@ import {
import { computeFrameStepTime } from "@/lib/frameStep";
import type { ProjectMedia } from "@/lib/recordingSession";
import { matchesShortcut } from "@/lib/shortcuts";
import { loadUserPreferences, parentDirectoryOf, saveUserPreferences } from "@/lib/userPreferences";
import {
getExportFolder,
loadUserPreferences,
parentDirectoryOf,
saveUserPreferences,
} from "@/lib/userPreferences";
import { BackgroundLoadError } from "@/lib/wallpaper";
import {
getAspectRatioValue,
@@ -1313,7 +1318,7 @@ export default function VideoEditor() {
const saveResult = await window.electronAPI.saveExportedVideo(
unsavedExport.arrayBuffer,
unsavedExport.fileName,
loadUserPreferences().exportFolder ?? undefined,
getExportFolder(),
);
if (saveResult.canceled) {
toast.info("Export canceled");
@@ -1418,7 +1423,7 @@ export default function VideoEditor() {
const saveResult = await window.electronAPI.saveExportedVideo(
arrayBuffer,
fileName,
loadUserPreferences().exportFolder ?? undefined,
getExportFolder(),
);
if (saveResult.canceled) {
@@ -1562,7 +1567,7 @@ export default function VideoEditor() {
const saveResult = await window.electronAPI.saveExportedVideo(
arrayBuffer,
fileName,
loadUserPreferences().exportFolder ?? undefined,
getExportFolder(),
);
if (saveResult.canceled) {
+8
View File
@@ -112,6 +112,14 @@ export function parentDirectoryOf(filePath: string): string | null {
return filePath.slice(0, lastSep);
}
/**
* Returns the remembered export folder as `string | undefined`, suitable for
* passing directly to IPC handlers that treat absence as "use the default".
*/
export function getExportFolder(): string | undefined {
return loadUserPreferences().exportFolder ?? undefined;
}
/**
* Persist user preferences to localStorage.
* Only the explicitly provided fields are updated.