Robin Malfait
e9fd05e06d
This is an issue in the Vue version (it just works in the React version) but I added tests for them anyway. While this solution "works" I am not 100% happy with it. Let me explain what's happening here and why I am not that happy about it: - For starters, the Vue `nextTick` is apparently too fast. So what we do is when we get the pointer up event, we will close the menu and re-focus the button. We ran this code in a `nextTick` so that we can ensure that we close the menu *after* all the click events are finished. However because this is too fast, the menu is already closed and the anchor link is already unmounted and thus not clickable anymore. So instead we use a double requestAnimationFrame (to mimick a `nextFrame` as seen in the `disposables` from the React code). This works, but a bit messy, oh well. - The next reason why I am not that happy is because I can't reproduce it in JSDOM (Jest tests). When you *click* a link in JSDOM it doesn't update the `window.location.hash` or `window.location.href`. To mimick that behaviour I put a `@click` event on the anchor to verify that we actually clicked it. However this already works, even before the "fix". So I left a TODO in there so that we can hopefully fix the test, so that we _can_ reproduce this behaviour. Fixes: #14