cleanup unnecesary dependencies

This commit is contained in:
Robin Malfait
2021-04-08 13:04:03 +02:00
parent 0187de13b5
commit cdfeeacf43
4 changed files with 41 additions and 53 deletions
@@ -179,19 +179,16 @@ let Button = forwardRefWithAs(function Button<TTag extends ElementType = typeof
[dispatch]
)
let handleKeyUp = useCallback(
(event: ReactKeyboardEvent<HTMLButtonElement>) => {
switch (event.key) {
case Keys.Space:
// Required for firefox, event.preventDefault() in handleKeyDown for
// the Space key doesn't cancel the handleKeyUp, which in turn
// triggers a *click*.
event.preventDefault()
break
}
},
[dispatch]
)
let handleKeyUp = useCallback((event: ReactKeyboardEvent<HTMLButtonElement>) => {
switch (event.key) {
case Keys.Space:
// Required for firefox, event.preventDefault() in handleKeyDown for
// the Space key doesn't cancel the handleKeyUp, which in turn
// triggers a *click*.
event.preventDefault()
break
}
}, [])
let handleClick = useCallback(
(event: ReactMouseEvent) => {
@@ -307,19 +307,16 @@ let Button = forwardRefWithAs(function Button<TTag extends ElementType = typeof
[dispatch, state, d]
)
let handleKeyUp = useCallback(
(event: ReactKeyboardEvent<HTMLButtonElement>) => {
switch (event.key) {
case Keys.Space:
// Required for firefox, event.preventDefault() in handleKeyDown for
// the Space key doesn't cancel the handleKeyUp, which in turn
// triggers a *click*.
event.preventDefault()
break
}
},
[dispatch]
)
let handleKeyUp = useCallback((event: ReactKeyboardEvent<HTMLButtonElement>) => {
switch (event.key) {
case Keys.Space:
// Required for firefox, event.preventDefault() in handleKeyDown for
// the Space key doesn't cancel the handleKeyUp, which in turn
// triggers a *click*.
event.preventDefault()
break
}
}, [])
let handleClick = useCallback(
(event: ReactMouseEvent) => {
@@ -251,19 +251,16 @@ let Button = forwardRefWithAs(function Button<TTag extends ElementType = typeof
[dispatch, d]
)
let handleKeyUp = useCallback(
(event: ReactKeyboardEvent<HTMLButtonElement>) => {
switch (event.key) {
case Keys.Space:
// Required for firefox, event.preventDefault() in handleKeyDown for
// the Space key doesn't cancel the handleKeyUp, which in turn
// triggers a *click*.
event.preventDefault()
break
}
},
[dispatch]
)
let handleKeyUp = useCallback((event: ReactKeyboardEvent<HTMLButtonElement>) => {
switch (event.key) {
case Keys.Space:
// Required for firefox, event.preventDefault() in handleKeyDown for
// the Space key doesn't cancel the handleKeyUp, which in turn
// triggers a *click*.
event.preventDefault()
break
}
}, [])
let handleClick = useCallback(
(event: ReactMouseEvent) => {
@@ -430,19 +427,16 @@ let Items = forwardRefWithAs(function Items<TTag extends ElementType = typeof DE
[dispatch, searchDisposables, state]
)
let handleKeyUp = useCallback(
(event: ReactKeyboardEvent<HTMLButtonElement>) => {
switch (event.key) {
case Keys.Space:
// Required for firefox, event.preventDefault() in handleKeyDown for
// the Space key doesn't cancel the handleKeyUp, which in turn
// triggers a *click*.
event.preventDefault()
break
}
},
[dispatch]
)
let handleKeyUp = useCallback((event: ReactKeyboardEvent<HTMLButtonElement>) => {
switch (event.key) {
case Keys.Space:
// Required for firefox, event.preventDefault() in handleKeyDown for
// the Space key doesn't cancel the handleKeyUp, which in turn
// triggers a *click*.
event.preventDefault()
break
}
}, [])
let slot = useMemo<ItemsRenderPropArg>(() => ({ open: state.menuState === MenuStates.Open }), [
state,
@@ -1,4 +1,4 @@
import { defineComponent, h } from 'vue'
import { defineComponent } from 'vue'
import { render as testRender } from '../test-utils/vue-testing-library'
import { render } from './render'