huanld/headlessui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Ensure Popover doesn't crash when focus is going to window (#2019)

Browse Source 
* ensure Popover doesn't crash when `focus` is going to `window`

* update changelog
This commit is contained in:
Robin Malfait
2022-11-16 15:11:01 +01:00
committed by GitHub
parent f0dd25fbab
commit a4c7cab8a7
4 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/@headlessui-react/CHANGELOG.md
+1
View File
@@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Reset form-like components when the parent `<form>` resets ([#2004](https://github.com/tailwindlabs/headlessui/pull/2004))
- Add warning when using `<Popover.Button />` multiple times ([#2007](https://github.com/tailwindlabs/headlessui/pull/2007))
- Ensure Popover doesn't crash when `focus` is going to `window` ([#2019](https://github.com/tailwindlabs/headlessui/pull/2019))
## [1.7.4] - 2022-11-03
packages/@headlessui-react/src/components/popover/popover.tsx
+1
View File
@@ -281,6 +281,7 @@ let PopoverRoot = forwardRefWithAs(function Popover<
if (isFocusWithinPopoverGroup()) return
if (!button) return
if (!panel) return
if (event.target === window) return
if (beforePanelSentinel.current?.contains?.(event.target as HTMLElement)) return
if (afterPanelSentinel.current?.contains?.(event.target as HTMLElement)) return
packages/@headlessui-vue/CHANGELOG.md
+1
View File
@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed
- Reset form-like components when the parent `<form>` resets ([#2004](https://github.com/tailwindlabs/headlessui/pull/2004))
- Ensure Popover doesn't crash when `focus` is going to `window` ([#2019](https://github.com/tailwindlabs/headlessui/pull/2019))
## [1.7.4] - 2022-11-03
packages/@headlessui-vue/src/components/popover/popover.ts
+1
View File
@@ -223,6 +223,7 @@ export let Popover = defineComponent({
if (isFocusWithinPopoverGroup()) return
if (!button) return
if (!panel) return
if (event.target === window) return
if (dom(api.beforePanelSentinel)?.contains(event.target as HTMLElement)) return
if (dom(api.afterPanelSentinel)?.contains(event.target as HTMLElement)) return