1 Commits

Author SHA1 Message Date
Kristaps Fabians Geikins c751b3bd8a fix: ensuring useQuery immediately returns results from cache, to prevent hydration errors 2022-12-12 11:59:50 +02:00
3 changed files with 18 additions and 37 deletions
+4 -4
View File
@@ -1,10 +1,10 @@
{
"name": "@speckle/vue-apollo-composable",
"version": "4.0.0-beta.2",
"name": "@vue/apollo-composable",
"version": "4.0.0-beta.1",
"description": "Apollo GraphQL for Vue Composition API",
"repository": {
"type": "git",
"url": "https://github.com/specklesystems/apollo.git",
"url": "https://github.com/vuejs/vue-apollo.git",
"directory": "packages/vue-apollo-composable"
},
"keywords": [
@@ -32,7 +32,7 @@
"dev": "rimraf dist && nodemon --exec 'pnpm run build:code' --watch src --ext js,ts",
"build": "rimraf dist && pnpm run build:code",
"build:code": "node esbuild.mjs && tsc -d --emitDeclarationOnly",
"prepublishOnly": "pnpm run test && pnpm run build:code",
"prepublishOnly": "pnpm run test && pnpm run build",
"test": "pnpm run test:types",
"test:types": "tsc -p tests/types/"
},
+14 -33
View File
@@ -171,45 +171,20 @@ export function useQueryImpl<
// SSR
let firstResolve: (() => void) | undefined
let firstResolveTriggered = false
let firstReject: ((apolloError: ApolloError) => void) | undefined
let firstRejectError: undefined | ApolloError
const tryFirstResolve = () => {
firstResolveTriggered = true
if (firstResolve) firstResolve()
}
const tryFirstReject = (apolloError: ApolloError) => {
firstRejectError = apolloError
if (firstReject) firstReject(apolloError)
}
const resetFirstResolveReject = () => {
firstResolve = undefined
firstReject = undefined
firstResolveTriggered = false
firstRejectError = undefined
stop()
}
vm && onServerPrefetch?.(() => {
if (!isEnabled.value || (isServer && currentOptions.value?.prefetch === false)) return
return new Promise<void>((resolve, reject) => {
firstResolve = () => {
resetFirstResolveReject()
resolve()
firstResolve = undefined
firstReject = undefined
}
firstReject = (apolloError: ApolloError) => {
resetFirstResolveReject()
reject(apolloError)
}
if (firstResolveTriggered) {
firstResolve()
} else if (firstRejectError) {
firstReject(firstRejectError)
firstResolve = undefined
firstReject = undefined
}
}).then(stop).catch(stop)
})
@@ -232,7 +207,7 @@ export function useQueryImpl<
started || !isEnabled.value ||
(isServer && currentOptions.value?.prefetch === false)
) {
tryFirstResolve()
if (firstResolve) firstResolve()
return
}
@@ -300,7 +275,10 @@ export function useQueryImpl<
processError(resultErrorsToApolloError(queryResult.errors))
}
tryFirstResolve()
if (firstResolve) {
firstResolve()
stop()
}
}
function processNextResult (queryResult: ApolloQueryResult<TResult>) {
@@ -320,7 +298,10 @@ export function useQueryImpl<
processNextResult((query.value as ObservableQuery<TResult, TVariables>).getCurrentResult())
}
processError(apolloError)
tryFirstReject(apolloError)
if (firstReject) {
firstReject(apolloError)
stop()
}
// The observable closes the sub if an error occurs
resubscribeToQuery()
}
@@ -347,7 +328,7 @@ export function useQueryImpl<
* Stop watching the query
*/
function stop () {
tryFirstResolve()
if (firstResolve) firstResolve()
if (!started) return
started = false
loading.value = false