From e9735dfb2b63e61ce8f9f6bada945697ca35df37 Mon Sep 17 00:00:00 2001 From: Dustin Campbell Date: Wed, 14 Oct 2015 13:41:19 -0700 Subject: [PATCH] No need to serialize the entire test case if we don't use it --- xunit.runner.data/TestCaseData.cs | 13 +++---------- xunit.runner.worker/DiscoverUtil.cs | 1 - 2 files changed, 3 insertions(+), 11 deletions(-) diff --git a/xunit.runner.data/TestCaseData.cs b/xunit.runner.data/TestCaseData.cs index 2ce446c..2ba33be 100644 --- a/xunit.runner.data/TestCaseData.cs +++ b/xunit.runner.data/TestCaseData.cs @@ -1,10 +1,6 @@ -using System; -using System.Collections.Generic; +using System.Collections.Generic; using System.IO; -using System.Linq; using System.Runtime.Serialization.Formatters.Binary; -using System.Text; -using System.Threading.Tasks; namespace xunit.runner.data { @@ -15,9 +11,8 @@ namespace xunit.runner.data public string AssemblyPath { get; set; } public Dictionary> TraitMap { get; set; } - public TestCaseData(string serializedForm, string displayName, string assemblyPath, Dictionary> traitMap) + public TestCaseData(string displayName, string assemblyPath, Dictionary> traitMap) { - SerializedForm = serializedForm; DisplayName = displayName; AssemblyPath = assemblyPath; TraitMap = traitMap; @@ -26,17 +21,15 @@ namespace xunit.runner.data public static TestCaseData ReadFrom(BinaryReader reader) { var formatter = new BinaryFormatter(); - var serializedForm = reader.ReadString(); var displayName = reader.ReadString(); var assemblyPath = reader.ReadString(); var traitMap = (Dictionary>)formatter.Deserialize(reader.BaseStream); - return new TestCaseData(serializedForm, displayName, assemblyPath, traitMap); + return new TestCaseData(displayName, assemblyPath, traitMap); } public void WriteTo(BinaryWriter writer) { var formatter = new BinaryFormatter(); - writer.Write(SerializedForm); writer.Write(DisplayName); writer.Write(AssemblyPath); formatter.Serialize(writer.BaseStream, TraitMap); diff --git a/xunit.runner.worker/DiscoverUtil.cs b/xunit.runner.worker/DiscoverUtil.cs index 3cdc8ae..f685f69 100644 --- a/xunit.runner.worker/DiscoverUtil.cs +++ b/xunit.runner.worker/DiscoverUtil.cs @@ -29,7 +29,6 @@ namespace xunit.runner.worker { var testCase = testCaseDiscovered.TestCase; var testCaseData = new TestCaseData( - _discoverer.Serialize(testCase), testCase.DisplayName, testCaseDiscovered.TestAssembly.Assembly.AssemblyPath, testCase.Traits);