From b5b0922e7f2195fa3bc0e7bce5a717c342d11c06 Mon Sep 17 00:00:00 2001 From: Adam Hathcock Date: Mon, 28 Apr 2025 09:35:02 +0100 Subject: [PATCH] Revert to write async --- .../Serialization/ChannelSaver.cs | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/Speckle.Sdk.Dependencies/Serialization/ChannelSaver.cs b/src/Speckle.Sdk.Dependencies/Serialization/ChannelSaver.cs index f340c53c..fd7019ba 100644 --- a/src/Speckle.Sdk.Dependencies/Serialization/ChannelSaver.cs +++ b/src/Speckle.Sdk.Dependencies/Serialization/ChannelSaver.cs @@ -74,12 +74,9 @@ public abstract class ChannelSaver { return; //don't save if we're already done through an error } - //better wait to handle writes instead of WriteAsync to create unlimited tasks - while (await _checkCacheChannel.Writer.WaitToWriteAsync(cancellationToken).ConfigureAwait(false)) - { - if (_checkCacheChannel.Writer.TryWrite(item)) - return; - } + //can switch to check then try pattern when back pressure is needed or exceptions are too much + //the trees don't need to respond to back pressure + await _checkCacheChannel.Writer.WriteAsync(item, cancellationToken); } private async Task> SendToServer(IMemoryOwner batch)