From 7883cd9d3286cab5dd9a6c687051e1fc330451ff Mon Sep 17 00:00:00 2001 From: Adam Hathcock Date: Mon, 2 Sep 2024 13:52:27 +0100 Subject: [PATCH] Don't use Serilog global static logger in v3 (#96) * Don't use Serilog global static logger in v3 * make logger be internal only --- src/Speckle.Sdk.Logging/LogBuilder.cs | 2 +- src/Speckle.Sdk.Logging/SpeckleLog.cs | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Speckle.Sdk.Logging/LogBuilder.cs b/src/Speckle.Sdk.Logging/LogBuilder.cs index f30ef86c..54ed1845 100644 --- a/src/Speckle.Sdk.Logging/LogBuilder.cs +++ b/src/Speckle.Sdk.Logging/LogBuilder.cs @@ -69,7 +69,7 @@ public static class LogBuilder serilogLogConfiguration = InitializeOtelLogging(serilogLogConfiguration, speckleLogging.Otel, resourceBuilder); } var logger = serilogLogConfiguration.CreateLogger(); - Log.Logger = logger; + SpeckleLog.SpeckleLogger = logger; logger .ForContext("hostApplication", applicationAndVersion) diff --git a/src/Speckle.Sdk.Logging/SpeckleLog.cs b/src/Speckle.Sdk.Logging/SpeckleLog.cs index 48b465db..c5f02ea1 100644 --- a/src/Speckle.Sdk.Logging/SpeckleLog.cs +++ b/src/Speckle.Sdk.Logging/SpeckleLog.cs @@ -1,12 +1,12 @@ -using Serilog; using Serilog.Core; namespace Speckle.Sdk.Logging; public static class SpeckleLog { - public static ISpeckleLogger Logger => new SpeckleLogger(Serilog.Log.Logger); + internal static Serilog.ILogger SpeckleLogger { get; set; } = Serilog.Core.Logger.None; + public static ISpeckleLogger Logger => new SpeckleLogger(SpeckleLogger); public static ISpeckleLogger Create(string name) => - new SpeckleLogger(Log.Logger.ForContext(Constants.SourceContextPropertyName, name)); + new SpeckleLogger(SpeckleLogger.ForContext(Constants.SourceContextPropertyName, name)); }