Commit Graph

1139 Commits

Author SHA1 Message Date
Adam Hathcock b98e564cd1 Add null check for revit API (#272) 2024-09-24 13:57:14 +03:00
Oğuzhan Koral fd992d6471 Fix(autocad): TryGetMaterialId for both cases (#259)
* Covers both cases on render materials

* Remove unneccessary return result list

---------

Co-authored-by: Dimitrie Stefanescu <didimitrie@gmail.com>
2024-09-23 16:58:06 +00:00
Oğuzhan Koral 50414e95ad Add units info to root object on send (#260)
Co-authored-by: KatKatKateryna <89912278+KatKatKateryna@users.noreply.github.com>
Co-authored-by: Dimitrie Stefanescu <didimitrie@gmail.com>
2024-09-23 16:52:23 +00:00
Dimitrie Stefanescu 6d3eb88b20 Dimitrie/cnx 430 re evaluate parameters (#255)
* wip

* feat(dui3): simpler parameter extraction logic + parameter definitions

* chore: refactoring

* wip

* feat(revit): removes parameter definition handler from context stack and relies on DI

cc oguzhan, we'll need to refactor a few things with this in mind

* chore: adds comments

* feat: comments and logging

* feat(revit): WIP adds setting for null/empty param sending, and other refactors

* feat: respects setting in extraction logic

* chore(dui3): adds extra comments

* Fix build errors

* feat: removes dead code

---------

Co-authored-by: oguzhankoral <oguzhankoral@gmail.com>
2024-09-23 16:45:49 +00:00
Adam Hathcock 33bf13602a Revert new DI simplification (#269) 2024-09-23 17:08:00 +01:00
Dimitrie Stefanescu 0c007d33ae Merge pull request #268 from specklesystems/add-deep-clean
add deep clean
2024-09-23 16:33:34 +01:00
Dimitrie Stefanescu 61ea029d76 Merge branch 'dev' into add-deep-clean 2024-09-23 16:28:34 +01:00
Dimitrie Stefanescu ef7ff4b42a Merge pull request #267 from specklesystems/fix-DI-internal
DI classes should be public
2024-09-23 16:23:36 +01:00
Adam Hathcock f99eca8537 add deep clean 2024-09-23 16:20:43 +01:00
Adam Hathcock c8c50fa4be DI classes should be public 2024-09-23 16:18:08 +01:00
Adam Hathcock 7307e83860 Simplify DI assembly structure (#256)
* Rename utils to common

* fix namespaces

* Rhino kind of works

* Fix converter registration

* Fixed circular referece with lazy resolving

* Fixed Rhino8

* Revit 2022 builds

* revit 2023 compiles

* working on revit

* use speckle app for info instead of statics

* lazy init bindings

* Rhino compiles

* Revit compiles

* Autocad 2022 builds

* Autocad/Civil builds

* ArcGIS compiles

* Remove Autofac completely

* format

* React to SDK renames

* fixes for merge

* Update nuget and official sln

* Remove extra projects

* AutoActivate IBrowserBridge and rename it

* add extra null check
2024-09-23 15:27:46 +01:00
kekesidavid e1e762642a Fix(Revit): Delete Previous Model Groups on Multiple Receive (#263)
* fix: Delete Previous Model Groups on Multiple Receive

* made GetGroupsByName private
2024-09-20 13:24:44 +02:00
Jedd Morgan 6deb59e7f0 WIP on jedd/cnx-462-async-ify-executescriptasync-calls-to-ensure-solid-threading (#261) 2024-09-19 15:50:56 +02:00
Alan Rynne cb78f42c41 fix: Tweak logging to console on debug and seq on release (#258) 2024-09-19 12:58:03 +00:00
Dimitrie Stefanescu 4e48427bee Revit receive first pass: reference geometry workflow (CNX-403) (#254)
* feat(dui3): re-enables receive binding

probably the fourth time

* chore(revit): drastic cleanup

maybe too drastic, we will see soon

* feat(revit): starts scaffolding revit root to host converter

* RenderMaterialToHostConverter added back

* casting to GeometryObject instead of GeometryElement

* feat(dui3): fallback display values and refactors out material converter

* feat(dui3): creates DS and adds point support

* feat(dui3): closed nurbs fallback to display values

* David/cnx 443 selection (#231)

* highlight works

* use status.success on receive success

* question comment

* wip

* feat(revit): wraps receive in correct context

* wip

* feat(dui3): adds prototype grouping by collection

and adds todos

* remove invalid characters from group name

* hide warnings preprocessor

* exception handling and error log

* added cancellation and progress reporting

* chore: comments and minor cleanup

* David/cnx 409 2 add rendermaterial and color manager to connector (#242)

* materials wip

* Make it work receiving render materials

* MaterialBaker mods, cleanup

* Address the PR comments

* Remove invalid chars from structured material names

---------

Co-authored-by: oguzhankoral <oguzhankoral@gmail.com>

* Minor cleanup

* Add object application id into objects of its layer render material proxy

* feat(dui3): adds compatibility for objects with display values

* Use LocalToGlobal logic for revit receive

* Use common local to global util for arcgis too

* Remove unnecessary registration

* Remove using

* Remove unnecessart ToList

* Register LocalToGlobalConverterUtils for connectors not as common

* purge materials and groups in Revit before update (#245)

* purge materials and groups in Revit before update

* cleaner linq

* renamed _groupManager to _groupBaker

* assign categories to DirectShapes after receive, updated revit invalid chars (#253)

* Post conflict resolving problems

* minor changes, logging, comments (#257)

* minor changes, logging, comments

* typo

---------

Co-authored-by: David Kekesi <david@speckle.systems>
Co-authored-by: kekesidavid <david.kekesi@gmail.com>
Co-authored-by: oguzhankoral <oguzhankoral@gmail.com>
2024-09-19 14:09:17 +03:00
Oğuzhan Koral 2418b3e564 Fix(rhino): missing render material of layers on second send (#252)
* Fix the missing RenderMaterial prop of Layer

* Continue if RenderMaterial is set
2024-09-18 18:47:54 +03:00
Adam Hathcock 4a2233e167 SDK is non static and logging/tracing controls are moved to the connectors (#239)
* use new containerized SDK

* Use containered Tracing and Logging

* Autocad loads

* logging builds

* fmt

* Remove console logger and hook up merged logging

* cleanup

* Clean up logging

* use nuget

* Add Logging project to solution then consolidate getting assembly version

* don't need this project anymore

* merge fixes

* add new seq config

---------

Co-authored-by: Jedd Morgan <45512892+JR-Morgan@users.noreply.github.com>
2024-09-18 14:13:18 +00:00
Adam Hathcock 1dbb2b6abe Dispose Containers (except for Autocad) (#250) 2024-09-18 16:03:56 +02:00
Oğuzhan Koral b52d66c522 Pass base object not mesh under displayValues (#249) 2024-09-18 14:57:52 +03:00
Adam Hathcock 3454587330 Add tracing around conversions and success/failure exceptions (#241)
* Add tracing around conversions and success/failure exceptions

* merge fixes
2024-09-18 10:03:09 +00:00
Alan Rynne ac1e402d1d fix: Prevent increment when release commit is tagged (#246) 2024-09-18 10:35:22 +02:00
Adam Hathcock 8d0d7a89f7 Change conversion stack to better usage for products. (#215)
* fix: Push to sync with Jedd

* Jedd's record suggestions

* cleanup stack

* Revit settings converted

* more settings changes

* fix unit of work and scope registration

* rename

* fix more settings

* Use a generic factory to create settings contexts

* fix ArcGIS

* generic sending

* fix ArcGIS

* remove extras

* fix crs scoping

* fix autocad

* fix units for arcgis

* civil3d conversions

* rhino mostly works

* Rhino and recieve changed

* fix revit tests

* fix rhino tests

* fix merge

* make settings a record again

* fixes from reversion

* merge fixes

* ArcGIS reverts

* more senders reverted

* remove added reference

* clean up locks and files

* update nunit

* make things proper records

* fix test

* Merge fixes

* merge fixes

* Initialize the settings instead of push empty

* scan things consistently

---------

Co-authored-by: Alan Rynne <alan@speckle.systems>
Co-authored-by: Jedd Morgan <45512892+JR-Morgan@users.noreply.github.com>
2024-09-17 14:42:00 +02:00
Oğuzhan Koral cc285e99ee Add WorkspaceId to model card (#236)
it is needed to store information between sessions
2024-09-16 16:49:11 +03:00
Jedd Morgan eb8f8defc0 Jedd/cxpla 55 add required keyword for more geometry types (#220)
* Nullability of TryGet function

* blip

* Connector side changes

* Fixes

* Fixed other SDK changes

* Fixed Meters defaulting in Revit

* Agis fix required units (#224)

* fix arcgis units

* usings

* correct units

---------

Co-authored-by: Jedd Morgan <45512892+JR-Morgan@users.noreply.github.com>

* Fixed compiler errors

* Resolved PR Comments

* Fixed last revit units issue

* extras

* Bumped sdk deps

---------

Co-authored-by: KatKatKateryna <89912278+KatKatKateryna@users.noreply.github.com>
2024-09-16 11:09:49 +02:00
KatKatKateryna 466ac5e49d AGIS mesh boundaries (#222) 2024-09-16 16:47:06 +08:00
Dimitrie Stefanescu 359954cd11 Merge pull request #238 from specklesystems/oguzhan/cnx-436-autocad-wrong-arc-conversions-again
Fix(autocad): Evaluate mid point with angle
2024-09-13 12:24:58 +01:00
oguzhankoral 55e8ad8493 Evaluate mid point with angle 2024-09-12 19:22:56 +03:00
Oğuzhan Koral 3d64a3c4b7 Feat(dui3): improve root and host builders (#226)
* Remove SyncToThread from connectors

* Run only conversion under RevitTask.RunAsync

* Remove SyncToThread from RhinoHostObjectBuilder

* Introduce RootObjectUnpacker

* Split bakers and unpackers for Rhino

* Remove unnecessary out

* Use RootObjectUnpacker for proxies

* Extract proxy keys to outside

* Remove redundant comment

* Add logger for unpackers and bakers

* Add steps to RhinoRootObjectBuilder

* Pass only projectId instead of all SendInfo to ConvertRhinoObject function

* Align AutocadRootObjectBuilder with RhinoRootObjectBuilder

* Align AutocadHostObjectBuilder with RhinoHostObjectBuilder

* Use ProxyKeys on arcgis and revit

* Split unpackers and bakers for autocad

* Note to Autocad SyncToThread

* Add logger to autocad unpackers and bakers

* Notes

* Reimplemented Async builder (#229)

* Split layer manager into bakers and unpackers

Also introduces LayerPathUnpacker as abstract class to handle GetLayerPath

* Remove redundant notes

* Make GetLayerPath logic same for autocad and rhino

* Use ex instead e for exception

* chore: fixes PR comments

---------

Co-authored-by: Jedd Morgan <45512892+JR-Morgan@users.noreply.github.com>
Co-authored-by: Dimitrie Stefanescu <didimitrie@gmail.com>
2024-09-11 20:26:21 +03:00
Alan Rynne d358a75769 Merge pull request #235 from specklesystems/dev
.NET Build and Publish / build (push) Has been cancelled
.NET Build and Publish / test (push) Has been cancelled
.NET Build and Publish / deploy-installers (push) Has been cancelled
Update release/3.0.0 with changes from dev.
v3.0.0-beta.203
2024-09-11 14:26:50 +02:00
Oğuzhan Koral 75ebf8f549 Add new properties to ReceiverModelCard for mixpanel tracking (#234) 2024-09-11 12:53:10 +01:00
Oğuzhan Koral 4c462923f2 Use default CancellationTokenSource.None (#233) 2024-09-11 11:16:35 +01:00
Oğuzhan Koral 53522a8307 Increase time span for ActionBlock (#232) 2024-09-11 08:48:59 +00:00
Alan Rynne c42ad3f042 chore(ci): Add release branches to CI trigger
.NET Build and Publish / build (push) Has been cancelled
.NET Build and Publish / test (push) Has been cancelled
.NET Build and Publish / deploy-installers (push) Has been cancelled
v3.0.0-beta.202
2024-09-10 18:19:16 +02:00
Alan Rynne e75ca72abd Merge branch 'dev' into release/3.0.0 2024-09-10 17:21:59 +02:00
Adam Hathcock 7e4125cb93 Switch tracing to seq dev. Turn off tracing to console when debugging (#228) 2024-09-10 14:03:21 +00:00
Alan Rynne 0a568ac9fd fix(gitversion): Use GitFlow defaults (#230) 2024-09-10 13:50:26 +00:00
Alan Rynne 859193be37 fix: Delete build artifacts after build-installers job is done (#225)
Do so regardless of fail/success of the deployment
2024-09-10 14:52:48 +02:00
Adam Hathcock 49c2494d3c Build Revit 2022 on Local (#227) 2024-09-09 14:24:22 +02:00
Jedd Morgan cfe1980e7a bump sdks
.NET Build and Publish / build (push) Has been cancelled
.NET Build and Publish / test (push) Has been cancelled
.NET Build and Publish / deploy-installers (push) Has been cancelled
v3.0.0-beta.201
2024-09-06 14:22:23 +01:00
Oğuzhan Koral f1a5a4cbfe Use Invoke function instead InvokeAsync (#223) 2024-09-06 13:34:22 +03:00
KatKatKateryna ddccb44341 remove unused function (#221)
* remove unused

* usings

* shuffle
2024-09-05 21:31:43 +01:00
kekesidavid 98f43032a0 fix(Revit):CNX-414 fixes DirectShape category bug (#219)
* direct shape not sending fix

* extended POC comment
2024-09-05 11:44:28 +02:00
KatKatKateryna 7bbc3a0121 Agis fix geometry deviations (#211)
* pass down the same SpatialReference

* fixes

* Revert "fixes"

This reverts commit e443f293b4.

* Revert "pass down the same SpatialReference"

This reverts commit 7cc8d5f4df.

* only pass CRS after densification

* comment
2024-09-03 13:32:01 +00:00
KatKatKateryna 02e7ed95b4 AGIS more specific document naming (#218)
* more specific document naming

* clear cache
2024-09-03 13:20:47 +00:00
KatKatKateryna ff540caad7 fix update changed IDs (#209)
* fix update changed IDs

* better naming

* remove initial count

* move layer order method also to mapMemberUtils

* loop

* better names

* comment

* fix

* split layers and tables

* refactor layer loop
2024-09-03 13:15:22 +00:00
Jedd Morgan d78345367b Nullability of TryGet function (#217)
.NET Build and Publish / build (push) Has been cancelled
.NET Build and Publish / test (push) Has been cancelled
.NET Build and Publish / deploy-installers (push) Has been cancelled
v3.0.0-beta.194
2024-09-03 08:49:32 +01:00
Alan Rynne 236cdb4a23 chore: Use rc version of SDK and Objects (#216)
* chore: Use 3.0.1-rc in all connectors

* fix: Remove USFeet from unit support in Civil and ArcGIS
2024-09-02 13:51:48 +01:00
Jedd Morgan 9d6c91485e Add logging of send conversions (#214)
* Added logging to IRootToHostConverter

* Log send conversion errors

---------

Co-authored-by: Dimitrie Stefanescu <didimitrie@gmail.com>
Co-authored-by: Oğuzhan Koral <45078678+oguzhankoral@users.noreply.github.com>
2024-09-02 13:41:37 +01:00
Jedd Morgan 077ac246a8 Added logging to IRootToHostConverter (#212)
Co-authored-by: Dimitrie Stefanescu <didimitrie@gmail.com>
Co-authored-by: Oğuzhan Koral <45078678+oguzhankoral@users.noreply.github.com>
2024-08-30 19:34:33 +01:00
Claire Kuang 7852b1d2ff fix(revit): CNX-394 better reference point cache invalidation (#213)
* adds reference point transform to xyz, and refactors

* spelling fixes

* adds reference point caclulation to connector instead of converter

* disables xyz test for now due to complications mocking the reference point converter

* moves reference point transform method to separate class

* extracts to speckle settings into manager singleton

* removes  unecessary usings

* Pragma the send function sorry to not sorry

* optimizes mesh conversions

* removes unnessary meshconversion method and adds reference point transform to meshlist conversion

* better reference point invalidation logic

* Update MeshByMaterialDictionaryToSpeckle.cs

* fixes id evictions for objects that need to be unpacked

* removes circular dependency

---------

Co-authored-by: oguzhankoral <oguzhankoral@gmail.com>
Co-authored-by: Oğuzhan Koral <45078678+oguzhankoral@users.noreply.github.com>
2024-08-30 20:44:51 +03:00