From ea33f35a7d61d7db0fc0ea862b8c822b76ae0394 Mon Sep 17 00:00:00 2001 From: Claire Kuang Date: Fri, 17 Oct 2025 16:57:38 +0100 Subject: [PATCH] removes unnecessary casting on send --- .../Properties/PropertySetExtractor.cs | 30 ++----------------- 1 file changed, 2 insertions(+), 28 deletions(-) diff --git a/Converters/Civil3d/Speckle.Converters.Civil3dShared/ToSpeckle/Properties/PropertySetExtractor.cs b/Converters/Civil3d/Speckle.Converters.Civil3dShared/ToSpeckle/Properties/PropertySetExtractor.cs index b07003124..d15a75807 100644 --- a/Converters/Civil3d/Speckle.Converters.Civil3dShared/ToSpeckle/Properties/PropertySetExtractor.cs +++ b/Converters/Civil3d/Speckle.Converters.Civil3dShared/ToSpeckle/Properties/PropertySetExtractor.cs @@ -91,7 +91,8 @@ public class PropertySetExtractor ? propertyDefinitionName : data.FieldBucketId; - var value = GetValue(data); + // POC: not sure how to support graphic types atm + var value = data.DataType is AAEC.PropertyData.DataType.Graphic ? null : data.GetData(data.UnitType); Dictionary propertyValueDict = new() { ["value"] = value, ["name"] = dataName }; PropertyHandler propHandler = new(); @@ -109,31 +110,4 @@ public class PropertySetExtractor return null; } - - private object? GetValue(AAECPDB.PropertySetData data) - { - object fieldData = data.GetData(data.UnitType); - - switch (data.DataType) - { - case AAEC.PropertyData.DataType.Integer: - return fieldData as int?; - case AAEC.PropertyData.DataType.Real: - return fieldData as double?; - case AAEC.PropertyData.DataType.TrueFalse: - return fieldData as bool?; - case AAEC.PropertyData.DataType.Graphic: // POC: not sure how to support atm - return null; - case AAEC.PropertyData.DataType.List: - return fieldData as List; - case AAEC.PropertyData.DataType.AutoIncrement: - return fieldData as int?; - case AAEC.PropertyData.DataType.AlphaIncrement: // POC: not sure what this is - return fieldData; - case AAEC.PropertyData.DataType.Text: - return fieldData as string; - default: - return fieldData; - } - } }