From a5012eda02e1e40af600efda965dcfaef2864f8d Mon Sep 17 00:00:00 2001
From: Alan Rynne <alan@rynne.es>
Date: Thu, 29 Aug 2024 14:24:00 +0200
Subject: [PATCH] chore: Silence SDK1206 warnings for now (#207)

* chore: Silence SDK1206 warnings for now

* fix: Do not include sha in product info version
---
 Directory.Build.props | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Directory.Build.props b/Directory.Build.props
index 2d317b677..858928479 100644
--- a/Directory.Build.props
+++ b/Directory.Build.props
@@ -9,6 +9,7 @@
     <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
     <CentralPackageVersionOverrideEnabled>true</CentralPackageVersionOverrideEnabled>
     <EnableWindowsTargeting>true</EnableWindowsTargeting> <!-- windows packs for .net core  -->
+    <IncludeSourceRevisionInInformationalVersion>false</IncludeSourceRevisionInInformationalVersion>
   </PropertyGroup>
   
   <PropertyGroup Label="Analyers">
@@ -31,6 +32,8 @@
       CA1848;CA2254;CA1727;
       <!-- Others we don't want -->
       CA1815;CA1725;
+      <!-- Package using wrong RIDs (Net8 changed them). Usually fixable by updating.  -->
+      NETSDK1206;
       $(NoWarn)
     </NoWarn>
   </PropertyGroup>
@@ -52,6 +55,7 @@ complexity threshold -->
   <PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
     <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
   </PropertyGroup>
+  
   <PropertyGroup>
     <EmbedUntrackedSources>true</EmbedUntrackedSources>
     <AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder>