From 40650bfed2adb956eadd55184ada33296d90f174 Mon Sep 17 00:00:00 2001 From: Adam Hathcock Date: Fri, 20 Jun 2025 10:38:48 +0100 Subject: [PATCH 1/2] Don't mark cancelled or conversion exceptions as errors --- .../Operations/ReceiveConversionHandler.cs | 2 -- 1 file changed, 2 deletions(-) diff --git a/Sdk/Speckle.Connectors.Common/Operations/ReceiveConversionHandler.cs b/Sdk/Speckle.Connectors.Common/Operations/ReceiveConversionHandler.cs index 81cbeb152..5a7db72cd 100644 --- a/Sdk/Speckle.Connectors.Common/Operations/ReceiveConversionHandler.cs +++ b/Sdk/Speckle.Connectors.Common/Operations/ReceiveConversionHandler.cs @@ -20,13 +20,11 @@ public class ReceiveConversionHandler(ISdkActivityFactory activityFactory) : IRe catch (ConversionException ce) { //handle conversions but don't log to seq - convertActivity?.SetStatus(SdkActivityStatusCode.Error); return ce; } catch (OperationCanceledException) { //handle conversions but don't log to seq and also throw - convertActivity?.SetStatus(SdkActivityStatusCode.Error); throw; } catch (Exception ex) when (!ex.IsFatal()) From 60823dda97df4e9397520fb61f84a35f0a3e9ab2 Mon Sep 17 00:00:00 2001 From: Adam Hathcock Date: Fri, 20 Jun 2025 10:59:08 +0100 Subject: [PATCH 2/2] Remove error from test --- .../Operations/ReceiveConversionHandlerTests.cs | 2 -- 1 file changed, 2 deletions(-) diff --git a/Sdk/Speckle.Connectors.Common.Tests/Operations/ReceiveConversionHandlerTests.cs b/Sdk/Speckle.Connectors.Common.Tests/Operations/ReceiveConversionHandlerTests.cs index e90a151f3..c385302cb 100644 --- a/Sdk/Speckle.Connectors.Common.Tests/Operations/ReceiveConversionHandlerTests.cs +++ b/Sdk/Speckle.Connectors.Common.Tests/Operations/ReceiveConversionHandlerTests.cs @@ -38,7 +38,6 @@ public class ReceiveConversionHandlerTests Exception? result = handler.TryConvert(() => throw ex); result.Should().Be(ex); - activity.Verify(a => a.SetStatus(SdkActivityStatusCode.Error), Times.Once); } [Test] @@ -50,7 +49,6 @@ public class ReceiveConversionHandlerTests var handler = new ReceiveConversionHandler(activityFactory.Object); Assert.Throws(() => handler.TryConvert(() => throw new OperationCanceledException())); - activity.Verify(a => a.SetStatus(SdkActivityStatusCode.Error), Times.Once); } [Test]