From 0b136663e4e08076db96600bdaa700aa92bb78cd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Steinhagen?= Date: Tue, 20 May 2025 10:24:48 +0200 Subject: [PATCH] feat: direct shape name (#846) --- .../ToHost/Raw/LocalToGlobalToDirectShapeConverter.cs | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/Converters/Revit/Speckle.Converters.RevitShared/ToHost/Raw/LocalToGlobalToDirectShapeConverter.cs b/Converters/Revit/Speckle.Converters.RevitShared/ToHost/Raw/LocalToGlobalToDirectShapeConverter.cs index 6a09d5321..1c3962ed3 100644 --- a/Converters/Revit/Speckle.Converters.RevitShared/ToHost/Raw/LocalToGlobalToDirectShapeConverter.cs +++ b/Converters/Revit/Speckle.Converters.RevitShared/ToHost/Raw/LocalToGlobalToDirectShapeConverter.cs @@ -5,6 +5,7 @@ using Speckle.DoubleNumerics; using Speckle.Objects.Data; using Speckle.Sdk.Common; using Speckle.Sdk.Models; +using Speckle.Sdk.Models.Extensions; namespace Speckle.Converters.RevitShared.ToSpeckle; @@ -59,6 +60,15 @@ public class LocalToGlobalToDirectShapeConverter // 2 - init DirectShape var result = DB.DirectShape.CreateElement(_converterSettings.Current.Document, new DB.ElementId(dsCategory)); + // NOTE: this should technically be in a property extraction class / helper method + // This change is localised to [CNX-1825](https://linear.app/speckle/issue/CNX-1825/set-directshape-name) + // TODO: Property extraction is a greater conversation which needs to be had: [CNX-1830](https://linear.app/speckle/issue/CNX-1830/data-exchange-investigations) + var name = target.atomicObject.TryGetName(); + if (name is not null) + { + result.SetName(name); + } + // If there is no transforms to be applied, use the simple way of creating direct shapes if (target.matrix.Count == 0) {