84cb74e8b3
* each log line is a json object * structured logging allows logs to be ingested by machines and the logs to be indexed and queried addresses #1105 * structured logging allows arbitrary properties to be appended to each log line, and ingestion of logs to remain robust * Structured logging provided by `pino` library * Add `express-pino-logger` dependency * Remove `debug`, `morgan`, and `morgan-debug` and replace with structured logging * `console.log` & `console.error` replaced with structured logging in backend * Remove `DEBUG` environment variable and replace with `LOG_LEVEL` - Note that there is a test which reads from a logged line on `stdout`. This is not robust, it would be better to use the childProcess.pid to look up the port number. * Log errors at points we explicitly send error to Sentry * Amend indentation of a couple of log messages to align indentation with others
263 lines
8.0 KiB
JavaScript
263 lines
8.0 KiB
JavaScript
'use strict'
|
|
const zlib = require('zlib')
|
|
const cors = require('cors')
|
|
const Busboy = require('busboy')
|
|
|
|
const { contextMiddleware } = require('@/modules/shared')
|
|
const { validatePermissionsWriteStream } = require('./authUtils')
|
|
|
|
const { createObjectsBatched } = require('../services/objects')
|
|
const {
|
|
rejectsRequestWithRatelimitStatusIfNeeded
|
|
} = require('@/modules/core/services/ratelimits')
|
|
const { logger, uploadEndpointLogger } = require('@/logging/logging')
|
|
|
|
const MAX_FILE_SIZE = 50 * 1024 * 1024
|
|
|
|
module.exports = (app) => {
|
|
app.options('/objects/:streamId', cors())
|
|
|
|
app.post('/objects/:streamId', cors(), contextMiddleware, async (req, res) => {
|
|
const rejected = await rejectsRequestWithRatelimitStatusIfNeeded({
|
|
action: 'POST /objects/:streamId',
|
|
req,
|
|
res
|
|
})
|
|
if (rejected) return rejected
|
|
|
|
const hasStreamAccess = await validatePermissionsWriteStream(
|
|
req.params.streamId,
|
|
req
|
|
)
|
|
if (!hasStreamAccess.result) {
|
|
return res.status(hasStreamAccess.status).end()
|
|
}
|
|
|
|
const busboy = Busboy({ headers: req.headers })
|
|
let totalProcessed = 0
|
|
// let last = {}
|
|
|
|
const promises = []
|
|
let requestDropped = false
|
|
|
|
busboy.on('file', (name, file, info) => {
|
|
const { mimeType } = info
|
|
|
|
if (requestDropped) return
|
|
|
|
if (mimeType === 'application/gzip') {
|
|
const buffer = []
|
|
|
|
file.on('data', (data) => {
|
|
if (data) buffer.push(data)
|
|
})
|
|
|
|
file.on('end', async () => {
|
|
if (requestDropped) return
|
|
const t0 = Date.now()
|
|
let objs = []
|
|
|
|
const gzippedBuffer = Buffer.concat(buffer)
|
|
if (gzippedBuffer.length > MAX_FILE_SIZE) {
|
|
logger.error(
|
|
`[User ${
|
|
req.context.userId || '-'
|
|
}] Upload error: Batch size too large (${
|
|
gzippedBuffer.length
|
|
} > ${MAX_FILE_SIZE})`
|
|
)
|
|
if (!requestDropped)
|
|
res
|
|
.status(400)
|
|
.send(
|
|
`File size too large (${gzippedBuffer.length} > ${MAX_FILE_SIZE})`
|
|
)
|
|
requestDropped = true
|
|
}
|
|
|
|
const gunzippedBuffer = zlib.gunzipSync(gzippedBuffer).toString()
|
|
if (gunzippedBuffer.length > MAX_FILE_SIZE) {
|
|
logger.error(
|
|
`[User ${
|
|
req.context.userId || '-'
|
|
}] Upload error: Batch size too large (${
|
|
gunzippedBuffer.length
|
|
} > ${MAX_FILE_SIZE})`
|
|
)
|
|
if (!requestDropped)
|
|
res
|
|
.status(400)
|
|
.send(
|
|
`File size too large (${gunzippedBuffer.length} > ${MAX_FILE_SIZE})`
|
|
)
|
|
requestDropped = true
|
|
}
|
|
|
|
try {
|
|
objs = JSON.parse(gunzippedBuffer)
|
|
} catch (e) {
|
|
logger.error(
|
|
`[User ${
|
|
req.context.userId || '-'
|
|
}] Upload error: Batch not in JSON format`
|
|
)
|
|
if (!requestDropped) res.status(400).send('Failed to parse data.')
|
|
requestDropped = true
|
|
}
|
|
|
|
// last = objs[objs.length - 1]
|
|
totalProcessed += objs.length
|
|
|
|
let previouslyAwaitedPromises = 0
|
|
while (previouslyAwaitedPromises !== promises.length) {
|
|
previouslyAwaitedPromises = promises.length
|
|
await Promise.all(promises)
|
|
}
|
|
|
|
const promise = createObjectsBatched(req.params.streamId, objs).catch((e) => {
|
|
logger.error(
|
|
`[User ${req.context.userId || '-'}] Upload error: ${e.message}`
|
|
)
|
|
if (!requestDropped)
|
|
res
|
|
.status(400)
|
|
.send(
|
|
'Error inserting object in the database. Check server logs for details'
|
|
)
|
|
requestDropped = true
|
|
})
|
|
promises.push(promise)
|
|
|
|
await promise
|
|
|
|
logger.info(
|
|
`[User ${req.context.userId || '-'}] Uploaded batch of ${
|
|
objs.length
|
|
} objects to stream ${req.params.streamId} (size: ${
|
|
gunzippedBuffer.length / 1000000
|
|
} MB, duration: ${(Date.now() - t0) / 1000}s, crtMemUsage: ${
|
|
process.memoryUsage().heapUsed / 1024 / 1024
|
|
} MB, dropped=${requestDropped})`
|
|
)
|
|
})
|
|
} else if (
|
|
mimeType === 'text/plain' ||
|
|
mimeType === 'application/json' ||
|
|
mimeType === 'application/octet-stream'
|
|
) {
|
|
let buffer = ''
|
|
|
|
file.on('data', (data) => {
|
|
if (data) buffer += data
|
|
})
|
|
|
|
file.on('end', async () => {
|
|
if (requestDropped) return
|
|
const t0 = Date.now()
|
|
let objs = []
|
|
|
|
if (buffer.length > MAX_FILE_SIZE) {
|
|
logger.error(
|
|
`[User ${
|
|
req.context.userId || '-'
|
|
}] Upload error: Batch size too large (${
|
|
buffer.length
|
|
} > ${MAX_FILE_SIZE})`
|
|
)
|
|
if (!requestDropped)
|
|
res
|
|
.status(400)
|
|
.send(`File size too large (${buffer.length} > ${MAX_FILE_SIZE})`)
|
|
requestDropped = true
|
|
}
|
|
|
|
try {
|
|
objs = JSON.parse(buffer)
|
|
} catch (e) {
|
|
logger.error(
|
|
`[User ${
|
|
req.context.userId || '-'
|
|
}] Upload error: Batch not in JSON format`
|
|
)
|
|
if (!requestDropped) res.status(400).send('Failed to parse data.')
|
|
requestDropped = true
|
|
}
|
|
// last = objs[objs.length - 1]
|
|
totalProcessed += objs.length
|
|
|
|
let previouslyAwaitedPromises = 0
|
|
while (previouslyAwaitedPromises !== promises.length) {
|
|
previouslyAwaitedPromises = promises.length
|
|
await Promise.all(promises)
|
|
}
|
|
|
|
const promise = createObjectsBatched(req.params.streamId, objs).catch((e) => {
|
|
logger.error(
|
|
`[User ${req.context.userId || '-'}] Upload error: ${e.message}`
|
|
)
|
|
if (!requestDropped)
|
|
res
|
|
.status(400)
|
|
.send(
|
|
'Error inserting object in the database. Check server logs for details'
|
|
)
|
|
requestDropped = true
|
|
})
|
|
promises.push(promise)
|
|
|
|
await promise
|
|
logger.info(
|
|
`[User ${req.context.userId || '-'}] Uploaded batch of ${
|
|
objs.length
|
|
} objects to stream ${req.params.streamId} (size: ${
|
|
buffer.length / 1000000
|
|
} MB, duration: ${(Date.now() - t0) / 1000}s, crtMemUsage: ${
|
|
process.memoryUsage().heapUsed / 1024 / 1024
|
|
} MB, dropped=${requestDropped})`
|
|
)
|
|
})
|
|
} else {
|
|
logger.error(
|
|
`[User ${req.context.userId || '-'}] Invalid ContentType header: ${mimeType}`
|
|
)
|
|
if (!requestDropped)
|
|
res
|
|
.status(400)
|
|
.send(
|
|
'Invalid ContentType header. This route only accepts "application/gzip", "text/plain" or "application/json".'
|
|
)
|
|
requestDropped = true
|
|
}
|
|
})
|
|
|
|
busboy.on('finish', async () => {
|
|
if (requestDropped) return
|
|
|
|
uploadEndpointLogger.info(
|
|
`[User ${req.context.userId || '-'}] Upload finished: ${totalProcessed} objs, ${
|
|
process.memoryUsage().heapUsed / 1024 / 1024
|
|
} MB mem`
|
|
)
|
|
|
|
let previouslyAwaitedPromises = 0
|
|
while (previouslyAwaitedPromises !== promises.length) {
|
|
previouslyAwaitedPromises = promises.length
|
|
await Promise.all(promises)
|
|
}
|
|
|
|
res.status(201).end()
|
|
})
|
|
|
|
busboy.on('error', async (err) => {
|
|
uploadEndpointLogger.info(
|
|
`[User ${req.context.userId || '-'}] Upload error: ${err}`
|
|
)
|
|
if (!requestDropped)
|
|
res.status(400).end('Upload request error. The server logs have more details')
|
|
requestDropped = true
|
|
})
|
|
|
|
req.pipe(busboy)
|
|
})
|
|
}
|