From f227a9b91d0e024bcfea9a24dff21e8e735c5c6a Mon Sep 17 00:00:00 2001
From: Alessandro Magionami <alessandro.magionami@gmail.com>
Date: Mon, 2 Dec 2024 12:14:57 +0100
Subject: [PATCH] fix(activitystream): move activity creation after transaction
 commimt

---
 .../server/modules/core/services/streams/clone.ts | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/packages/server/modules/core/services/streams/clone.ts b/packages/server/modules/core/services/streams/clone.ts
index 5b5dc9b50..4060c4db8 100644
--- a/packages/server/modules/core/services/streams/clone.ts
+++ b/packages/server/modules/core/services/streams/clone.ts
@@ -521,19 +521,16 @@ export const cloneStreamFactory =
       const { newStream } = coreCloneResult
       // Clone comments
       await cloneStreamCommentsFactory(deps)(state, coreCloneResult)
-      // Create activity item
-      await deps.addStreamClonedActivity(
-        {
-          sourceStreamId,
-          newStream,
-          clonerId: userId
-        },
-        { trx: state.trx }
-      )
 
       // Commit transaction
       await state.trx.commit()
 
+      // Create activity item
+      await deps.addStreamClonedActivity({
+        sourceStreamId,
+        newStream,
+        clonerId: userId
+      })
       return coreCloneResult.newStream
     } catch (e) {
       await state.trx.rollback()