From e6bde7aab3e9ec77cf6f51eefbd4fd471d5554fb Mon Sep 17 00:00:00 2001 From: andrewwallacespeckle <139135120+andrewwallacespeckle@users.noreply.github.com> Date: Wed, 5 Jun 2024 12:49:30 +0200 Subject: [PATCH] fix(fe2): Uncomment code around model duplication (#2257) * Uncomment code around model duplication * Update comment around deduplication --- packages/frontend-2/lib/viewer/composables/setup.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/frontend-2/lib/viewer/composables/setup.ts b/packages/frontend-2/lib/viewer/composables/setup.ts index a88a39013..453b7be22 100644 --- a/packages/frontend-2/lib/viewer/composables/setup.ts +++ b/packages/frontend-2/lib/viewer/composables/setup.ts @@ -616,8 +616,9 @@ function setupResponseResourceItems( const modelId = item.modelId const objectId = item.objectId - // In case we want to go back to 1 resource per model: - // if (modelId && encounteredModels.has(modelId)) continue + // Uncommenting the following line resolved model duplication issues in the Model Panel + // without affecting diffing functionality. If future diffing problems arise, revisit this. + if (modelId && encounteredModels.has(modelId)) continue if (encounteredObjects.has(objectId)) continue finalItems.push(item)