huanld/speckle-server
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix(viewer-lib): Added relative epsilon to section outlines. Added constant epsilon to setting orbit controls position and target (#4781)

Browse Source
This commit is contained in:
Alexandru Popovici
2025-05-22 09:43:00 +03:00
committed by GitHub
parent 3b08570f57
commit daefbbf2a3
3 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/viewer/src/modules/extensions/controls/SmoothOrbitControls.ts
+5 -1
View File
@@ -316,7 +316,11 @@ export class SmoothOrbitControls extends SpeckleControls {
*/
const targetPosition = this.getPosition()
const targetTarget = this.getTarget()
if (position.equals(targetPosition) && target.equals(targetTarget)) return
const deltaTarget = vector3.subVectors(target, targetTarget).length()
const deltaPosition = vector3.subVectors(position, targetPosition).length()
const epsilon = 1e-7
if (deltaPosition < epsilon) return
if (deltaTarget < epsilon) return
const v0 = new Vector3().copy(position)
const v1 = new Vector3().copy(target)
packages/viewer/src/modules/extensions/sections/SectionOutlines.ts
+3 -2
View File
@@ -356,12 +356,13 @@ export class SectionOutlines extends Extension {
private setSectionPlaneChanged(planes: Plane[]) {
this.sectionPlanesChanged.length = 0
const epsilon = this.viewer.World.getRelativeOffset(0.0001)
for (let k = 0; k < planes.length; k++) {
if (
Math.abs(this.lastSectionPlanes[k].constant - planes[k].constant) > 0.0001 ||
Math.abs(this.lastSectionPlanes[k].constant - planes[k].constant) > epsilon ||
Math.abs(
this.lastSectionPlanes[k].normal.length() - planes[k].normal.length()
) > 0.0001
) > epsilon
)
this.sectionPlanesChanged.push(planes[k])
this.lastSectionPlanes[k].copy(planes[k])