From d24e95c046391cea51ea2f76a17151cb0bdf7c4c Mon Sep 17 00:00:00 2001
From: Dimitrie Stefanescu <didimitrie@gmail.com>
Date: Wed, 19 Jun 2024 15:22:54 +0100
Subject: [PATCH] fix(objects): wip fix on getObjectChildren in post closure
 world

---
 .../server/modules/core/services/objects.js   | 30 +++++++++++++++----
 1 file changed, 24 insertions(+), 6 deletions(-)

diff --git a/packages/server/modules/core/services/objects.js b/packages/server/modules/core/services/objects.js
index e664f0272..05fa8bfd0 100644
--- a/packages/server/modules/core/services/objects.js
+++ b/packages/server/modules/core/services/objects.js
@@ -282,12 +282,23 @@ module.exports = {
     depth = parseInt(depth) || 1000
 
     let fullObjectSelect = false
+    // TODO
+    // const q = Closures()
+    // q.select('id')
+    // q.select('createdAt')
+    // q.select('speckleType')
+    // q.select('totalChildrenCount')
 
-    const q = Closures()
-    q.select('id')
-    q.select('createdAt')
-    q.select('speckleType')
-    q.select('totalChildrenCount')
+    const q = knex.with(
+      'object_children_closure',
+      knex.raw(
+        `SELECT objects.id as parent, d.key as child, d.value as minDepth, ? as "streamId"
+        FROM objects
+        JOIN jsonb_each_text(objects.data->'__closure') d ON true
+        where objects.id = ?`,
+        [streamId, objectId]
+      )
+    )
 
     if (Array.isArray(select)) {
       select.forEach((field, index) => {
@@ -303,6 +314,13 @@ module.exports = {
       q.select('data')
     }
 
+    q.select('id')
+    q.select('createdAt')
+    q.select('speckleType')
+    q.select('totalChildrenCount')
+
+    q.from('object_children_closure')
+
     q.rightJoin('objects', function () {
       this.on('objects.streamId', '=', 'object_children_closure.streamId').andOn(
         'objects.id',
@@ -316,7 +334,7 @@ module.exports = {
           objectId
         ])
       )
-      .andWhere(knex.raw('"minDepth" < ?', [depth]))
+      .andWhere(knex.raw('object_children_closure."mindepth" < ?', [depth]))
       .andWhere(knex.raw('id > ?', [cursor ? cursor : '0']))
       .orderBy('objects.id')
       .limit(limit)