From c29b4f2aac83e8a0e12ab9027e6d91f19c8aeca9 Mon Sep 17 00:00:00 2001 From: Benjamin Ottensten Date: Mon, 10 Jun 2024 15:43:00 +0200 Subject: [PATCH] Fix automation creation form (#2349) Bug: You couldn't proceed from step 2 if the function didn't have any parameters. --- .../components/automate/automation/CreateDialog.vue | 4 ++-- packages/frontend-2/lib/automate/composables/jsonSchema.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/frontend-2/components/automate/automation/CreateDialog.vue b/packages/frontend-2/components/automate/automation/CreateDialog.vue index b7c18c8ad..74e998da0 100644 --- a/packages/frontend-2/components/automate/automation/CreateDialog.vue +++ b/packages/frontend-2/components/automate/automation/CreateDialog.vue @@ -481,8 +481,8 @@ const onDialogSubmit = async (e: SubmitEvent) => { if (enumStep.value === AutomationCreateSteps.AutomationDetails) { await onDetailsSubmit(e) } else if (enumStep.value === AutomationCreateSteps.FunctionParameters) { - const validationResult = await parametersStep.value?.submit() - if (validationResult && !hasJsonFormErrors(validationResult)) { + const validationResult = (await parametersStep.value?.submit()) || {} + if (!hasJsonFormErrors(validationResult)) { step.value++ } } diff --git a/packages/frontend-2/lib/automate/composables/jsonSchema.ts b/packages/frontend-2/lib/automate/composables/jsonSchema.ts index a0d69f3b9..3c7bf8422 100644 --- a/packages/frontend-2/lib/automate/composables/jsonSchema.ts +++ b/packages/frontend-2/lib/automate/composables/jsonSchema.ts @@ -4,7 +4,7 @@ import type { MaybeNullOrUndefined } from '@speckle/shared' import { formatJsonFormSchemaInputs } from '~/lib/automate/helpers/jsonSchema' export const hasJsonFormErrors = (event: JsonFormsChangeEvent) => - (event.errors?.length || 0) > 0 + event?.errors?.length > 0 export const useJsonFormsChangeHandler = (params: { schema: MaybeRef>