From bce270489aca32f4c02f572d901cb87f7dabc557 Mon Sep 17 00:00:00 2001 From: AlexandruPopovici Date: Fri, 28 Jun 2024 12:58:32 +0300 Subject: [PATCH 1/3] Fixed sandbox lint error --- packages/viewer-sandbox/src/main.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/viewer-sandbox/src/main.ts b/packages/viewer-sandbox/src/main.ts index ec09dfa79..5e8d7e05b 100644 --- a/packages/viewer-sandbox/src/main.ts +++ b/packages/viewer-sandbox/src/main.ts @@ -17,7 +17,6 @@ import { } from '@speckle/viewer' import { SectionTool } from '@speckle/viewer' import { SectionOutlines } from '@speckle/viewer' -import { CameraPlanes } from './Extensions/CameraPlanes' const createViewer = async (containerName: string, stream: string) => { const container = document.querySelector(containerName) From a5e77d8d36fbc94b2f4d751fe767571aa51c70b7 Mon Sep 17 00:00:00 2001 From: AlexandruPopovici Date: Fri, 5 Jul 2024 13:18:25 +0300 Subject: [PATCH 2/3] Added sRGB->linear vertex color conversion in the geometry converter. Not all connectors may send their vertex colors in sRGB but this is what we agreed we're going to treat vertex color space for now --- packages/viewer-sandbox/src/main.ts | 4 +++- .../src/modules/loaders/Speckle/SpeckleGeometryConverter.ts | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/viewer-sandbox/src/main.ts b/packages/viewer-sandbox/src/main.ts index fff2800f6..d8ee1054f 100644 --- a/packages/viewer-sandbox/src/main.ts +++ b/packages/viewer-sandbox/src/main.ts @@ -105,7 +105,7 @@ const getStream = () => { // prettier-ignore // 'https://speckle.xyz/streams/da9e320dad/commits/5388ef24b8?c=%5B-7.66134,10.82932,6.41935,-0.07739,-13.88552,1.8697,0,1%5D' // Revit sample house (good for bim-like stuff with many display meshes) - 'https://speckle.xyz/streams/da9e320dad/commits/5388ef24b8' + // 'https://speckle.xyz/streams/da9e320dad/commits/5388ef24b8' // 'https://latest.speckle.dev/streams/c1faab5c62/commits/ab1a1ab2b6' // 'https://speckle.xyz/streams/da9e320dad/commits/5388ef24b8' // 'https://latest.speckle.dev/streams/58b5648c4d/commits/60371ecb2d' @@ -388,6 +388,8 @@ const getStream = () => { // 'https://app.speckle.systems/projects/122448a81e/models/f21aff1f4a' // Thin plane // 'https://app.speckle.systems/projects/20f72acc58/models/2cf8a736f8' + // Rhino sRGB vertex colors + 'https://app.speckle.systems/projects/47bbaf594f/models/ef78e94f72' ) } diff --git a/packages/viewer/src/modules/loaders/Speckle/SpeckleGeometryConverter.ts b/packages/viewer/src/modules/loaders/Speckle/SpeckleGeometryConverter.ts index 82efd25ba..20b233a2a 100644 --- a/packages/viewer/src/modules/loaders/Speckle/SpeckleGeometryConverter.ts +++ b/packages/viewer/src/modules/loaders/Speckle/SpeckleGeometryConverter.ts @@ -268,7 +268,7 @@ export class SpeckleGeometryConverter extends GeometryConverter { `Mesh (id ${node.raw.id}) colours are mismatched with vertice counts. The number of colours must equal the number of vertices.` ) } - colors = this.unpackColors(colorsRaw) + colors = this.unpackColors(colorsRaw, true) } return { From 45c356eda90e6e6d1395bbd31c2b2ba17c96a950 Mon Sep 17 00:00:00 2001 From: AlexandruPopovici Date: Thu, 11 Jul 2024 20:28:42 +0300 Subject: [PATCH 3/3] qGIS test stream --- packages/viewer-sandbox/src/main.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/viewer-sandbox/src/main.ts b/packages/viewer-sandbox/src/main.ts index d8ee1054f..07f8b15e7 100644 --- a/packages/viewer-sandbox/src/main.ts +++ b/packages/viewer-sandbox/src/main.ts @@ -389,7 +389,9 @@ const getStream = () => { // Thin plane // 'https://app.speckle.systems/projects/20f72acc58/models/2cf8a736f8' // Rhino sRGB vertex colors - 'https://app.speckle.systems/projects/47bbaf594f/models/ef78e94f72' + // 'https://app.speckle.systems/projects/47bbaf594f/models/ef78e94f72' + // qGIS sRGB vertex colors + 'https://latest.speckle.systems/projects/5a6609a4b9/models/10f4931e8c' ) }