From ae1e4285b064a7ec809631124e1eaeb87b843733 Mon Sep 17 00:00:00 2001 From: Kristaps Fabians Geikins Date: Fri, 18 Oct 2024 15:43:07 +0300 Subject: [PATCH] add comment w/ gergos concerns --- packages/server/modules/core/domain/objects/types.ts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/packages/server/modules/core/domain/objects/types.ts b/packages/server/modules/core/domain/objects/types.ts index 7ec24e36b..1deff371c 100644 --- a/packages/server/modules/core/domain/objects/types.ts +++ b/packages/server/modules/core/domain/objects/types.ts @@ -6,6 +6,11 @@ export type SpeckleObjectClosureEntry = ObjectChildrenClosureRecord export type SpeckleObject = ObjectRecord +/** + * TODO: The types are a bit too lax right now, we don't really want to allow missing id, speckle_type, __closure props, so we should revisit + * the code in the future and make the necessary changes to ensure that these props are always present + */ + /** * We preemptively serialize a couple of fields (usually knex does it) */