From 96fded5e52f2e4e56f3ba4cdd6017150aacb99b5 Mon Sep 17 00:00:00 2001 From: Fabians Date: Fri, 1 Apr 2022 18:24:51 +0300 Subject: [PATCH] Fixed all ESLint issues in frontend --- packages/frontend/.eslintrc.js | 5 +- packages/frontend/src/embed/EmbedApp.vue | 2 + packages/frontend/src/embed/EmbedViewer.vue | 6 +- .../components/activity/ListItemActivity.vue | 19 +- .../main/components/admin/UserListItem.vue | 2 +- .../{Strategies.vue => AuthStrategies.vue} | 21 +- .../auth/{Blurb.vue => LoginBlurb.vue} | 5 +- .../main/components/common/GlobalToast.vue | 2 +- .../common/{Viewer.vue => SpeckleViewer.vue} | 1 + .../components/common/StreamPreviewCard.vue | 8 +- .../feed/{Timeline.vue => FeedTimeline.vue} | 5 +- .../main/components/feed/LatestBlogposts.vue | 7 +- .../main/components/feed/ListItemActivity.vue | 616 ------------------ .../components/feed/ListItemActivity2.vue | 616 ------------------ .../{Activity.vue => StreamActivity.vue} | 2 +- .../main/components/stream/WebhookForm.vue | 2 +- .../stream/uploads/FileUploadItem.vue | 11 +- .../user/EmailVerificationBanner.vue | 7 +- .../main/components/viewer/CanonicalViews.vue | 4 +- .../components/viewer/CommentAddOverlay.vue | 2 + .../components/viewer/CommentsOverlay.vue | 2 + .../components/viewer/CommitInfoResource.vue | 7 +- .../components/viewer/ObjectInfoResource.vue | 7 +- .../components/viewer/ObjectProperties.vue | 11 +- .../components/viewer/ObjectPropertiesRow.vue | 19 +- .../viewer/{Bubbles.vue => ViewerBubbles.vue} | 18 +- .../viewer/{Filters.vue => ViewerFilters.vue} | 1 + .../components/viewer/dialogs/AllCommits.vue | 7 +- .../viewer/dialogs/AllCommitsBranch.vue | 11 +- ...AddOverlay.vue => StreamOverlayViewer.vue} | 9 +- .../src/main/dialogs/BranchEditDialog.vue | 11 +- .../frontend/src/main/dialogs/CommitEdit.vue | 7 +- ...{ShareStream.vue => ShareStreamDialog.vue} | 42 +- .../src/main/dialogs/UserDeleteDialog.vue | 2 +- .../main/layouts/{Auth.vue => TheAuth.vue} | 9 +- .../frontend/src/main/layouts/TheMain.vue | 1 + .../src/main/navigation/StreamNav.vue | 12 +- .../pages/{Commits.vue => TheCommits.vue} | 1 + .../src/main/pages/{Feed.vue => TheFeed.vue} | 7 +- .../pages/auth/{Login.vue => TheLogin.vue} | 8 +- .../{Registration.vue => TheRegistration.vue} | 8 +- .../pages/common/{Error.vue => TheError.vue} | 4 +- .../{Onboarding.vue => TheOnboarding.vue} | 1 + .../main/pages/stream/CommitObjectViewer.vue | 17 +- .../stream/{Activity.vue => TheActivity.vue} | 3 +- .../stream/{Branch.vue => TheBranch.vue} | 6 +- ...Collaborators.vue => TheCollaborators.vue} | 1 + .../stream/{Comments.vue => TheComments.vue} | 2 +- .../stream/{Globals.vue => TheGlobals.vue} | 4 +- .../stream/{Settings.vue => TheSettings.vue} | 2 +- .../src/main/pages/stream/TheStream.vue | 3 +- .../{StreamHome.vue => TheStreamHome.vue} | 7 +- .../stream/{Uploads.vue => TheUploads.vue} | 2 +- .../stream/{Webhooks.vue => TheWebhooks.vue} | 4 +- .../{ProfileSelf.vue => TheProfileSelf.vue} | 2 +- .../user/{Profile.vue => TheProfileUser.vue} | 2 +- packages/frontend/src/main/router/index.js | 36 +- .../src/main/toolbars/BranchToolbar.vue | 7 +- .../src/main/toolbars/CommitToolbar.vue | 7 +- .../toolbars/MultipleResourcesToolbar.vue | 11 +- .../src/main/toolbars/ObjectToolbar.vue | 7 +- .../src/main/toolbars/StreamToolbar.vue | 8 +- workspace.code-workspace | 1 - 63 files changed, 306 insertions(+), 1374 deletions(-) rename packages/frontend/src/main/components/auth/{Strategies.vue => AuthStrategies.vue} (81%) rename packages/frontend/src/main/components/auth/{Blurb.vue => LoginBlurb.vue} (94%) rename packages/frontend/src/main/components/common/{Viewer.vue => SpeckleViewer.vue} (99%) rename packages/frontend/src/main/components/feed/{Timeline.vue => FeedTimeline.vue} (99%) delete mode 100644 packages/frontend/src/main/components/feed/ListItemActivity.vue delete mode 100644 packages/frontend/src/main/components/feed/ListItemActivity2.vue rename packages/frontend/src/main/components/stream/{Activity.vue => StreamActivity.vue} (99%) rename packages/frontend/src/main/components/viewer/{Bubbles.vue => ViewerBubbles.vue} (97%) rename packages/frontend/src/main/components/viewer/{Filters.vue => ViewerFilters.vue} (99%) rename packages/frontend/src/main/components/viewer/dialogs/{AddOverlay.vue => StreamOverlayViewer.vue} (97%) rename packages/frontend/src/main/dialogs/{ShareStream.vue => ShareStreamDialog.vue} (88%) rename packages/frontend/src/main/layouts/{Auth.vue => TheAuth.vue} (81%) rename packages/frontend/src/main/pages/{Commits.vue => TheCommits.vue} (99%) rename packages/frontend/src/main/pages/{Feed.vue => TheFeed.vue} (69%) rename packages/frontend/src/main/pages/auth/{Login.vue => TheLogin.vue} (97%) rename packages/frontend/src/main/pages/auth/{Registration.vue => TheRegistration.vue} (98%) rename packages/frontend/src/main/pages/common/{Error.vue => TheError.vue} (98%) rename packages/frontend/src/main/pages/onboarding/{Onboarding.vue => TheOnboarding.vue} (97%) rename packages/frontend/src/main/pages/stream/{Activity.vue => TheActivity.vue} (98%) rename packages/frontend/src/main/pages/stream/{Branch.vue => TheBranch.vue} (96%) rename packages/frontend/src/main/pages/stream/{Collaborators.vue => TheCollaborators.vue} (99%) rename packages/frontend/src/main/pages/stream/{Comments.vue => TheComments.vue} (99%) rename packages/frontend/src/main/pages/stream/{Globals.vue => TheGlobals.vue} (98%) rename packages/frontend/src/main/pages/stream/{Settings.vue => TheSettings.vue} (99%) rename packages/frontend/src/main/pages/stream/{StreamHome.vue => TheStreamHome.vue} (95%) rename packages/frontend/src/main/pages/stream/{Uploads.vue => TheUploads.vue} (99%) rename packages/frontend/src/main/pages/stream/{Webhooks.vue => TheWebhooks.vue} (99%) rename packages/frontend/src/main/pages/user/{ProfileSelf.vue => TheProfileSelf.vue} (99%) rename packages/frontend/src/main/pages/user/{Profile.vue => TheProfileUser.vue} (99%) diff --git a/packages/frontend/.eslintrc.js b/packages/frontend/.eslintrc.js index b220ffd5d..a0ef7df00 100644 --- a/packages/frontend/.eslintrc.js +++ b/packages/frontend/.eslintrc.js @@ -27,10 +27,7 @@ const config = { } } ], - plugins: ['vue'], - rules: { - 'no-console': 1 - } + plugins: ['vue'] } module.exports = config diff --git a/packages/frontend/src/embed/EmbedApp.vue b/packages/frontend/src/embed/EmbedApp.vue index 514f50bd6..4f5432249 100644 --- a/packages/frontend/src/embed/EmbedApp.vue +++ b/packages/frontend/src/embed/EmbedApp.vue @@ -7,6 +7,8 @@ export default { mounted() { let mixpanelId = this.$mixpanelId() this.$mixpanel.register({ + // Unfortunately we can't replace this to camelCase, because that will break metrics + // eslint-disable-next-line camelcase server_id: this.$mixpanelServerId(), hostApp: 'web-embed' }) diff --git a/packages/frontend/src/embed/EmbedViewer.vue b/packages/frontend/src/embed/EmbedViewer.vue index f0cb49664..bce329e45 100644 --- a/packages/frontend/src/embed/EmbedViewer.vue +++ b/packages/frontend/src/embed/EmbedViewer.vue @@ -58,19 +58,19 @@
- +
- - diff --git a/packages/frontend/src/main/components/feed/ListItemActivity2.vue b/packages/frontend/src/main/components/feed/ListItemActivity2.vue deleted file mode 100644 index de0d70cec..000000000 --- a/packages/frontend/src/main/components/feed/ListItemActivity2.vue +++ /dev/null @@ -1,616 +0,0 @@ - - - - - diff --git a/packages/frontend/src/main/components/stream/Activity.vue b/packages/frontend/src/main/components/stream/StreamActivity.vue similarity index 99% rename from packages/frontend/src/main/components/stream/Activity.vue rename to packages/frontend/src/main/components/stream/StreamActivity.vue index a11f560f4..7e48fdf63 100644 --- a/packages/frontend/src/main/components/stream/Activity.vue +++ b/packages/frontend/src/main/components/stream/StreamActivity.vue @@ -40,7 +40,7 @@ import gql from 'graphql-tag' export default { - name: 'Activity', + name: 'StreamActivity', components: { ListItemActivity: () => import('@/main/components/activity/ListItemActivity'), InfiniteLoading: () => import('vue-infinite-loading') diff --git a/packages/frontend/src/main/components/stream/WebhookForm.vue b/packages/frontend/src/main/components/stream/WebhookForm.vue index a7057991a..4794ca4bc 100644 --- a/packages/frontend/src/main/components/stream/WebhookForm.vue +++ b/packages/frontend/src/main/components/stream/WebhookForm.vue @@ -197,7 +197,7 @@ export default { this.$matomo && this.$matomo.trackPageView('stream/webhook/create') this.$mixpanel.track('Webhook Action', { type: 'action', name: 'create' }) - let res = await this.$apollo.mutate({ + await this.$apollo.mutate({ mutation: gql` mutation webhookCreate($params: WebhookCreateInput!) { webhookCreate(webhook: $params) diff --git a/packages/frontend/src/main/components/stream/uploads/FileUploadItem.vue b/packages/frontend/src/main/components/stream/uploads/FileUploadItem.vue index 55f6cf06c..346fda6a9 100644 --- a/packages/frontend/src/main/components/stream/uploads/FileUploadItem.vue +++ b/packages/frontend/src/main/components/stream/uploads/FileUploadItem.vue @@ -41,7 +41,16 @@ diff --git a/packages/frontend/src/main/components/viewer/Filters.vue b/packages/frontend/src/main/components/viewer/ViewerFilters.vue similarity index 99% rename from packages/frontend/src/main/components/viewer/Filters.vue rename to packages/frontend/src/main/components/viewer/ViewerFilters.vue index 59f84bc7d..2417805eb 100644 --- a/packages/frontend/src/main/components/viewer/Filters.vue +++ b/packages/frontend/src/main/components/viewer/ViewerFilters.vue @@ -87,6 +87,7 @@