From 8aadfc9be9a6a857e86d1b13b98113d4eee43ddb Mon Sep 17 00:00:00 2001 From: Alexandru Popovici Date: Tue, 14 Jan 2025 12:52:26 +0200 Subject: [PATCH] fix(viewer-lib): Fixed an issue where mismatched vertex color counts were still attempted to batch together resulting in errors. (#3809) Now if the number of vertex colors does not match the number of vertices we just ignore colors alltogether --- packages/viewer-sandbox/src/main.ts | 4 +++- .../src/modules/loaders/Speckle/SpeckleGeometryConverter.ts | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/viewer-sandbox/src/main.ts b/packages/viewer-sandbox/src/main.ts index a936e51d9..164e09f3e 100644 --- a/packages/viewer-sandbox/src/main.ts +++ b/packages/viewer-sandbox/src/main.ts @@ -459,12 +459,14 @@ const getStream = () => { // 'https://speckle.xyz/streams/27e89d0ad6/commits/5ed4b74252' //Gingerbread - 'https://latest.speckle.systems/projects/387050bffe/models/48f7eb26fb' + // 'https://latest.speckle.systems/projects/387050bffe/models/48f7eb26fb' // DUI3 Mesh Colors // 'https://app.speckle.systems/projects/93200a735d/models/cbacd3eaeb@344a397239' // Instance toilets // 'https://app.speckle.systems/projects/e89b61b65c/models/2a0995f124' + + 'https://latest.speckle.systems/projects/3fe1880c36/models/65bb4287a8' ) } diff --git a/packages/viewer/src/modules/loaders/Speckle/SpeckleGeometryConverter.ts b/packages/viewer/src/modules/loaders/Speckle/SpeckleGeometryConverter.ts index 64db0e596..866f32ffd 100644 --- a/packages/viewer/src/modules/loaders/Speckle/SpeckleGeometryConverter.ts +++ b/packages/viewer/src/modules/loaders/Speckle/SpeckleGeometryConverter.ts @@ -286,9 +286,9 @@ export class SpeckleGeometryConverter extends GeometryConverter { Logger.warn( `Mesh (id ${node.raw.id}) colours are mismatched with vertice counts. The number of colours must equal the number of vertices.` ) - } + } else /** We want the colors in linear space */ - colors = this.unpackColors(colorsRaw, true) + colors = this.unpackColors(colorsRaw, true) } return {