From e8cff954394fb39cfa63e2f5ae5bbb3c94475405 Mon Sep 17 00:00:00 2001 From: Dimitrie Stefanescu Date: Fri, 28 Jan 2022 10:35:23 +0000 Subject: [PATCH 1/7] fix(frontend): null checks properly subscription event --- packages/frontend/src/cleanup/Main.vue | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/frontend/src/cleanup/Main.vue b/packages/frontend/src/cleanup/Main.vue index 579e73f65..7553e74e3 100644 --- a/packages/frontend/src/cleanup/Main.vue +++ b/packages/frontend/src/cleanup/Main.vue @@ -101,8 +101,7 @@ export default { } `, result({ data }) { - console.log(data) - if (!data) return + if (!data || !data.userStreamAdded) return if (this.$route.params.streamId === data.userStreamAdded.id) return this.$eventHub.$emit('notification', { text: `You've got a new stream!`, From 1409827bb7eb99f9867f48a3c125c8a281fba213 Mon Sep 17 00:00:00 2001 From: Dimitrie Stefanescu Date: Fri, 28 Jan 2022 10:50:37 +0000 Subject: [PATCH 2/7] fix(frontend): minor layout bug in xl view on stream home --- .../cleanup/pages/stream/CommitObjectViewer.vue | 3 --- .../src/cleanup/pages/stream/StreamHome.vue | 17 ++++++----------- 2 files changed, 6 insertions(+), 14 deletions(-) diff --git a/packages/frontend/src/cleanup/pages/stream/CommitObjectViewer.vue b/packages/frontend/src/cleanup/pages/stream/CommitObjectViewer.vue index 93e87f3c0..8a051f87e 100644 --- a/packages/frontend/src/cleanup/pages/stream/CommitObjectViewer.vue +++ b/packages/frontend/src/cleanup/pages/stream/CommitObjectViewer.vue @@ -331,7 +331,6 @@ export default { if (!val && this.filterToSet) { setTimeout(() => { this.$store.commit('setFilterDirect', { filter: this.filterToSet }) - // window.__viewer.applyFilter(this.filterToSet) this.filterToSet = null }, 200) } @@ -358,7 +357,6 @@ export default { window.__viewer.cameraHandler.activeCam.name === 'ortho' ? 1 : 0, controls._zoom ] - console.log(c) let fullQuery = { ...this.$route.query } delete fullQuery.c this.$router @@ -369,7 +367,6 @@ export default { .catch(() => {}) }, 1000) ) - // TODO: check query params for filter and camera pos and set them }, 300) }, methods: { diff --git a/packages/frontend/src/cleanup/pages/stream/StreamHome.vue b/packages/frontend/src/cleanup/pages/stream/StreamHome.vue index 8b58d49e5..2fb86676f 100644 --- a/packages/frontend/src/cleanup/pages/stream/StreamHome.vue +++ b/packages/frontend/src/cleanup/pages/stream/StreamHome.vue @@ -4,7 +4,7 @@ @@ -37,7 +37,7 @@ cols="12" sm="4" md="4" - :xl="loggedIn ? 12 : 4" + xl="12" > - - @@ -74,7 +69,7 @@ Recent activity log -
+
From 7855fa793287a0b6c9d452f4e659d18cfbbad6de Mon Sep 17 00:00:00 2001 From: Dimitrie Stefanescu Date: Sat, 29 Jan 2022 11:45:33 +0000 Subject: [PATCH 3/7] fix(frontend): refreshes branches on delete/edit (re #553) --- packages/frontend/src/cleanup/dialogs/BranchEditDialog.vue | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/frontend/src/cleanup/dialogs/BranchEditDialog.vue b/packages/frontend/src/cleanup/dialogs/BranchEditDialog.vue index 39661ba24..505a0c373 100644 --- a/packages/frontend/src/cleanup/dialogs/BranchEditDialog.vue +++ b/packages/frontend/src/cleanup/dialogs/BranchEditDialog.vue @@ -162,6 +162,7 @@ export default { this.showDelete = false this.$eventHub.$emit('notification', { text: 'Branch deleted' }) this.$router.push(`/streams/` + this.$route.params.streamId) + this.$eventHub.$emit('branch-refresh') }, async updateBranch() { if (!this.$refs.form.validate()) return From 00014a268017a6dd5481964973aaded5f87eff51 Mon Sep 17 00:00:00 2001 From: Dimitrie Stefanescu Date: Sat, 29 Jan 2022 13:23:24 +0000 Subject: [PATCH 4/7] fix(frontend): improves readability & clickability of object explorer cc @clairekuang & @izzylys --- .../src/cleanup/components/common/Viewer.vue | 19 +++++++++- .../components/viewer/ObjectProperties.vue | 4 +- .../components/viewer/ObjectPropertiesRow.vue | 38 +++++++++++++------ .../cleanup/components/viewer/Resource.vue | 6 +-- .../components/viewer/ResourceGroup.vue | 4 +- 5 files changed, 51 insertions(+), 20 deletions(-) diff --git a/packages/frontend/src/cleanup/components/common/Viewer.vue b/packages/frontend/src/cleanup/components/common/Viewer.vue index 856d5b1e2..5be30b647 100644 --- a/packages/frontend/src/cleanup/components/common/Viewer.vue +++ b/packages/frontend/src/cleanup/components/common/Viewer.vue @@ -1,6 +1,10 @@ diff --git a/packages/frontend/src/cleanup/components/viewer/ResourceGroup.vue b/packages/frontend/src/cleanup/components/viewer/ResourceGroup.vue index 8879811a4..6d6cd40af 100644 --- a/packages/frontend/src/cleanup/components/viewer/ResourceGroup.vue +++ b/packages/frontend/src/cleanup/components/viewer/ResourceGroup.vue @@ -1,6 +1,6 @@