From 0265121233553fdf3e4a2b121e3fe7d7a5816f35 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gerg=C5=91=20Jedlicska?= Date: Wed, 8 Sep 2021 12:10:18 +0200 Subject: [PATCH 1/7] fix((frontend) registration and password reset): add html tags to user and pass fields Fix password managers autocomplete based on this: https://web.dev/sign-in-form-best-practices/ fix #383 --- packages/frontend/src/views/auth/Registration.vue | 8 ++++++++ .../frontend/src/views/auth/ResetPasswordFinalization.vue | 2 ++ 2 files changed, 10 insertions(+) diff --git a/packages/frontend/src/views/auth/Registration.vue b/packages/frontend/src/views/auth/Registration.vue index 8931a3be3..51a213f5e 100644 --- a/packages/frontend/src/views/auth/Registration.vue +++ b/packages/frontend/src/views/auth/Registration.vue @@ -47,6 +47,10 @@ filled single-line prepend-icon="mdi-email" + id="email" + name="email" + type="email" + autocomplete="username" /> @@ -76,6 +80,8 @@ v-model="form.password" label="password" type="password" + autocomplete="new-password" + id="new-password" :rules="validation.passwordRules" filled single-line @@ -89,6 +95,8 @@ v-model="form.passwordConf" label="confirm password" type="password" + autocomplete="new-password" + id="confirm-password" :rules="validation.passwordRules" filled single-line diff --git a/packages/frontend/src/views/auth/ResetPasswordFinalization.vue b/packages/frontend/src/views/auth/ResetPasswordFinalization.vue index 65e27c740..111dcedd5 100644 --- a/packages/frontend/src/views/auth/ResetPasswordFinalization.vue +++ b/packages/frontend/src/views/auth/ResetPasswordFinalization.vue @@ -22,6 +22,8 @@ v-model="form.password" label="new password" type="password" + autocomplete="new-password" + id="new-password" :rules="validation.passwordRules" filled single-line From 96177096395f07e88f4f92764ef2720772b74c3b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gerg=C5=91=20Jedlicska?= Date: Wed, 8 Sep 2021 12:23:57 +0200 Subject: [PATCH 2/7] chore(gitignore): add asdf tool manager file to gitignore --- .tool-versions | 1 + 1 file changed, 1 insertion(+) create mode 100644 .tool-versions diff --git a/.tool-versions b/.tool-versions new file mode 100644 index 000000000..2d8169e51 --- /dev/null +++ b/.tool-versions @@ -0,0 +1 @@ +nodejs 14.17.6 From 44dc7962ca6795af0f2fd9ecfe69bb356f637aad Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gerg=C5=91=20Jedlicska?= Date: Wed, 8 Sep 2021 12:29:57 +0200 Subject: [PATCH 3/7] revert(tool-versions): this is exactly what i wanted to ignore --- .tool-versions | 1 - 1 file changed, 1 deletion(-) delete mode 100644 .tool-versions diff --git a/.tool-versions b/.tool-versions deleted file mode 100644 index 2d8169e51..000000000 --- a/.tool-versions +++ /dev/null @@ -1 +0,0 @@ -nodejs 14.17.6 From 7a2fce2d8aa98dc503057a49e84f370aaa6b9dbf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gerg=C5=91=20Jedlicska?= Date: Wed, 8 Sep 2021 12:32:03 +0200 Subject: [PATCH 4/7] chore(gitignore): ignore asdf tool-versions convig file --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 18d721afd..33bb34976 100644 --- a/.gitignore +++ b/.gitignore @@ -16,3 +16,4 @@ test-queries packages/viewer/example/*.js packages/viewer/example/*.js.map packages/frontend/schema.graphql +.tool-versions From 44f69db344d4764e4174f44f9052548195014ec1 Mon Sep 17 00:00:00 2001 From: Cristian Balas Date: Wed, 8 Sep 2021 15:39:53 +0300 Subject: [PATCH 5/7] [CI] new deployment --- .circleci/config.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index b5fc54676..5b6d104c2 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -33,7 +33,7 @@ workflows: context: main-builds filters: branches: - only: cristi/webhookservice_ci_build + only: cristi/ci-new-dep jobs: test_server: @@ -97,6 +97,7 @@ jobs: ./.circleci/deploy.sh if [[ "$CIRCLE_TAG" =~ ^v.* ]]; then env K8S_CLUSTER=TOR1 K8S_NAMESPACE=${K8S_NAMESPACE_TOR1_1_RELEASE} ./.circleci/deploy_in_new_setup.sh + env K8S_CLUSTER=LON1 K8S_NAMESPACE=${K8S_NAMESPACE_LON1_1_RELEASE} ./.circleci/deploy_in_new_setup.sh else env K8S_CLUSTER=TOR1 K8S_NAMESPACE=${K8S_NAMESPACE_TOR1_1_LATEST} ./.circleci/deploy_in_new_setup.sh fi From bc4526a159c07124bf501cbb1d1a08f708a1b5b4 Mon Sep 17 00:00:00 2001 From: Alan Rynne Date: Wed, 8 Sep 2021 18:03:47 +0200 Subject: [PATCH 6/7] fix: Added matomo to Embed app --- packages/frontend/src/embed/EmbedApp.vue | 5 ++++- packages/frontend/src/embed/embedApp.js | 8 ++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/packages/frontend/src/embed/EmbedApp.vue b/packages/frontend/src/embed/EmbedApp.vue index 9ed260791..563eb5c86 100644 --- a/packages/frontend/src/embed/EmbedApp.vue +++ b/packages/frontend/src/embed/EmbedApp.vue @@ -3,6 +3,9 @@ diff --git a/packages/frontend/src/embed/embedApp.js b/packages/frontend/src/embed/embedApp.js index 0de4b582e..47de10ca3 100644 --- a/packages/frontend/src/embed/embedApp.js +++ b/packages/frontend/src/embed/embedApp.js @@ -4,6 +4,14 @@ import vuetify from './embedVuetify' import router from './embedRouter' Vue.config.productionTip = false +import VueMatomo from 'vue-matomo' + +Vue.use(VueMatomo, { + host: 'https://speckle.matomo.cloud', + siteId: 4, + router: router +}) + new Vue({ router, vuetify, From ece678715aa0f8776482c0941bed34335029daea Mon Sep 17 00:00:00 2001 From: Alan Rynne Date: Wed, 8 Sep 2021 19:28:32 +0200 Subject: [PATCH 7/7] fix(embed): Removed superfluous matomo call --- packages/frontend/src/embed/EmbedApp.vue | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/frontend/src/embed/EmbedApp.vue b/packages/frontend/src/embed/EmbedApp.vue index 563eb5c86..9ed260791 100644 --- a/packages/frontend/src/embed/EmbedApp.vue +++ b/packages/frontend/src/embed/EmbedApp.vue @@ -3,9 +3,6 @@