From 5942c0967130dee11345ecfb22b85864de71e68a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gerg=C5=91=20Jedlicska?= Date: Wed, 26 Jul 2023 21:00:51 +0200 Subject: [PATCH 1/3] feat(server, helm): add guest role feature flag --- packages/server/modules/shared/helpers/envHelper.ts | 4 ++++ utils/helm/speckle-server/templates/server/deployment.yml | 5 +++++ utils/helm/speckle-server/values.yaml | 3 +++ 3 files changed, 12 insertions(+) diff --git a/packages/server/modules/shared/helpers/envHelper.ts b/packages/server/modules/shared/helpers/envHelper.ts index 3fc154e28..91afa4199 100644 --- a/packages/server/modules/shared/helpers/envHelper.ts +++ b/packages/server/modules/shared/helpers/envHelper.ts @@ -187,3 +187,7 @@ export function speckleAutomateUrl() { export function ignoreMissingMigrations() { return ['1', 'true'].includes(process.env.IGNORE_MISSING_MIRATIONS || 'false') } + +export function enableServerGuests() { + return ['1', 'true'].includes(process.env.ENABLE_SERVER_GUESTS || 'false') +} diff --git a/utils/helm/speckle-server/templates/server/deployment.yml b/utils/helm/speckle-server/templates/server/deployment.yml index 9d7bd9621..8f70b96c6 100644 --- a/utils/helm/speckle-server/templates/server/deployment.yml +++ b/utils/helm/speckle-server/templates/server/deployment.yml @@ -209,6 +209,11 @@ spec: key: {{ default "google_client_secret" .Values.server.auth.google.clientSecret.secretKey }} {{- end }} + {{- if .Values.serverGuestsEnabled }} + - name: ENABLE_SERVER_GUESTS + value: true + {{- end }} + # Github Auth {{- if .Values.server.auth.github.enabled }} - name: STRATEGY_GITHUB diff --git a/utils/helm/speckle-server/values.yaml b/utils/helm/speckle-server/values.yaml index d9fabb523..c9e0c9956 100644 --- a/utils/helm/speckle-server/values.yaml +++ b/utils/helm/speckle-server/values.yaml @@ -97,6 +97,9 @@ file_size_limit_mb: 100 ## enable_prometheus_monitoring: false +## @param serverGuestsEnabled Enables users to join the server as Guests, having limiter permissions +serverGuestsEnabled: false + prometheusMonitoring: ## @param prometheusMonitoring.namespace If provided, deploys Speckle's Prometheus resources (e.g. ServiceMonitor) in the given namespace ## Prometheus prior to v0.19.0, or any version when deployed with default parameters, expects ServiceMonitors to be deployed within the same namespace. From 879b4af25bd927475a8e310997ac3a70af673a4c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gerg=C5=91=20Jedlicska?= Date: Wed, 26 Jul 2023 21:19:36 +0200 Subject: [PATCH 2/3] ci(circleci): update server tests resource class, fixing oom --- .circleci/config.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.circleci/config.yml b/.circleci/config.yml index 5f99e630f..68b877d0d 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -333,6 +333,7 @@ jobs: command: server /data --console-address ":9001" # environment: + resource_class: medium+ environment: NODE_ENV: test DATABASE_URL: 'postgres://speckle:speckle@127.0.0.1:5432/speckle2_test' From 606a04adf8f071e2fbab4da4ed878250b65a3ee8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gerg=C5=91=20Jedlicska?= Date: Wed, 26 Jul 2023 21:33:49 +0200 Subject: [PATCH 3/3] chore(helm): update values json schema --- utils/helm/speckle-server/values.schema.json | 5 +++++ utils/helm/speckle-server/values.yaml | 6 +++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/utils/helm/speckle-server/values.schema.json b/utils/helm/speckle-server/values.schema.json index 850a6e2ba..b9491a413 100644 --- a/utils/helm/speckle-server/values.schema.json +++ b/utils/helm/speckle-server/values.schema.json @@ -97,6 +97,11 @@ "description": "This maximum size of any single file (unit is Megabytes) that can be uploaded to Speckle", "default": 100 }, + "serverGuestsEnabled": { + "type": "boolean", + "description": "Enables users to join the server as Guests, having limiter permissions", + "default": false + }, "enable_prometheus_monitoring": { "type": "boolean", "description": "If enabled, Speckle deploys a Prometheus ServiceMonitor resource", diff --git a/utils/helm/speckle-server/values.yaml b/utils/helm/speckle-server/values.yaml index c9e0c9956..079a3e70f 100644 --- a/utils/helm/speckle-server/values.yaml +++ b/utils/helm/speckle-server/values.yaml @@ -84,6 +84,9 @@ secretName: server-vars ## file_size_limit_mb: 100 +## @param serverGuestsEnabled Enables users to join the server as Guests, having limiter permissions +serverGuestsEnabled: false + ## @section Monitoring ## @descriptionStart ## This enables metrics generated by Speckle to be ingested by Prometheus: https://prometheus.io/ @@ -97,9 +100,6 @@ file_size_limit_mb: 100 ## enable_prometheus_monitoring: false -## @param serverGuestsEnabled Enables users to join the server as Guests, having limiter permissions -serverGuestsEnabled: false - prometheusMonitoring: ## @param prometheusMonitoring.namespace If provided, deploys Speckle's Prometheus resources (e.g. ServiceMonitor) in the given namespace ## Prometheus prior to v0.19.0, or any version when deployed with default parameters, expects ServiceMonitors to be deployed within the same namespace.