From 32a5a36ae35971675393f2b6080c175c89077180 Mon Sep 17 00:00:00 2001 From: Kristaps Fabians Geikins Date: Thu, 21 Mar 2024 11:18:00 +0100 Subject: [PATCH] feat(fe2): project tabs synced w/ URL + various hydration mismatch fixes (#2149) * WIP project tabs + resolved various hydration mismatches * hydration mismatch workaround * getting rid if old pages * fixed page tab underlines * minor cleanup * support trailing slash * a few viewer bugfixes --- .../components/common/model/Select.vue | 4 + .../CreateEditApplicationDialog.vue | 4 + .../developer-settings/CreateTokenDialog.vue | 4 + .../components/form/select/ProjectRoles.vue | 4 + .../components/form/select/Projects.vue | 4 + .../components/form/select/ServerRoles.vue | 4 + .../components/form/select/Users.vue | 4 + .../components/header/NavNotifications.vue | 3 +- .../frontend-2/components/header/NavShare.vue | 3 +- .../components/header/NavUserMenu.vue | 3 +- .../project/CommentPermissionsSelect.vue | 4 + .../components/project/VisibilitySelect.vue | 4 + .../project/page/discussions/Header.vue | 3 + .../project/page/discussions/Tab.vue | 10 +- .../project/page/models/Actions.vue | 2 + .../components/project/page/models/Header.vue | 4 + .../components/project/page/models/Tab.vue | 10 +- .../project/page/team/PermissionSelect.vue | 4 + .../webhooks-page/CreateOrEditDialog.vue | 4 + .../components/viewer/explode/Menu.vue | 72 +++--- .../viewer/measurements/UnitSelect.vue | 5 + .../frontend-2/components/viewer/sun/Menu.vue | 170 ++++++------- .../components/viewer/views/Menu.vue | 3 +- .../lib/common/generated/gql/gql.ts | 16 +- .../lib/common/generated/gql/graphql.ts | 8 +- .../frontend-2/lib/common/helpers/route.ts | 12 +- .../lib/projects/graphql/queries.ts | 4 + .../lib/viewer/composables/setup.ts | 11 +- .../pages/projects/[id]/discussions.vue | 59 ----- .../frontend-2/pages/projects/[id]/index.vue | 90 ++++++- .../pages/projects/[id]/index/discussions.vue | 3 + .../pages/projects/[id]/index/index.vue | 5 + .../pages/projects/[id]/models/index.vue | 80 ------ .../src/components/form/select/Badges.vue | 4 + .../src/components/form/select/Base.vue | 16 +- .../src/components/form/select/SourceApps.vue | 8 + .../src/components/layout/Menu.vue | 3 +- .../src/components/layout/PageTabs.stories.ts | 79 +++++- .../src/components/layout/PageTabs.vue | 49 ++-- .../src/components/user/AvatarEditable.vue | 3 + .../ui-components/src/composables/testing.ts | 35 +++ .../src/helpers/layout/components.ts | 2 +- yarn.lock | 227 +++--------------- 43 files changed, 504 insertions(+), 542 deletions(-) delete mode 100644 packages/frontend-2/pages/projects/[id]/discussions.vue create mode 100644 packages/frontend-2/pages/projects/[id]/index/discussions.vue create mode 100644 packages/frontend-2/pages/projects/[id]/index/index.vue delete mode 100644 packages/frontend-2/pages/projects/[id]/models/index.vue create mode 100644 packages/ui-components/src/composables/testing.ts diff --git a/packages/frontend-2/components/common/model/Select.vue b/packages/frontend-2/components/common/model/Select.vue index 32d2ebdd2..3b8795e2a 100644 --- a/packages/frontend-2/components/common/model/Select.vue +++ b/packages/frontend-2/components/common/model/Select.vue @@ -8,6 +8,8 @@ :multiple="multiple" :disabled="!items.length" :allow-unset="allowUnset" + :label-id="labelId" + :button-id="buttonId" by="id" >