From 22f13b152dc893d1007490cb588952e0bc77b1db Mon Sep 17 00:00:00 2001 From: Iain Sproat <68657+iainsproat@users.noreply.github.com> Date: Fri, 29 Aug 2025 11:16:48 +0100 Subject: [PATCH] fix(server/workspace): reduce log level for user-configured oidc problem (#5341) * fix(server/workspace): reduce log level for user-configured oidc problem * status code should not be 500 as it is a user error --- packages/server/modules/workspaces/errors/sso.ts | 1 + packages/server/modules/workspaces/rest/sso.ts | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/server/modules/workspaces/errors/sso.ts b/packages/server/modules/workspaces/errors/sso.ts index 2cdbd92d0..95e09fa9b 100644 --- a/packages/server/modules/workspaces/errors/sso.ts +++ b/packages/server/modules/workspaces/errors/sso.ts @@ -32,6 +32,7 @@ export class SsoProviderProfileMissingError extends BaseError { export class SsoProviderProfileMissingPropertiesError extends BaseError { static code = 'SSO_PROVIDER_PROFILE_MISSING_PROPERTIES_ERROR' + static statusCode = 400 constructor(properties: string[]) { super( [ diff --git a/packages/server/modules/workspaces/rest/sso.ts b/packages/server/modules/workspaces/rest/sso.ts index 96ea8348f..f507c82bb 100644 --- a/packages/server/modules/workspaces/rest/sso.ts +++ b/packages/server/modules/workspaces/rest/sso.ts @@ -736,9 +736,9 @@ const getOidcProviderUserDataFactory = throw new SsoProviderProfileMissingError() } if (!isValidOidcProfile(oidcProviderUserData)) { - req.log.error( + req.log.info( { providedClaims: Object.keys(oidcProviderUserData) }, - 'Missing required properties on OIDC provider.' + 'Missing required properties ("email" or "upn") on OIDC provider.' ) throw new SsoProviderProfileMissingPropertiesError(['email']) }