diff --git a/README.md b/README.md index 385b06885..4711d20ed 100644 --- a/README.md +++ b/README.md @@ -117,9 +117,9 @@ Essentially, ensure you have **Volar** enabled, and the built in **TypeScript an We have a [Maildev](https://github.com/maildev/maildev) container available that you can use to see all e-mails sent out from the app. Make sure your `server` .env file is configured properly to use it: -```bash +``` EMAIL=true -EMAIL_FROM="no-reply@example.org" +EMAIL_FROM="speckle@speckle.local" EMAIL_HOST="localhost" EMAIL_PORT="1025" ``` diff --git a/docker-compose-speckle.yml b/docker-compose-speckle.yml index 33519479d..291863c50 100644 --- a/docker-compose-speckle.yml +++ b/docker-compose-speckle.yml @@ -51,7 +51,6 @@ services: S3_CREATE_BUCKET: 'true' S3_REGION: '' # optional, defaults to 'us-east-1' FILE_SIZE_LIMIT_MB: 100 - EMAIL_FROM: 'no-reply@example.org' preview-service: build: diff --git a/packages/server/.env-example b/packages/server/.env-example index 191a08a76..2ec1188b3 100644 --- a/packages/server/.env-example +++ b/packages/server/.env-example @@ -64,7 +64,7 @@ S3_CREATE_BUCKET="true" # Emails ############################################################ EMAIL=true -EMAIL_FROM="no-reply@example.org" +EMAIL_FROM="speckle@speckle.local" EMAIL_HOST="localhost" EMAIL_PORT="1025" diff --git a/packages/server/modules/emails/services/sending.ts b/packages/server/modules/emails/services/sending.ts index c84c60c4b..4ece6bdef 100644 --- a/packages/server/modules/emails/services/sending.ts +++ b/packages/server/modules/emails/services/sending.ts @@ -1,6 +1,5 @@ import { logger } from '@/logging/logging' import { getTransporter } from '@/modules/emails/utils/transporter' -import { getEmailFromAddress } from '@/modules/shared/helpers/envHelper' export type SendEmailParams = { from?: string @@ -26,7 +25,7 @@ export async function sendEmail({ return false } try { - const emailFrom = getEmailFromAddress() + const emailFrom = process.env.EMAIL_FROM || 'no-reply@speckle.systems' await transporter.sendMail({ from: from || `"Speckle" <${emailFrom}>`, to, diff --git a/packages/server/modules/shared/helpers/envHelper.ts b/packages/server/modules/shared/helpers/envHelper.ts index 2a8621ac3..dfa449064 100644 --- a/packages/server/modules/shared/helpers/envHelper.ts +++ b/packages/server/modules/shared/helpers/envHelper.ts @@ -144,7 +144,7 @@ export function getFrontendOrigin(forceFe2?: boolean) { export function getServerOrigin() { if (!process.env.CANONICAL_URL) { throw new MisconfiguredEnvironmentError( - 'Server origin environment variable (CANONICAL_URL) not configured' + 'Server origin env var (CANONICAL_URL) not configured' ) } @@ -204,12 +204,3 @@ export function getOnboardingStreamCacheBustNumber() { const val = process.env.ONBOARDING_STREAM_CACHE_BUST_NUMBER || '1' return parseInt(val) || 1 } - -export function getEmailFromAddress() { - if (!process.env.EMAIL_FROM) { - throw new MisconfiguredEnvironmentError( - 'Email From environment variable (EMAIL_FROM) is not configured' - ) - } - return process.env.EMAIL_FROM -} diff --git a/utils/helm/speckle-server/values.schema.json b/utils/helm/speckle-server/values.schema.json index 6639153e4..fd3555f81 100644 --- a/utils/helm/speckle-server/values.schema.json +++ b/utils/helm/speckle-server/values.schema.json @@ -80,7 +80,7 @@ "docker_image_tag": { "type": "string", "description": "Speckle is published as a Docker Image. The version of the image which will be deployed is specified by this tag.", - "default": "2" + "default": "2.13.3" }, "imagePullPolicy": { "type": "string", diff --git a/utils/helm/speckle-server/values.yaml b/utils/helm/speckle-server/values.yaml index c338603ed..c3e63b86d 100644 --- a/utils/helm/speckle-server/values.yaml +++ b/utils/helm/speckle-server/values.yaml @@ -65,7 +65,7 @@ ingress: ## ## @param docker_image_tag Speckle is published as a Docker Image. The version of the image which will be deployed is specified by this tag. ## -docker_image_tag: '2' +docker_image_tag: 2.13.3 ## @param imagePullPolicy Determines the conditions when the Docker Images for Speckle should be pulled from the Image registry. ## ref: https://kubernetes.io/docs/concepts/containers/images/#image-pull-policy