From 07f7572c9d0f2f44d8f3bb84e7fbc272e8639ab7 Mon Sep 17 00:00:00 2001 From: Iain Sproat <68657+iainsproat@users.noreply.github.com> Date: Wed, 19 Oct 2022 16:43:12 +0100 Subject: [PATCH] fix(helm chart): fileimport should be deployed if s3 configmap is used (#1129) Fixes bug where fileimport-service was not deployed if an s3 configmap was used, instead of defining s3 endpoint etc. in helm chart values --- .../speckle-server/templates/fileimport_service/deployment.yml | 2 +- .../speckle-server/templates/fileimport_service/service.yml | 2 +- .../templates/fileimport_service/serviceaccount.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/utils/helm/speckle-server/templates/fileimport_service/deployment.yml b/utils/helm/speckle-server/templates/fileimport_service/deployment.yml index 8053f408c..581500383 100644 --- a/utils/helm/speckle-server/templates/fileimport_service/deployment.yml +++ b/utils/helm/speckle-server/templates/fileimport_service/deployment.yml @@ -1,4 +1,4 @@ -{{- if .Values.s3.endpoint }} +{{- if ( or .Values.s3.endpoint .Values.s3.configMap.enabled ) }} apiVersion: apps/v1 kind: Deployment metadata: diff --git a/utils/helm/speckle-server/templates/fileimport_service/service.yml b/utils/helm/speckle-server/templates/fileimport_service/service.yml index 5a237a6ee..38bc48f99 100644 --- a/utils/helm/speckle-server/templates/fileimport_service/service.yml +++ b/utils/helm/speckle-server/templates/fileimport_service/service.yml @@ -1,4 +1,4 @@ -{{- if .Values.s3.endpoint -}} +{{- if ( or .Values.s3.endpoint .Values.s3.configMap.enabled ) -}} apiVersion: v1 kind: Service metadata: diff --git a/utils/helm/speckle-server/templates/fileimport_service/serviceaccount.yml b/utils/helm/speckle-server/templates/fileimport_service/serviceaccount.yml index 24bdaba2e..1dd32b1ed 100644 --- a/utils/helm/speckle-server/templates/fileimport_service/serviceaccount.yml +++ b/utils/helm/speckle-server/templates/fileimport_service/serviceaccount.yml @@ -1,4 +1,4 @@ -{{- if .Values.fileimport_service.serviceAccount.create -}} +{{- if (and ( or .Values.s3.endpoint .Values.s3.configMap.enabled ) .Values.fileimport_service.serviceAccount.create) -}} apiVersion: v1 kind: ServiceAccount metadata: