fix: CNX-7547 serialize get properties (#56)

* serialize get properties * remove unwanted code segment --------- Co-authored-by: Connor Ivy <connor@speckle.systems>
2024-01-29 07:53:10 -06:00
parent eeba4f860e
commit a9cc5ed161
2 changed files with 16 additions and 2 deletions
@@ -78,7 +78,15 @@ export class BaseObjectSerializer {
  ): Promise<Map<string, any>> {
    const converted = new Map<string, any>()

-    for (const key of Object.keys(o)) {
+    const getters = Object.entries(Object.getOwnPropertyDescriptors(Reflect.getPrototypeOf(o)))
+      .filter(([key, descriptor]) => typeof descriptor.get === 'function' && key !== '__proto__')
+      .map(([key]) => key)
+
+    const objectKeys = new Array<string>()
+    objectKeys.push(...Object.keys(o))
+    objectKeys.push(...getters)
+
+    for (const key of objectKeys) {
      const objKey = key as keyof object
      converted.set(
        BaseObjectSerializer.CleanKey(key),