Files
pygeoapi/tests/test_api_ogr_provider.py
T
Just van den Broecke 7c6993719d add CRS Support for OGC API Feature pygeoapi Provider (#1174)
* OGC API - Features Part 2 (groundwork+CRS-BBOX) from PR #1155 - contributes to issue #1128

* #1128 provide conformance class for OAPIF Part 2 in /conformance page

* #1128 bitten by flake8...

* #1128 configurability CRS Feature Providers with syntax, defaults and tests

* #1128 configurability CRS Feature Providers refine for default values

* #1128 display supported CRSs in HTML Collection template

* #1128 config, mmetadata and tests for storageCRS and storageCrsCoordinateEpoch

* #1128 WIP for bbox-crs parameter support

* #1128 utility function and tests for default/mandatory supprted CRS list

* #1128 default supported CRS adaptation to OAPIF Part 2 standard

* #1128 grr flake8 whitespace

* #1128 start adding full API tests OGR for bbox-crs and crs parms

* #1128 fix flake8

* #1128 fix flake8 - install GDAL in workflow main for OGR tests

* #1128 fix flake8 - install GDAL in workflow main for OGR tests - need pip package?

* #1128 fix flake8 - install GDAL in workflow main for OGR tests - using libgdal-dev gdal-bin

* #1128 fix SensorThings test for main.yml Workflow

* #1128 fix SensorThings test for main.yml Workflow nr 2

* #1128 make all OGR tests working again

* #1128 make all OGR tests working again - flake8

* #1128 make all OGR tests working again - GeoSolutions WFS bbox

* #1128 #1155 add documentation for OGC OAPIF Part 2 CRS CRS BBOX support

* #1128 #1155 refine documentation for OGC OAPIF Part 2 CRS CRS BBOX support

* #1128 #1155 refine documentation to align with #1149

* #1128 #1155 rework from review OAS and pygeoapi config schema

* #1128 #1155 minor: compile Re for CRS URI only once as global var

* #1128 merge in changes from PR #1173 - fix missing import

* WIP Ogcapi features part 2 - Support for crs query parameter (#1149)

* feat(ogcapi_features_crs): start implementing crs support from ogcapi features part2

* Pass input and output CRSs WKT instead of crs transformation object

* fix longs lines and blank lines

* fix typo

* fix import for type annotation not supported by python version

* fix variable visibility in local scope

* fix tabs/spaces indentations

* Add support for the crs parameter to OGRProvider

* make flake8 happy

* Make crs transformation mechanism more consistent between PostgreSQL and OGR providers

* test(util): add two test functions in util.py

New functions: test_get_crs_from_uri and test_get_transform_from_crs

* fix too long lines...

* Update get_crs_from_uri and corresponding test function

* fix(get_crs_from_uri): make the error more explicit in if wrong crs uri format

* flake8 again...

* Keep support for source_srs/target_srs in config for OGRProvider

* revert changes made to pygeoapi-config-0.x.yml, overlap with PR 1155

* test: add test data and update test config file

* Extract 'crs' and 'storage_crs' and provider level instead of collection level

* feat(crs): new decorator to support coordinates transformation of feature collections

* feat(crs): 'crs' query parameter for CSVProvider

* test(crs): add tests for 'crs' query parameter

* test: update number of collections in test_describe_collections

* test: update number of collections in test_filter_dict_by_key_value

* fix(crs_transform): change the crs transformation decorator

Change the logic of the decorator so that it works for both functions that
return FeatureCollections and for functions tha return single Features.

* test: add tests for get_collection_item end-point with 'crs' parameter

* fix(test_get_collection_item_crs): id as path parameter, not query parameter

* test: unpack coordinates to create point geometry

* feat(crs): add suuport for crs query parameter for all providers of type 'feature'

* docs(crs): add documentation to illustrate use of 'crs' query parameters

* docs(crs): more data access examples

* fix typo and add new line

* refactor: specify None as default value for crs_transform_out parameter in _sqlalchemy_to_feature method

* changes for PR 1149, test_api and style formatting

* CRS84 as default crs also for test_get_collection_items_crs

* test(crs): test coordinates transformation implementation of PostgreSQLProvider

* test(crs): move tests to test_postgresql_provider

* fix test function calls

* change test to ensure returned features are the same

* add json format to request object

* test(crs): test coordinates transformation implementation of OGRProvider

* refactor(crs): make more compact get_collection_item and get_collection_items

Define two new static methods in API class, to create crs_transform_wkt and
setting content-crs header. These methods can be re-used in both
get_collection_item and get_collection_items methods and removes code
duplication.

---------

Co-authored-by: Just van den Broecke <just@justobjects.nl>

* #1178 fix flake8 error

* #1178 use EPSG:28992 i.s.o. 32631 - fix unit test OGR Shapefile

* #1174 use CRS-compliant Axis ordering for crs support

* #1174 fix and honour CRS 4258disable native CRS Transform in OGR Provider - Axis ordering not honoured...

* #1174 remove ADR tests rom test_util.py

* #1174 enable native CRS transform again in OGR Provider

* #1174 enable native CRS transform again in OGR Provider - fix config

* #1174 remove support for source/target_srs in OGRProvider - enforce transforms always based on storageCRS

* #1174 fix tests Postgresql Provider for Transforms

* #1174 fix tests Postgresql Provider for Transforms

* #1174 add tests for OGR Transformation and Axis Order

* #1174 Suppress potential axis-swapping in OGR ExportToJSON

* #1174 minor fix test - unassign spatialref before setgeom infeat

* #1174 minor fix test - unassign spatialref before setgeom infeat - flake8

* #1174 solve CI WFS test failures with GDAL HTTP config options

* #1174 bbox and bbox-crs defs local in openapi.py for CITE validators

* #1174 merge master - #1152 #1203 etc

* #1174 small doc changes

* #1174 move GeomObject typedef to beginning of util.py

* #1174 added debug logging in transform Decorator func

---------

Co-authored-by: Mathieu Tachon <92298764+MTachon@users.noreply.github.com>
2023-04-11 09:34:48 -04:00

217 lines
9.5 KiB
Python

# =================================================================
#
# Authors: Just van den Broecke <justb4@gmail.com>
# Authors: Tom Kralidis <tomkralidis@gmail.com>
#
# Copyright (c) 2019 Just van den Broecke
# Copyright (c) 2022 Tom Kralidis
#
# Permission is hereby granted, free of charge, to any person
# obtaining a copy of this software and associated documentation
# files (the "Software"), to deal in the Software without
# restriction, including without limitation the rights to use,
# copy, modify, merge, publish, distribute, sublicense, and/or sell
# copies of the Software, and to permit persons to whom the
# Software is furnished to do so, subject to the following
# conditions:
#
# The above copyright notice and this permission notice shall be
# included in all copies or substantial portions of the Software.
#
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
# OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
# NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
# HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
# WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
# FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
# OTHER DEALINGS IN THE SOFTWARE.
#
# =================================================================
import json
import logging
import pytest
from pygeoapi.api import (API)
from pygeoapi.util import yaml_load, geojson_to_geom
from .util import get_test_file_path, mock_request
LOGGER = logging.getLogger(__name__)
DEFAULT_CRS = 'http://www.opengis.net/def/crs/OGC/1.3/CRS84'
@pytest.fixture()
def config():
with open(get_test_file_path('pygeoapi-test-config-ogr.yml')) as fh:
return yaml_load(fh)
@pytest.fixture()
def api_(config):
return API(config)
def test_get_collection_items_bbox_crs(config, api_):
CRS_BBOX_DICT = {
'http://www.opengis.net/def/crs/OGC/1.3/CRS84': '5.71484, 52.12122, 5.71486, 52.12123', # noqa
'http://www.opengis.net/def/crs/EPSG/0/4326': '52.12122, 5.71484, 52.12123, 5.71486', # noqa
'http://www.opengis.net/def/crs/EPSG/0/28992': '177430, 459268, 177440, 459278' # noqa
}
COLLECTIONS = ['dutch_addresses_4326', 'dutch_addresses_28992']
for coll in COLLECTIONS:
# bbox-crs full extent
req = mock_request({'bbox': '5.670670, 52.042700, 5.829110, 52.123700', 'bbox-crs': 'http://www.opengis.net/def/crs/OGC/1.3/CRS84'}) # noqa
rsp_headers, code, response = api_.get_collection_items(req, coll) # noqa
features = json.loads(response)['features']
assert len(features) == 10
# bbox-crs partial extent, 1 feature, request with multiple CRSs
for crs in CRS_BBOX_DICT:
req = mock_request({'bbox': CRS_BBOX_DICT[crs], 'bbox-crs': crs}) # noqa
rsp_headers, code, response = api_.get_collection_items(req, coll) # noqa
features = json.loads(response)['features']
assert len(features) == 1
properties = features[0]['properties']
assert properties['straatnaam'] == 'Willinkhuizersteeg'
assert properties['huisnummer'] == '2'
# bbox-crs outside extent
req = mock_request({'bbox': '5, 51.9, 5.1, 52.0', 'bbox-crs': 'http://www.opengis.net/def/crs/OGC/1.3/CRS84'}) # noqa
rsp_headers, code, response = api_.get_collection_items(req, coll) # noqa
features = json.loads(response)['features']
assert len(features) == 0
# bbox-crs outside extent
req = mock_request({'bbox': '130000, 440000, 140000, 450000', 'bbox-crs': 'http://www.opengis.net/def/crs/EPSG/0/28992'}) # noqa
rsp_headers, code, response = api_.get_collection_items(req, coll) # noqa
features = json.loads(response)['features']
assert len(features) == 0
# bbox-crs outside extent - axis reversed CRS
req = mock_request({'bbox': '51.9, 5, 52.0, 5.1', 'bbox-crs': 'http://www.opengis.net/def/crs/EPSG/0/4326'}) # noqa
rsp_headers, code, response = api_.get_collection_items(req, coll) # noqa
features = json.loads(response)['features']
assert len(features) == 0
# bbox-crs full extent - axis reversed CRS
req = mock_request({'bbox': '52.042700, 5.670670, 52.123700, 5.829110', 'bbox-crs': 'http://www.opengis.net/def/crs/EPSG/0/4326'}) # noqa
rsp_headers, code, response = api_.get_collection_items(req, coll) # noqa
features = json.loads(response)['features']
assert len(features) == 10
def test_get_collection_items_crs(config, api_):
# 'http://www.opengis.net/def/crs/EPSG/0/4258': [52.12122746, 5.714847], # noqa
CRS_DICT = {
'none': [5.714847, 52.12122746], # noqa
'http://www.opengis.net/def/crs/OGC/1.3/CRS84': [5.714847, 52.12122746], # noqa
'http://www.opengis.net/def/crs/EPSG/0/28992': [177439, 459274], # noqa
'http://www.opengis.net/def/crs/EPSG/0/4326': [52.12122746, 5.714847], # noqa
}
# 'http://www.opengis.net/def/crs/EPSG/0/4258': '52.12122, 5.71484, 52.12123, 5.71486', # noqa
CRS_BBOX_DICT = {
'none': '5.71484, 52.12122, 5.71486, 52.12123', # noqa
'http://www.opengis.net/def/crs/OGC/1.3/CRS84': '5.71484, 52.12122, 5.71486, 52.12123', # noqa
'http://www.opengis.net/def/crs/EPSG/0/4326': '52.12122, 5.71484, 52.12123, 5.71486', # noqa
'http://www.opengis.net/def/crs/EPSG/0/28992': '177430, 459268, 177440, 459278' # noqa
}
COLLECTIONS = ['dutch_addresses_4326', 'dutch_addresses_28992']
for coll in COLLECTIONS:
# crs full extent to get target feature
req = mock_request({}) # noqa
rsp_headers, code, response = api_.get_collection_items(req, coll) # noqa
features = json.loads(response)['features']
assert len(features) == 10
feature_id = features[0]['id']
# request with multiple CRSs
for crs in CRS_DICT:
# Do for query (/items)
req = mock_request({'crs': crs}) # noqa
if crs == 'none':
# Test for default bbox CRS
req = mock_request({}) # noqa
crs = DEFAULT_CRS
rsp_headers, code, response = api_.get_collection_items(req, coll) # noqa
features = json.loads(response)['features']
assert len(features) == 10
test_feature = features[0]
assert test_feature['id'] == feature_id
properties = test_feature['properties']
assert properties['straatnaam'] == 'Willinkhuizersteeg'
assert properties['huisnummer'] == '2'
# Test if CRS in header and the feature coordinates
# correspond to CRS parameter.
assert rsp_headers['Content-Crs'] == f'<{crs}>'
test_geom_json = test_feature.get('geometry')
test_geom = geojson_to_geom(test_geom_json)
crs_geom = geojson_to_geom({'type': 'Point', 'coordinates': CRS_DICT[crs]}) # noqa
assert test_geom.equals_exact(crs_geom, 1), f'coords not equal for CRS: {crs} {crs_geom} in COLL: {coll} {test_geom}' # noqa
# Same for single Feature 'get'
req = mock_request({'crs': crs}) # noqa
rsp_headers, code, response = api_.get_collection_item(req, coll, feature_id) # noqa
test_feature = json.loads(response)
assert test_feature['id'] == feature_id
properties = test_feature['properties']
assert properties['straatnaam'] == 'Willinkhuizersteeg'
assert properties['huisnummer'] == '2'
# Test if CRS in header and the feature coordinates
# correspond to CRS parameter.
assert rsp_headers['Content-Crs'] == f'<{crs}>'
test_geom_json = test_feature.get('geometry')
test_geom = geojson_to_geom(test_geom_json)
crs_geom = geojson_to_geom({'type': 'Point', 'coordinates': CRS_DICT[crs]}) # noqa
assert test_geom.equals_exact(crs_geom, 1), f'coords not equal for CRS: {crs} {crs_geom} in COLL: {coll} {test_geom}' # noqa
# Test combining BBOX and BBOX-CRS
for bbox_crs in CRS_BBOX_DICT:
# Do for query (/items)
req = mock_request({'crs': crs, 'bbox': CRS_BBOX_DICT[bbox_crs], 'bbox-crs': bbox_crs}) # noqa
if bbox_crs == 'none':
# Test for default bbox CRS
req = mock_request({'crs': crs, 'bbox': CRS_BBOX_DICT[bbox_crs]}) # noqa
bbox_crs = DEFAULT_CRS
rsp_headers, code, response = api_.get_collection_items(req, coll) # noqa
features = json.loads(response)['features']
assert len(features) == 1
test_feature = features[0]
assert test_feature['id'] == feature_id
properties = test_feature['properties']
assert properties['straatnaam'] == 'Willinkhuizersteeg'
assert properties['huisnummer'] == '2'
# Test if CRS in header and the feature coordinates
# correspond to CRS parameter.
assert rsp_headers['Content-Crs'] == f'<{crs}>'
test_geom_json = test_feature.get('geometry')
test_geom = geojson_to_geom(test_geom_json)
crs_geom = geojson_to_geom({'type': 'Point', 'coordinates': CRS_DICT[crs]}) # noqa
assert test_geom.equals_exact(crs_geom, 1), f'coords not equal for CRS: {crs} {crs_geom} in COLL: {coll} {test_geom} bbox-crs={bbox_crs}' # noqa