From ed9b8689f70bb217337cf0bd5f75f550b8abb6ea Mon Sep 17 00:00:00 2001 From: Siddharth Date: Sun, 5 Apr 2026 16:20:29 -0700 Subject: [PATCH] fix: catch expected page close error in e2e test evaluate call switchToEditor closes the HUD window, which terminates the Playwright page context before evaluate can return. Catch at the outer level. --- tests/e2e/gif-export.spec.ts | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/tests/e2e/gif-export.spec.ts b/tests/e2e/gif-export.spec.ts index 132a6dd..c32c036 100644 --- a/tests/e2e/gif-export.spec.ts +++ b/tests/e2e/gif-export.spec.ts @@ -72,14 +72,15 @@ test("exports a GIF from a loaded video", async () => { fs.mkdirSync(recordingsDir, { recursive: true }); fs.copyFileSync(TEST_VIDEO, testVideoInRecordings); - await hudWindow.evaluate((videoPath: string) => { - window.electronAPI.setCurrentVideoPath(videoPath); - try { + try { + await hudWindow.evaluate((videoPath: string) => { + window.electronAPI.setCurrentVideoPath(videoPath); window.electronAPI.switchToEditor(); - } catch { - // Expected: HUD window closes during this call, killing the context. - } - }, testVideoInRecordings); + }, testVideoInRecordings); + } catch { + // Expected: switchToEditor() closes the HUD window, killing the + // Playwright page context before evaluate() can resolve. + } // ── 3. Switch to the editor window. This closes the HUD and opens // a new BrowserWindow with ?windowType=editor.