From a8427b950e29641a38b136cd2afae7f96e5dc388 Mon Sep 17 00:00:00 2001 From: JasonOA888 Date: Mon, 6 Apr 2026 02:01:01 +0800 Subject: [PATCH] fix: resolve lint errors for CI - Add updateState to useEffect dependency array - Remove ineffective biome-ignore suppression comment - Fix formatting in userPreferences.ts per biome rules --- src/components/video-editor/VideoEditor.tsx | 6 ++---- src/lib/userPreferences.ts | 9 +++++++-- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/src/components/video-editor/VideoEditor.tsx b/src/components/video-editor/VideoEditor.tsx index 4168ef8..a85ccaf 100644 --- a/src/components/video-editor/VideoEditor.tsx +++ b/src/components/video-editor/VideoEditor.tsx @@ -364,7 +364,7 @@ export default function VideoEditor() { // overwriting saved prefs with defaults on the first render const [prefsHydrated, setPrefsHydrated] = useState(false); - // Load persisted user preferences on mount + // Load persisted user preferences on mount (intentionally runs once) useEffect(() => { const prefs = loadUserPreferences(); updateState({ @@ -374,9 +374,7 @@ export default function VideoEditor() { setExportQuality(prefs.exportQuality); setExportFormat(prefs.exportFormat); setPrefsHydrated(true); - // We intentionally only want this to run once on mount - // biome-ignore lint/correctness/useExhaustiveDependencies: mount-only effect - }, []); + }, [updateState]); // Auto-save user preferences when settings change useEffect(() => { diff --git a/src/lib/userPreferences.ts b/src/lib/userPreferences.ts index 5839799..e060788 100644 --- a/src/lib/userPreferences.ts +++ b/src/lib/userPreferences.ts @@ -56,7 +56,10 @@ export function loadUserPreferences(): UserPreferences { return { padding: - typeof raw.padding === "number" && Number.isFinite(raw.padding) && raw.padding >= 0 && raw.padding <= 100 + typeof raw.padding === "number" && + Number.isFinite(raw.padding) && + raw.padding >= 0 && + raw.padding <= 100 ? raw.padding : DEFAULT_PREFS.padding, aspectRatio: @@ -64,7 +67,9 @@ export function loadUserPreferences(): UserPreferences { ? (raw.aspectRatio as AspectRatio) : DEFAULT_PREFS.aspectRatio, exportQuality: - raw.exportQuality === "medium" || raw.exportQuality === "good" || raw.exportQuality === "source" + raw.exportQuality === "medium" || + raw.exportQuality === "good" || + raw.exportQuality === "source" ? (raw.exportQuality as ExportQuality) : DEFAULT_PREFS.exportQuality, exportFormat: