From 238fc97c6d602e148fab423fe9fec8b143345eef Mon Sep 17 00:00:00 2001 From: EtienneLescot Date: Wed, 6 May 2026 14:50:46 +0200 Subject: [PATCH] fix: preserve cursor and audio in exports --- src/components/video-editor/VideoEditor.tsx | 2 -- src/lib/exporter/audioEncoder.ts | 2 +- src/lib/exporter/videoExporter.test.ts | 1 - src/lib/exporter/videoExporter.ts | 15 +-------------- 4 files changed, 2 insertions(+), 18 deletions(-) diff --git a/src/components/video-editor/VideoEditor.tsx b/src/components/video-editor/VideoEditor.tsx index ae223ac..9af6c25 100644 --- a/src/components/video-editor/VideoEditor.tsx +++ b/src/components/video-editor/VideoEditor.tsx @@ -1661,7 +1661,6 @@ export default function VideoEditor() { padding, cropRegion, cursorRecordingData, - cursorRecordingDataLoading, cursorScale: showCursor ? cursorSize : 0, cursorSmoothing, cursorMotionBlur, @@ -1746,7 +1745,6 @@ export default function VideoEditor() { padding, cropRegion, cursorRecordingData, - cursorRecordingDataLoading, annotationRegions, isPlaying, aspectRatio, diff --git a/src/lib/exporter/audioEncoder.ts b/src/lib/exporter/audioEncoder.ts index 870fdc3..18dac62 100644 --- a/src/lib/exporter/audioEncoder.ts +++ b/src/lib/exporter/audioEncoder.ts @@ -14,8 +14,8 @@ export interface ExportAudioCodec { } const EXPORT_AUDIO_CODECS: ExportAudioCodec[] = [ - { encoderCodec: "mp4a.40.2", muxerCodec: "aac", label: "AAC" }, { encoderCodec: "opus", muxerCodec: "opus", label: "Opus" }, + { encoderCodec: "mp4a.40.2", muxerCodec: "aac", label: "AAC" }, ]; export class AudioProcessor { diff --git a/src/lib/exporter/videoExporter.test.ts b/src/lib/exporter/videoExporter.test.ts index b90ff39..3f14ec1 100644 --- a/src/lib/exporter/videoExporter.test.ts +++ b/src/lib/exporter/videoExporter.test.ts @@ -73,7 +73,6 @@ describe("isSourceCopyFastPathEligible", () => { expect( isSourceCopyFastPathEligible( createConfig({ - cursorRecordingDataLoading: true, cursorScale: 2, }), videoInfo, diff --git a/src/lib/exporter/videoExporter.ts b/src/lib/exporter/videoExporter.ts index 231548d..973e6be 100644 --- a/src/lib/exporter/videoExporter.ts +++ b/src/lib/exporter/videoExporter.ts @@ -40,7 +40,6 @@ export interface VideoExporterConfig extends ExportConfig { webcamSizePreset?: WebcamSizePreset; webcamPosition?: { cx: number; cy: number } | null; cursorRecordingData?: CursorRecordingData | null; - cursorRecordingDataLoading?: boolean; cursorScale?: number; cursorSmoothing?: number; cursorMotionBlur?: number; @@ -71,19 +70,7 @@ function hasActiveSpeedRegions(regions?: SpeedRegion[]) { } function hasNativeCursorOverlay(config: VideoExporterConfig) { - if ((config.cursorScale ?? 0) <= 0) { - return false; - } - - if (config.cursorRecordingDataLoading) { - return true; - } - - return Boolean( - config.cursorRecordingData?.provider === "native" && - config.cursorRecordingData.samples.length > 0 && - config.cursorRecordingData.assets.length > 0, - ); + return (config.cursorScale ?? 0) > 0; } function hasCursorHighlightOverlay(config: VideoExporterConfig) {